From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1CCFA0C4B; Thu, 14 Oct 2021 19:57:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D0611410EA; Thu, 14 Oct 2021 19:57:09 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 8DA934003C; Thu, 14 Oct 2021 19:57:07 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10137"; a="291236546" X-IronPort-AV: E=Sophos;i="5.85,373,1624345200"; d="scan'208";a="291236546" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2021 10:46:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,373,1624345200"; d="scan'208";a="442925406" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga003.jf.intel.com with ESMTP; 14 Oct 2021 10:46:16 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 14 Oct 2021 10:46:15 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 14 Oct 2021 10:46:15 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 14 Oct 2021 10:46:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l2/+JPV6EfNR+iCnwTvodyWCiLvO/Av74LORMk3LPTHRdWgDUhbMmFk25zquGnllkDIHJOoYvmvLC1xxlCOmRjTAm4c+Lj5/wANgDZkJXFoU+L7SURw3yw5ZEJMfsmi+7jrNMFyjAAUCaOysLNrgmukOD6JBphXqHxCZtcDhi2LmbRzAzxZiR50muS6wb0UgTlf5W15I7amgWWzJ5c4McHemPNaykBaMB1OugIAEWgkisWTPHlRpBsSXiFtJZCSB52Iz9qw5kGCYV+HXj1cZKW/OJ550+hh0metrl6+wsntgg/Jkh5yKgO2sfaG7/s4zzqcpIjMIiAPM+RJgqScQNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7NoVPyAhb53xI8sN2/cUmLlxzdFos8rvnt5lksisN7M=; b=GhkXz9iDRcS2pem9HCkD0FnFlMUhDPOdlTI5JtLTiVLmwTCkc9cX4Q1yZhuj4RyvxSJCmcZZRKIjIPO9fIh8S0bCn04tEL6pdHcXQXVhxI6INwrlHI2tZ741b5KJDjarHtq9ykuT2P8YfJWe78NNwbGF93UD1dl8G1r+mFH4BOYJIpZiCOj7YKlQR80HyHiYrlDPWJaCVqiMMAeHyXWN1Ok0yzUmZyYIlzwb0cqysx48UmuQ5NpqDxQySa4ZGMOvcJouLky4KTDu8SBbPeYwmH8x4FFNVqfDmdl+nzO+0897GxsrIygMguZiWowlk5cCqE34lspyajLBKhdgMXRNBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7NoVPyAhb53xI8sN2/cUmLlxzdFos8rvnt5lksisN7M=; b=E1hYqbcWZwfwHcWTuL5Oq0MLC3t5FLt2w7jVvJTIu1qoiPDph8e1Z349nvtiLnzYk9yPzmhYEcwkb153osUNcM0Vh13Tm1k4gwgykTEJQVbFu74WvwZ0TMxD/a+YWxuhUBhC/rGBOou/TSQ6qGSPJS1YGS/wA0RuvENK0jMMXrw= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) by PH0PR11MB4968.namprd11.prod.outlook.com (2603:10b6:510:39::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Thu, 14 Oct 2021 17:46:13 +0000 Received: from PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::4c6a:b2b:c561:4c85]) by PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::4c6a:b2b:c561:4c85%8]) with mapi id 15.20.4587.026; Thu, 14 Oct 2021 17:46:13 +0000 To: David Marchand <david.marchand@redhat.com> CC: dev <dev@dpdk.org>, "Wang, Yipeng1" <yipeng1.wang@intel.com>, "Gobriel, Sameh" <sameh.gobriel@intel.com>, Bruce Richardson <bruce.richardson@intel.com>, dpdk stable <stable@dpdk.org> References: <1633728526-197782-1-git-send-email-vladimir.medvedkin@intel.com> <CAJFAV8yr_uHs9AHKvwyPC5+hkR98UeCmeGs6W50HPMROp07kJg@mail.gmail.com> <47f6bf7f-259f-f376-3e23-a2b0c7b886b7@intel.com> <CAJFAV8xKJSriZSy1---3KMzM7O9e0zMqzCE9HkKvrD3754DU_w@mail.gmail.com> From: "Medvedkin, Vladimir" <vladimir.medvedkin@intel.com> Message-ID: <3227dee5-584b-119c-2b79-e44f31b23fed@intel.com> Date: Thu, 14 Oct 2021 19:46:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.14.0 In-Reply-To: <CAJFAV8xKJSriZSy1---3KMzM7O9e0zMqzCE9HkKvrD3754DU_w@mail.gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR0802CA0045.eurprd08.prod.outlook.com (2603:10a6:4:a3::31) To PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) MIME-Version: 1.0 Received: from [192.198.151.52] (192.198.151.52) by DB6PR0802CA0045.eurprd08.prod.outlook.com (2603:10a6:4:a3::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend Transport; Thu, 14 Oct 2021 17:46:12 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1749f15f-778e-4cb5-53e2-08d98f3a83fd X-MS-TrafficTypeDiagnostic: PH0PR11MB4968: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: <PH0PR11MB4968B8E1A6FB4ACBC9152B6696B89@PH0PR11MB4968.namprd11.prod.outlook.com> X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Sps4g7t3Hv/ZXuimz0mCqiXu/VPs2i+8MEQTm/K1hxu3jC4cZAJicnSVII87T0/TpfWvNy74ULFaV7cfL1/Ixs4WRAzTLp80AlJ1Ro5loQiO9SQhbNlvhFHgJTopLWMPtJ5WOfAFXR1EEEL4JVcSF0zpdcg5P2Sx72eTGthnj/gkI7VWjPYFrhf9v/+XcTfP4j12b0r2i7d7grrIKJVKfwHLSdH409hvjm/J3VkSw71OYsedTeYf2bPL999oYTWLDeKWE7iXvEd5bFAiSu5jMGbjbfvUJJ+17aWWLSrdxbqqimJiBpm7jN8qfEPuzW4pXpvOUH2Z/ruEJ7rh1i7Vvj3ycu9dnB/NgZtIfiz0LPtPuL/yQ7ZjbYiVkthKRXs2rX4FBjGQhVFJJk4nELwWRKqK+EQdlimB/pTiDrB3PmxHLaa2PLrgFxSi5EaUK8/ytnY3nMuF+EX3+wG+aarMY/HvdNG/TKtEm9/+cadBA0rF7ApkMMCAREFjeH6BulYk+qR4+qMEt0a4sIBnnmBAvSpYv6DD7Abpioyw14q1cGu420ScEVXjpc9mqHMn1gkhhfWXZPQkKOqgciDoePj4cCzFjNYUnmitMrpdXSaHIctJc64OjtuCmwzxcdeLJD6u+0sIrmYOrtSrnE8xUHQKzsXQUVKngwKerJ4i/xXD7MetFw4jacGtEP0y6zd0uBd7adys6tmpWLjBHAh+Dkd3ekMt24bZqdJjpI6//qxuih5Ein5Av6j+UlQ7VRLk/tejwEaUrQcLvlVc35qcfaO+Qw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5013.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(4326008)(38100700002)(31686004)(5660300002)(6666004)(16576012)(53546011)(82960400001)(2906002)(86362001)(31696002)(6486002)(36756003)(316002)(54906003)(26005)(8936002)(186003)(6916009)(508600001)(2616005)(956004)(66556008)(6706004)(66946007)(66476007)(8676002)(3940600001)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R3RLVlEzbU9aVEgxTUg1TFJGMk1DQXYzOExPTDM0NE9mQ3Rlai9pdVRhQ3lF?= =?utf-8?B?UWppNm1iT2F2OGV2aXQxSmFXVFpxRlo1NlhZdzVwbTkySlFiUDMyaVdDVUJa?= =?utf-8?B?L2FQZm8ybzVGY2JkY1MyZ1NZUnZaY2orR3lBTmVRdThXN0NYa1MrL1dpQTZi?= =?utf-8?B?RU03alFyYVNhOUs2MzFOR3BOeUx5Z2F6RWZpYTZmWHdMMGN2TTlFTnpuZWdE?= =?utf-8?B?WS9VVVlJRVVNNi9XOHVMd3hTaDl4dHRRY1MreDVkYnBjaHp5SFZ4amRjQ21h?= =?utf-8?B?eWRWN2xqcEp1dm1nenEzTVE3U2ZnSmZodjlEa015ajhUUy9mc0xQRFlHeC9l?= =?utf-8?B?Zld3K0R3UzZheG44Q3VRNmNPREN2ZzI5UjVuK0d6b1ZncDJYeW1lUkkzOTl5?= =?utf-8?B?UUt1RzFGQytWT2owcEtaWjAwbGpibCszT0hmOGtKcTRodTVNcWd5QXBPVm1a?= =?utf-8?B?U21JSzlHU3NyMTRxbzRYL0xqd2ZrbHR1WWFlcFNSMlRPM2UzaVJBdE1od2Rn?= =?utf-8?B?RFg3b01pWWlxWmtwb2NTcHRhTERWVlVxOVZzRXRBSTRlWEVPVVZSanBaNzk2?= =?utf-8?B?Ung0cXhuMURkVjZ6clVZNXJZZERjbDVvUWYwVjNvWGQ2OGFEMWNRcVUybkVo?= =?utf-8?B?akdRVm5Fbm9XQkp1NTdleGxsODlwWGtaZ1FPaytSRUFMNkxOcVBEWGkzSDg5?= =?utf-8?B?TmRMdUNUNkNTSWc0OHNPK1dDTy83Q0QxUERmb0tvL3FwcTJDVHRUQ0FJZmha?= =?utf-8?B?NXRyKzhISUh6SmlkREQ2LzBHdWxZREFFM1doa29tN25uL0pIV2xUYlhZSUg0?= =?utf-8?B?NWcrUzJPekRoQTNlOUNQU0ZmVXZ6dHlVNlA5YzJLSFJHNkljcVlKeDRSdkVR?= =?utf-8?B?N3drZURtbkxaZFdRQjE3QzJneTBHRXlTVnNiRithamVjN0JIeVdvTStmazg1?= =?utf-8?B?RG5xblZXTDU4VGFWdTh0RmlmYVlRUGhKVEFTU3ZXdDNROWFnQXlRR3BSbTcv?= =?utf-8?B?UlhoRm5GQjFNWGVMR0RTeHRnT0F0SFFQZmkvbUVXQjUrMzZGKzNMUjhOUmpl?= =?utf-8?B?NXJIVGR6cElYK0FLdDhod1pkOXRPMk9DaTNndi9tdlRuZEdSdTM4Q3dwd3Ft?= =?utf-8?B?bmdZQ2E0L3NiL3NDV3FWdG93SHJ1NHMvejN4L3VORERRRHR4bnVMZ1ZRT2V0?= =?utf-8?B?V2pETHo3VVJxQ2ZyQkYyRDgwTExKRnNPMFVFTmVjbVBQWHh5RXU3Wm5LMW1o?= =?utf-8?B?UXpIaXJWVldhakd1Qjl0Si9EZjhHMmpCUHRVT0hCQ0xleVMvQUd2dS9UZzBh?= =?utf-8?B?aEU0eGZLUzk4QWI5ekZWMDFPbEpBbjhGbGdzdTI0M0NzcGVJdmx3TGY2QkRQ?= =?utf-8?B?RE1Od2c4dWdCaFVKQmU1WnFoaCtBcXZFdHo4bGlYbThhemRQbG1yUmVjTFZS?= =?utf-8?B?WnZWc2duTjBmWHZURjY4T2daRndBVmoyYlI5cmcyeWJDVDNCdFdsY3Y3ZGYx?= =?utf-8?B?bGZCVlBhMUphcGEzcDFyRmhWSlBxYVBnZWsvTC8zdllmMnRNM1BqdTNPaGRj?= =?utf-8?B?UWo4NnVPaUlQSkNMQ1FOSWkwdldrUS8yZDVTTGRiQVZIM2NRUGxwaTZER3V0?= =?utf-8?B?enljaWNNcDFVNFVqV1ZmZWRRZnJMT3JGQWxSYk9xdWk5VGN0eTlxWVNrRDdO?= =?utf-8?B?TWtBZ1ZKdVZPTTZ3RkVwZENVWkJnVStOQmdSK1JjMkl5SGplTXM3NnNLajRO?= =?utf-8?Q?N+jKVnYs1myIg/g0QPaOQRuMfCOdUuJ/uJzQ3Uy?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1749f15f-778e-4cb5-53e2-08d98f3a83fd X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5013.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 17:46:13.6143 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KlLYQvgzQq0QZWhf+Dw1ESEoYSAwG+yF+L3GpEZNFd/bcTbFRYAzUqY5abfjGzY1txcsHl863yt+PuPLXSnWhNoDsOyiNI5G5kspaz7dKvw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4968 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] test/hash: fix buffer overflow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Hi David, On 14/10/2021 09:04, David Marchand wrote: > Hello Vladimir, > > On Wed, Oct 13, 2021 at 9:27 PM Medvedkin, Vladimir > <vladimir.medvedkin@intel.com> wrote: >>> With patch applied, ASan reports another issue. >>> Did you test your fix with ASan? >>> >> >> You're right, for some reason ASAN wasn't enabled. >> I applied patch and built running .ci/linux-build.sh, >> also I build with CFLAGS + LDFLAGS. >> >> Bruce suggested to use meson options instead of using CFLAGS, so >> meson configure build -Db_sanitize=address -Db_lundef=false >> works fine. > > Well, yes, you can directly do this. > I linked to my GHA patch in the bz, because I find it easier and > reproducible to push fixes in GHA and get the result: no question > about "did I enable ASan?" or "did I start the test correctly?". > > FYI, b_lundef seems necessary only with clang, gcc should be fine without it. > IIUC, those compilers went with different choices on how to pull > libasan (clang went with static, gcc went with shared). > Hopefully, we will have something easier to use in DPDK with Zhihong work. > Thanks! >> >> I'll sent v2 for this. > > Thanks, I'll look at it. > I'm going to send v3, because just dividing the size of the key for jhash_32b() cases is not correct (because rte_hash will compare just a part of the key in this case), so I'll replace rte_jhash_32b with a wrapper function. > -- Regards, Vladimir