From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A23AD43382; Wed, 22 Nov 2023 17:47:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0013641133; Wed, 22 Nov 2023 17:47:45 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 611AE41143; Wed, 22 Nov 2023 17:47:43 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 021D35C0250; Wed, 22 Nov 2023 11:47:43 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 22 Nov 2023 11:47:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1700671662; x=1700758062; bh=6ZxOszHWirk025ISPXCkIzchbB6EQ92Aupf S5/ap6RI=; b=bRMOXK+sui9eqA/qFgIgAvhq4eMDbH8QQLlvG7egHzLFU1V19CB ptfMKIwaPGMu9Byq4RsKRTww2BiQJ2sP1Yyww4Tt363RefnOCqnbeWzNWaXJ7gtl EfELMe8CBnk+h4ZrFk4nGHrPh019WW1CrUszenUxmCsiSCWtXjOHiP0fapxQHmMI aVaHeWmgRjMACKDe91WYt51H6GqAkSVpvnOgaZvyhh5OOoalVha1SJwiutXmn+ED 8yxiunDg+IFX8TnY1nAHmww/7gLlYgkXO/UHYzXreqZIizgo3IbP1GcBjedk1leC 2JwLa7lX3fxtYk0jPs/zgtp++E1CkjPZPSQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1700671662; x=1700758062; bh=6ZxOszHWirk025ISPXCkIzchbB6EQ92Aupf S5/ap6RI=; b=qhuh1QKFKLqvo7D4kvVMRga7rnHvYSgymRE/LoV9zW1C0vJkY37 rvQp06posJPvZp/vTLepk8jOSN6lXdA9Tm9dff2HV0drmGkq/2twF0TOFphNNxV+ R0Zywun0gDbQnXLaQu80bhv20YnTmEcjitRDyN4uZiCVc/oGEkw13DUcGWtuaPRe cRC5LBMSZIQXY5rLDd2qJTA/pb6lCrwOC4sIZouCkZu8QEfrsQwX91iOhHuBedPB pQQu5Pw0+BuCzANMs1OOPF5aexz4o3Q9FEfGcq40Qmp3fsds95g0ea0oXfu002pw FfS+TKstfonFfo1m41Zy8QG0bY/wuyPb+Aw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudehuddgledtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 22 Nov 2023 11:47:41 -0500 (EST) From: Thomas Monjalon To: Gregory Etelson Cc: dev@dpdk.org, mkashani@nvidia.com, stable@dpdk.org, Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Dmitry Kozlyuk Subject: Re: [PATCH] eal/windows: fix memory management macros usage Date: Wed, 22 Nov 2023 17:47:39 +0100 Message-ID: <3228779.AJdgDx1Vlc@thomas> In-Reply-To: <20231114221928.0ad08931@sovereign> References: <20231114170529.176665-1-getelson@nvidia.com> <20231114221928.0ad08931@sovereign> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 14/11/2023 20:19, Dmitry Kozlyuk: > 2023-11-14 19:05 (UTC+0200), Gregory Etelson: > > Windows compilation with cross-mingw on Fedora 39 failed > > because MEM_REPLACE_PLACEHOLDER and MEM_RESERVE_PLACEHOLDER were > > already defined in the compiler environment: > > > > eal_memory.c:77: error: "MEM_REPLACE_PLACEHOLDER" redefined > > /usr/x86_64-w64-mingw32/sys-root/mingw/include/winnt.h:5710: note: > > this is the location of the previous definition > > > > eal_memory.c:78: error: "MEM_RESERVE_PLACEHOLDER" redefined > > /usr/x86_64-w64-mingw32/sys-root/mingw/include/winnt.h:5715: note: > > this is the location of the previous definition > > > > The patch masks MEM_REPLACE_PLACEHOLDER and MEM_RESERVE_PLACEHOLDER > > macros if they were pre-defined by compiler. > > > > The patch also masks MEM_COALESCE_PLACEHOLDERS and > > MEM_PRESERVE_PLACEHOLDER to prevent similar errors. > > > > Fixes: 2a5d547a4a9b ("eal/windows: implement basic memory management") > > > > Cc: stable@dpdk.org > > Signed-off-by: Gregory Etelson > > Acked-by: Dmitry Kozlyuk Acked-by: Thomas Monjalon