From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id BF5AA25B3 for ; Mon, 22 Oct 2018 08:51:45 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4B13C21B4C; Mon, 22 Oct 2018 02:51:44 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 22 Oct 2018 02:51:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=rPKGgbKLGM8+vPCzqHmL66pUKJfeDdGNX5lx+CDdWK0=; b=CPKeKWIjwvR1 O7PB+gI33RcMkvNAl7nBqAeuM91s9hZzc6+OAkx85lXgY3R5dGBV8d7hfq18ufyT hkI5/1jX4r4z0nadPdIoL+49YCXJQMx0yFJyT98JJzdZ2Nh1O3EVp3nQg7yi1wNu ROq8PDNNJBIJGvNztUSx/2P6JhV7/Lg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=rPKGgbKLGM8+vPCzqHmL66pUKJfeDdGNX5lx+CDdW K0=; b=kyUELxL+eeg8B+niiNb1XxnTAJJ3zSyr3Jh1ncmBh+v0irzIshSk9vfss y8UousUUI5isuAJjMPe6yLovczr0o0Ld3puWIUtMF4EbcFaKm+JYlP+Q8DoUJe+b DkBHLuoXG/imxJtIU2Dyy2T+i2RT7PyTzOc9EUijuHNNwT0+lFrzJJkYjGTiY4IC jzKmVv6WUKolthAmoKWgThenbVqXlfX/vq1u50HPUI0RNPwW3m8dB716DPRYybs7 KdQXx3VEPfwBELVt0BgXpTmSP2XhySCNI4cwIpgRLw5lJlCB4o7y1vIzZrR1y5BP agZX3Mxl0Zhfc0sMvrd/MrkuqjcuQ== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2954FE455F; Mon, 22 Oct 2018 02:51:42 -0400 (EDT) From: Thomas Monjalon To: "Joseph, Anoob" Cc: "Trahe, Fiona" , "dev@dpdk.org" , Akhil Goyal , "De Lara Guarch, Pablo" , "Murthy, Nidadavolu" , "Jacob, Jerin" , "Athreya, Narayana Prasad" , "Dwivedi, Ankur" , "Dabilpuram, Nithin" , "Jayaraman, Ragothaman" , "Srinivasan, Srisivasubramanian" , "Tejasree, Kondoj" Date: Mon, 22 Oct 2018 08:51:42 +0200 Message-ID: <3230031.dhaMjhjEo9@xps> In-Reply-To: References: <1528476325-15585-1-git-send-email-anoob.joseph@caviumnetworks.com> <348A99DA5F5B7549AA880327E580B4358965228A@IRSMSX101.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 09/33] crypto/octeontx: adds symmetric capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Oct 2018 06:51:46 -0000 22/10/2018 05:49, Joseph, Anoob: > Hi Fiona, > > I do agree that your solution seems to be a neat way for organizing capabilities. But Akhil & Thomas were against that idea and we had to come up with one array with all capabilities. This would not scale well when we start supporting devices with varying capabilities. > > If your plan is to follow the same approach for asym support, maybe we will also follow suit and submit the required patches. > > @Akhil, Thomas, thoughts? Generally speaking, macros are bad. Why cannot you just write functions? I don't understand your issue.