From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 2C15D5F30 for ; Thu, 18 Oct 2018 16:40:09 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B572E22A8D; Thu, 18 Oct 2018 10:40:08 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 18 Oct 2018 10:40:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=sWre+8JwfrROTNVMrI9AVodibyaou3rEmAV6XUystV0=; b=JJpq6KOSKWLW uIQyn+6z3iJVQL2jly3DSWD7Z38xTnMVnKwkVPgzooZql0t/yu10IX5if+iC+3R1 1G+kzxNWhWhBrr28WHtDt9EQ3texBPWJaFEZ0+KumAVp7qRRnw/XbtgVakFFa39r f5kGrmbjwlvYr1tumZ4Bh488oR1ZW4Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=sWre+8JwfrROTNVMrI9AVodibyaou3rEmAV6XUyst V0=; b=Ks470S5CMmUXeGQjPJz73SmEvkGYLnqYAhUTfmGnvjCg8MfnWiOyYSt0w yRF46PUMhU/XtUiutzcYq36l4hjC2hya6Oh+SPDbWHOQ/9pl1ldJVH23QhIA+XKZ jw5EbOUpT62Vd3a9ePj5uLO7smXW9yIjLT0x+p1UlPKUz5BMpKX412cu4etWYkz3 YXyndkwJT2FlLEUIsqU35k8O8EVC0RkZ3hPcpkPGzJdXjJZyjH8zZFSbPXGhltoj miy/1fnxsALtGZSnyfLr343l/I597IJo72KasaQYcYyqHiqL5In8HF1HLL/o8fU1 xOwbROqUcWE3sCfUjY6IIl0qy4t2w== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id F0AE5E43AC; Thu, 18 Oct 2018 10:40:06 -0400 (EDT) From: Thomas Monjalon To: Akhil Goyal Cc: dev@dpdk.org, "pablo.de.lara.guarch@intel.com" , "radu.nicolau@intel.com" , "jerin.jacob@caviumnetworks.com" , "narayanaprasad.athreya@caviumnetworks.com" , "Shally.Verma@caviumnetworks.com" , "Anoob.Joseph@caviumnetworks.com" , "Vidya.Velumuri@caviumnetworks.com" , Hemant Agrawal Date: Thu, 18 Oct 2018 16:40:11 +0200 Message-ID: <3236120.8JxESPyN3M@xps> In-Reply-To: References: <20181015124858.5562-1-akhil.goyal@nxp.com> <20181016103352.2678-1-akhil.goyal@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 0/3] security: support for pdcp X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2018 14:40:09 -0000 16/10/2018 16:35, Akhil Goyal: > > Akhil Goyal (3): > > security: support pdcp protocol > > crypto/dpaa2_sec: add sample pdcp descriptor apis > > crypto/dpaa2_sec: support pdcp offload > > > > doc/guides/prog_guide/rte_security.rst | 107 +- > > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 257 ++ > > drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 208 +- > > drivers/crypto/dpaa2_sec/hw/desc.h | 2 +- > > drivers/crypto/dpaa2_sec/hw/desc/pdcp.h | 2796 +++++++++++++++++++ > > lib/librte_security/rte_security.c | 4 + > > lib/librte_security/rte_security.h | 92 + > > 7 files changed, 3450 insertions(+), 16 deletions(-) > > create mode 100644 drivers/crypto/dpaa2_sec/hw/desc/pdcp.h > > > Patchset applied to dpdk-next-crypto > > minor modification as suggested by Anoob is done. This patchset won't be part of the pull in master because of 2 issues: - clang error: drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:2759:18: fatal error: implicit conversion from enumeration type 'enum rte_security_pdcp_sn_size' to different enumeration type 'enum pdcp_sn_size' - doxygen error: rte_security.h:225: warning: Found unknown command `\PDCP_SN_SIZE_5' rte_security.h:226: warning: Found unknown command `\PDCP_SN_SIZE_7' rte_security.h:227: warning: Found unknown command `\PDCP_SN_SIZE_12' rte_security.h:228: warning: Found unknown command `\PDCP_SN_SIZE_15' rte_security.h:229: warning: Found unknown command `\PDCP_SN_SIZE_18' I think these doxygen comments can be removed.