From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 0E8D9A0C44;
	Mon, 12 Apr 2021 15:06:36 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 8E73114119D;
	Mon, 12 Apr 2021 15:06:35 +0200 (CEST)
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 5FA5B14119B;
 Mon, 12 Apr 2021 15:06:34 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
 by mailout.nyi.internal (Postfix) with ESMTP id EE0E75C0166;
 Mon, 12 Apr 2021 09:06:33 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute2.internal (MEProxy); Mon, 12 Apr 2021 09:06:33 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=fm3; bh=
 A75vPHEfhIP+5rPhJg0Jcx5nfia0WJ8sNPxBlzyZ3p8=; b=x3GAIQqe84c9GsW4
 CGOe9nj+8QP9fQrlIuv2m11AwyDLd2pxS0+MLtICif2bwh4gWJlTutNxPIlVzvf+
 y14yU3EdFmRIimF5+NS7rnYNGU5cvItum7HDgSe+RJ3w09ahJHYmHle3yIwk/lzR
 /9UK1cz04aXpfk6hMGkqazyQnen3rjH28zvvbOXU+lmbP/BrAO18UZQFXNqIx9eZ
 m2pZDqe0hq9VKNl5sN4OouOk1UO5i8/ywOU7uWCGu/eI028pBde7Ri458notkLSl
 HKyXfYTdRx/HGGOicTTOdzkRU4Jx87IYnPy6gPdn28bBhdvirS/GbpDSGv4pS7V2
 FNlPvA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm2; bh=A75vPHEfhIP+5rPhJg0Jcx5nfia0WJ8sNPxBlzyZ3
 p8=; b=UF4gnPd/nTizDBICyarpaPlpy1qqswcqij4/U8EhGN6l2JYFXZFR8cimY
 dlxSD1pGa8viXBQI2+WYvIFQlt/Z0LimlIs/naw2NlInMf9l/mP8MBfrdPbG14H5
 7ZjrNbRDq9ftViLWSCzf9LaABl3K0ApJDEuTdE30dJF+SbEPh5TPuczkACfSwfPG
 rshM4cj1uLCNeOQYNM1Aw24ar6V2iVTfKzhsvZxJC6mqfjWaDaukfapAz2Jnfufe
 hGeQPOR92rKD1TbpYchPSfIypFrN2zNL7Z4IqYFK6oAl2NxbyxzgnlVc5FGJxuTb
 JLIx6HOLnEa2NWDceYuLLQUJgKS0Q==
X-ME-Sender: <xms:2UV0YGWPOAJv8CHBepIDkT09xt8iVkHijiiKhnt1HHWXiiw2-uN98g>
 <xme:2UV0YCno-9HqHQMOqn9WRmcUHfxR3vHCf0708zFsLvIaznjdOzjXlXBlVwhxB8Sfw
 IKDAWUYGORYCWDb9Q>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudekjedgieduucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
 shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
 ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu
 ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf
 hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl
 ohhnrdhnvght
X-ME-Proxy: <xmx:2UV0YKYHA0YyqvW1NNaVr3teedAO0Rh6WmIpFL1bwaANW-dYJetGaQ>
 <xmx:2UV0YNXRFM7AgajRJa-qVMuyN5IkL_0ZXeStOn75SasdCmfPasfNIA>
 <xmx:2UV0YAl6AtZA3htGzBbPLpHSsU1uztPTmV04s3KjKp6qZp-BPHbZRA>
 <xmx:2UV0YPuqqNRJiAW-bL0IenVvqgYqJnsbneqBf4TU34VbWItenbSoOA>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 60395240054;
 Mon, 12 Apr 2021 09:06:32 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Raslan Darawsheh <rasland@nvidia.com>, Tal Shnaiderman <talshn@nvidia.com>,
 "dev@dpdk.org" <dev@dpdk.org>, Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Matan Azrad <matan@nvidia.com>, Asaf Penso <asafp@nvidia.com>,
 Wisam Monther <wisamm@nvidia.com>, "stable@dpdk.org" <stable@dpdk.org>
Date: Mon, 12 Apr 2021 15:06:31 +0200
Message-ID: <3237657.no5xmyL5GM@thomas>
In-Reply-To: <a3b6adeb-ee92-d141-d149-11bd8d7638fc@intel.com>
References: <20210411122136.2560-1-talshn@nvidia.com>
 <SN6PR12MB2750A29D422DE720B920218CCF709@SN6PR12MB2750.namprd12.prod.outlook.com>
 <a3b6adeb-ee92-d141-d149-11bd8d7638fc@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] common/mlx5: fix missing
 __rte_internal tags in exported functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

12/04/2021 14:59, Ferruh Yigit:
> On 4/12/2021 12:25 PM, Raslan Darawsheh wrote:
> > Hi,
> > 
> > From: Tal Shnaiderman <talshn@nvidia.com>
> >>
> > Removed __ from the commit title to fix wrong headline format issue.
> > 
> >> Several functions introduced in the addition of the Windows support to
> >> mlx5 were missing the __rte_internal tag although being exported.
> >>
> >> Fixes: 1552fb287166 ("common/mlx5: add alloc/dealloc PD on Windows")
> >> Fixes: 1969ee424405 ("common/mlx5: add UMEM reg/dereg functions on
> >> Windows")
> >> Fixes: ba420719823c ("common/mlx5: add reg/dereg MR on Windows")
> >> Cc: stable@dpdk.org
> >>
> >> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> > 
> > Patch applied to next-net-mlx,
> > 
> 
> Can we merge this directly to main repo?
> Since debug build is broken without it.

Which debug option?
It is broken since when?