From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 31D1B42CB2;
Mon, 19 Jun 2023 10:58:54 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id B20BC40DF8;
Mon, 19 Jun 2023 10:58:53 +0200 (CEST)
Received: from NAM12-DM6-obe.outbound.protection.outlook.com
(mail-dm6nam12on2085.outbound.protection.outlook.com [40.107.243.85])
by mails.dpdk.org (Postfix) with ESMTP id CC85040A81;
Mon, 19 Jun 2023 10:58:52 +0200 (CEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=KI0D3hvLj2s8YuunUhbgj9pCenpXRElzsqHKz75vWMHoZ6nvis8bHd+7GGUlD0D4GgimVenA1v7WJzF+jYtujkoEsf8pselkCXVR2sTVO+BejzWgbyto/xjztL/n5GRkWW21svLulQei+gA3Y7rDjr8GGb4oNekNeusnFTWak5qLDMqKiGyzFeUeo6I1eGTXEzWNLD+KMQgmOU4+OE6qEi6PetgWdU3v3Q/KkqU+eL+hm+IYAAcGdJi7hHmXGl4E2B2nfaJZ0NNVqqx//e4y9FN++YrACPeYvaNQ+SOzU7lPDFIsDjD3oc2VI0oV4ARAtJjB4FOomEl8BMMmc2kaLQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=YYaYk7gTg8uc+6efCODFLognC7j1nvgYh5qv7wwEC2c=;
b=h0vn/zdRvdkqzBKqo8ln3Dmtq1JKhIENPGbHtqGKwx0xIoOOOPjjQI1GuzhN4RvoRrf88dmFOnOpGoC0ttiejDGEYdFlRTn8/Jd1/iJZnU9ySof/Ms5oBSZoVF7UHxpgEsZ+E4FlEXycw4rBZt83KJtbjGYpdjUZOvndG2BebrBkbHMXnSRTA1HoRR4zFFqNxu3dYZ9wJQwzisRZ/rSmkFMjrHjAJxOvbWwY3oS/nxlP3W+f6yfnxPgqePWTsMUBlNI1RrWek+cWd9ZnRdpECUn7duVQXKT3pyNAHdLncy6Bo5OoocAv+GWtppQbbBJgTqELoAN8vDlYsCVKQfKJoA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=YYaYk7gTg8uc+6efCODFLognC7j1nvgYh5qv7wwEC2c=;
b=FXNEP7CsvT6iD7fj2paIJCEwJQQFQdcutU7+SmRe9sP5ae5yUXFHCgzOQuwRstGrXgAfIij6WzgSHcx00E9rApwsGx8upJeqOscdT+mUABySmUsVCfqxg+aIR49SRQD1ZGhisCz0vTakIOFaQ7iLsnrTS2zHgPdGfx10wN+micg=
Authentication-Results: dkim=none (message not signed)
header.d=none;dmarc=none action=none header.from=amd.com;
Received: from MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22)
by SJ2PR12MB8739.namprd12.prod.outlook.com (2603:10b6:a03:549::10)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.35; Mon, 19 Jun
2023 08:58:50 +0000
Received: from MN2PR12MB4301.namprd12.prod.outlook.com
([fe80::3b9d:9ac6:f3ce:e106]) by MN2PR12MB4301.namprd12.prod.outlook.com
([fe80::3b9d:9ac6:f3ce:e106%3]) with mapi id 15.20.6500.036; Mon, 19 Jun 2023
08:58:50 +0000
Message-ID: <3237ae77-bd68-cffa-f1f6-537ff871496e@amd.com>
Date: Mon, 19 Jun 2023 09:57:17 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
Thunderbird/102.12.0
Subject: Re: [PATCH v3] net/bonding: fix bond startup failure when NUMA is -1
Content-Language: en-US
To: "humin (Q)" <humin29@huawei.com>, Chaoyong He <chaoyong.he@corigine.com>,
dev@dpdk.org
Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com,
Zerun Fu <zerun.fu@corigine.com>, stable@dpdk.org,
Peng Zhang <peng.zhang@corigine.com>, Long Wu <long.wu@corigine.com>
References: <20230616071558.1278520-1-chaoyong.he@corigine.com>
<20230616072034.1278546-1-chaoyong.he@corigine.com>
<da8b5b45-5562-a904-b521-0695b83c2a05@huawei.com>
From: Ferruh Yigit <ferruh.yigit@amd.com>
In-Reply-To: <da8b5b45-5562-a904-b521-0695b83c2a05@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0262.GBRP123.PROD.OUTLOOK.COM
(2603:10a6:600:194::15) To MN2PR12MB4301.namprd12.prod.outlook.com
(2603:10b6:208:1d4::22)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: MN2PR12MB4301:EE_|SJ2PR12MB8739:EE_
X-MS-Office365-Filtering-Correlation-Id: fdf1f466-7e8b-422a-48a1-08db70a36635
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: LNYVHfS8VfaFMRGvjIFkjjv60ntS+qdI+x1nbOYpQj7IXZmVdpll2tLWdfbGVV170D17s4RNtsDlo7g6ND3uJHE2cfoEy98zC+Yp3N/3Whk0Tay/GVjzYl0PRMEoGDjRSFV8nYn6xv6yBPRSEJo7ZVVMUgWncAnpavR9zrzwmdrDdh3CPR7IpZmoRJUtddNKgdK1jag1w5LJzYKZAyh1xrKDv8FPNXu9I3mCqBZlIO6qL9sJZs63ury5DNRHndKtsCYgNVxp6wt9KfZySXBtnCTd9uaQriXJm8wiHKyHZz77GOEY9Z1Zi4AALWIkw4FfEugIZYp4XkSny/HDT8UI0XvZH80Lkfu5ZEXwjrsqcI3ryx0+3y12g5iM/8tAf965p6AvgQxOu7nXEJ7orQpBfqbLJ39bC/Fdcddd5NxNjxhs1nz2RKdl5FO+S0GZf9wGTW8nZw+DetkK9K3JucpLzr/bWWPbgUQzReedAN14xbd5HKxQvGx7g5K3QqjAQcE1xi0h/lv3HoWL51ni1+ZFB0Bgk8UI9b80To0TXYk3f1vjFsOaNlPRoZkd11wQenNRvuvg9/FD9gVXE83E0CoWCQahWU+yZ2nPWcu6ZVpg10sSPYqraBsveR3HmLc8AE76D/TDIPAGTGK0dmOmC7CU2A==
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:MN2PR12MB4301.namprd12.prod.outlook.com; PTR:; CAT:NONE;
SFS:(13230028)(4636009)(136003)(376002)(366004)(39860400002)(396003)(346002)(451199021)(38100700002)(36756003)(31696002)(86362001)(6666004)(6486002)(53546011)(26005)(6512007)(6506007)(186003)(8936002)(8676002)(44832011)(5660300002)(478600001)(110136005)(31686004)(54906003)(316002)(41300700001)(66946007)(4326008)(66556008)(66476007)(2906002)(83380400001)(2616005)(43740500002)(45980500001);
DIR:OUT; SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MjI0dVcwVC9IU291U3pyN0RiMWlkcmRiZXhIZnhlRkdidnl5TG5LUWlIM1R5?=
=?utf-8?B?VVliZGhqb3ZHZzYrQjFPMVRYaDVOZHVNc3QrWVg0bUNzcmxMMGsycUpmWUlr?=
=?utf-8?B?dnB6R1V3M1dmdmZQMkxDMGFHMTZwaWlPMmRUdFUrYU5OV0czL3VaWVpjWXM5?=
=?utf-8?B?TnFpSkhJVjBZSGJTZ0w3TU5kRUg1T05HTVg2ZUcvUmZYejJnQmhPQWxaYVV6?=
=?utf-8?B?bS9MRmRQazlibzZBUWhodkE4L21tSmx4cC9VVWNxV0xiVjFmZkozUjA1Ullq?=
=?utf-8?B?ZGwweTlXdngvUEV4M0xmVEpBa2JlSFl4YnM0UGZyMDU5WlRpaUwvekZwU1B5?=
=?utf-8?B?YzRibjlxQ0h0K3ZzWnAxU3BnM3JGSnZuYnNxS29wWHFoLzJVS21sanFWZmNR?=
=?utf-8?B?VHJCZ3RhdG1SazByeTFGY2ltblJ6TnJ6Sm8wS0x4V0JUZ2ZjbFQ3WWRqTnF2?=
=?utf-8?B?YXhKQWIyV095KzRlNVF0RWQyNGZ3UTJ3dVVUbGRjOGFJeko5OGJVdGRDK1Qy?=
=?utf-8?B?ZmZjZFdsN0FmVnFEZGN2dTFmY1VrZlVZYnVZaVhIZ3ByQm9jYjZLVjc5eStz?=
=?utf-8?B?TThjQmFtNWI1eEFDeHF4WEVWYytnOW5KNzd1OUxYT3lLWko0V0tjSzJwaDE1?=
=?utf-8?B?L2xmb2FQRTAwUUJPRTBhYXg1ZUhOTEc5SEh0ZmQwRVNGZm1JMHdrM1gvSlM0?=
=?utf-8?B?VG0rbDA2UllSZjZqWHdNNnR6a0NQMHlpZzB3NFUxVjRoTGRDN2VldlkweGt1?=
=?utf-8?B?WjVacjc1Z1pJbVFsV1NTRnZPcXVPVUV2SmJ4MWRIdzR2ZWdQSXY5RFBOTlo0?=
=?utf-8?B?VTV2TkQ5NzN3aEczREJ0bFdwTzhmV2ZIVEllN0tmQ2VmR1hQbGxKbStLbGpK?=
=?utf-8?B?MzhMcERseWMveURnQzJZL0VRdDhJcmJock9aSEVWZzFxU2F6UnlLUjdhcmpl?=
=?utf-8?B?U3BBNzhUSVFQUzhrVFMyNkM5cWxlVkxQYjY3SCswQ3NmZzZON0Y1bFkvZkFO?=
=?utf-8?B?T2o5SGp0bFpLVnhraG1IOTJNYjdTdXF3Q0x3bENzb2J4SldrNzB5ZTFhb2Ux?=
=?utf-8?B?ejhncGVneHVDeUhIV0hyMVRScmRzWFdOSWtuSWt1eGRKS1IyeWdMTlhmVDRB?=
=?utf-8?B?d3ZyTnZodk82aEs3anl2dE9tN29zMmk5N1ZCWjBuOWdEelBUdzJPcW82WXlU?=
=?utf-8?B?cC8xaFhrUEdVMXczV1ZJOHRWc0hCUndudnlqZnpsZ1VBeXM2eHpFVWlZNGE3?=
=?utf-8?B?Zk05RlZTUUQ2S1d6bVNzQ3paTGRqVmJvN0VhRlFwekl6Vko4Ym5lQ3VtRVli?=
=?utf-8?B?MHJ6dHhTa2ZnWTBhSU5LOXVrcmdwZ2M0cmFubTFwbGFYMmxIMmJCczhwcWUy?=
=?utf-8?B?MGxKa0hUcmhTb05GeEEzRFNiRm5uaFI4MEtKMnVkRGIrYUJWcXFlWU1rYnBG?=
=?utf-8?B?TVlxTWcxdjZ4MFU4dUlDUG9oYU9VTlFWZDM4cGVDdG9RQzFkSUdFVjV6SUM0?=
=?utf-8?B?V1FJRDdZNUdUNjg1Z2tvQTdMQ2t3VGJpRUFkQTQ0RnV1L2M0azhiYWR0bDdW?=
=?utf-8?B?RituSlJNODJ5eWp4M05NQXM4UE8vdktERGRsc0IwdGlNWXFYQXFwT0pGWkpv?=
=?utf-8?B?cjdkRTVpZVo4Y1FkcU5ETE1WbFV5M2RCdk5NYXV0RFpWZ0FUam96enV3cm1U?=
=?utf-8?B?QjBVNVNUVzYxUW15T2FSZXNzNG1MZk1ETmlXY2l1dEUxakJ4Uk9menpBMUpo?=
=?utf-8?B?TVlOS3Z0WGhKMk1NMWpYaUFNSm1yZGdhM3ZmQ3l5SUFxU0lXUDJUalh4UnNF?=
=?utf-8?B?RzN5NFh3eVBobGltcG5xd1ZRektwcDlpeFFNcFM0S05MaHdlQlBlSk02SEkz?=
=?utf-8?B?SzVvR3VCUGpSamhXcFJyMkRKWDZXUjJZREQ2MXBPbFJ3YmRsRHNyQzNOay9W?=
=?utf-8?B?enhaUnpwSHJHcU90NERNQkJqc2ZGa3IzYWwyMm1XWE5CQjZ0Z0c5UTBQT0RB?=
=?utf-8?B?SEpVc0dLeFdKRlFQVkswRXA5K0M0VWxCVWRNdUZ2SnlXUTJieDlaeVJGUElM?=
=?utf-8?B?WDJTS0hsZUQ1dHNZbk9ZaUNNTTcyemNrVmdlZUE3R3NhUmREZlNBUjdoQnov?=
=?utf-8?Q?OhyS4F1k1KvsYn24TF3DdisAv?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fdf1f466-7e8b-422a-48a1-08db70a36635
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4301.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2023 08:58:50.3075 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: O9+u2vRdafSn/+zKY6Ee0Ril3mm9uoZGpXcyY0cD4Emmn6tTf6Hh2vzx2lp2nmTM
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8739
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On 6/16/2023 1:00 PM, humin (Q) wrote:
> Hi,
>
> 在 2023/6/16 15:20, Chaoyong He 写道:
>> From: Zerun Fu <zerun.fu@corigine.com>
>>
>> After the mainline Linux kernel commit
>> "fe205d984e7730f4d21f6f8ebc60f0698404ac31" (ACPI: Remove side effect
>> of partly creating a node in acpi_map_pxm_to_online_node) by
>> Jonathan Cameron. When the system does not support NUMA architecture,
>> the "socket_id" is expected to be -1. The valid "socket_id" in
>> BOND PMD is greater than or equal to zero. So it will cause an error
>> when DPDK checks the validity of the "socket_id" when starting the
>> bond. This commit can fix this bug.
>>
>> Fixes: f294e04851fd ("net/bonding: fix socket ID check")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Zerun Fu <zerun.fu@corigine.com>
>> Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
>> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
>> Reviewed-by: Long Wu <long.wu@corigine.com>
>
> No need add your colleagues unless they "reviwed-by" through email-list.
>
Hi Connor,
This is done time to time, if code is already internally reviewed, send
review/ack tags within the patch, to reduce noise in the mail list.
It looks like there were additional reviewers of code, which is good,
but it requires maintainers' (you and Chas) ack to get accepted.