From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 515F2A0C52; Wed, 24 Nov 2021 18:32:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 168AB40040; Wed, 24 Nov 2021 18:32:47 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id D88234003C for ; Wed, 24 Nov 2021 18:32:45 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 981BD3200F7C; Wed, 24 Nov 2021 12:32:44 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 24 Nov 2021 12:32:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= KCJ6wimt617QNpu52Z4mkV+wGyhbNYHfNhMiVmud3lg=; b=diKa3i0PyEcfie7A ORprwCaeUEioWb7tSDn0GI2PPfvEPBfkc9raTm5YS6lz6YqK6S8fPn8h7ri40jEV e7+162dn41RWquH7R1qrabu/1WQgQl6GA07QXB5tPdZxn9I4ZZl4l2EsWxbYul8v H5nRuTJcf15ksWwBzXMQsEA88oFW7FRHl0QOsQ/oQfhTbcH0+Fc4OvUWapJylXco 4dMCNjebapxmCoH/yi+E+sEvEt2tDz3c5TlWwzUfpYKU8px+EXzJclaPhdqh5ZSu KvE9iLs+VpvZkNNgZ+ja4tQ6EUHaVkIugQ9yBgfv0H9o7b6StCQI6i2Oty4BHM72 uB+mlA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=KCJ6wimt617QNpu52Z4mkV+wGyhbNYHfNhMiVmud3 lg=; b=a1WV7qy3U+kMwCmZSQDlaZR0rYTk2XF8wuO6JyzN44Fqb8jxkgXI2dLjC c0kEG7KfYvQE2Rr9O2EvJCNVZHTwKkPP9Awa3uVeqkDsF/jQBawL93BXZ239wHQX IEIpQz2wo8XQOflccHzJQVhxNuIPk2IaMcq4Ky9dDkTI2z1WrMmKd/MzedBpsrcb Wd1tbORQeE8BSDyZPuV71Dvo8qL4Y7dXIvVAX8p1u/XJUrPYVWR8NZ5GuYM0G+K2 HHRWO3D8L9jxVnfCwYVBwfuKjdEDNg6A5EDeLlMfG0FdSvQZUcOpi2iDVF4egNiL tZum49fMUfYklTjGSTriNPovMhlyQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrgeekgddutdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 24 Nov 2021 12:32:43 -0500 (EST) From: Thomas Monjalon To: Ori Kam , Slava Ovsiienko Cc: "dev@dpdk.org" , "ferruh.yigit@intel.com" Subject: Re: [PATCH v3] ethdev: deprecate header fields and metadata flow actions Date: Wed, 24 Nov 2021 18:32:41 +0100 Message-ID: <3238712.SzvLOqgLnN@thomas> In-Reply-To: References: <20211123075940.5521-1-viacheslavo@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 24/11/2021 17:37, Slava Ovsiienko: > From: Ori Kam > > From: Viacheslav Ovsiienko > > > Action: ``OF_SET_MPLS_TTL`` > > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > > +This action is deprecated. Consider `Action: MODIFY_FIELD`_. > > > > > > > Since no PMD support this action why set reference to MODIFY_FIELD_? > > Same for all unsupported actions. > > There are some references to this action in PMDs (for example bnxt), > but the ENOTSUP returned. I.e., action is in source code, but actually > not supported. Hence (due to this and in general), we can't just occasionally > remove existing actions, we should deprecate these ones first. > Other point - if someone will decide to implement support for this > action in his/her PMD - the deprecation notice will point out the right way - > "consider MODIFY_FIELD." > > > > > > Implements ``OFPAT_SET_MPLS_TTL`` ("MPLS TTL") as defined by the > > > `OpenFlow Switch Specification`_. > > > @@ -2254,6 +2255,7 @@ Switch Specification`_. > > > > [..snip..] > > > > If no PMD support this why do we want to add it to the modify_field? > > Same for all of the unsupported actions. > As I said above - we just propose to consider MODIFY_FIELD actions > if someone has intention to implement deprecated OFPAT_SET_MPLS_TTL. It was an API, we must guide the API reader in the right direction. BTW, it can be implemented in a driver which is not yet upstream.