Re: [dpdk-dev] [PATCH v2] bus/pci: use device driver name instead of handler type

[Thomas Monjalon <thomas@monjalon.net>]

26/10/2018 16:03, Burakov, Anatoly:
> On 25-Oct-18 11:49 AM, Alejandro Lucero wrote:
> > Invoking the right pci read/write functions is based on interrupt
> > handler type. However, this is not configured for secondary processes
> > precluding to use those functions.
> > 
> > This patch fixes the issue using the driver name the device is bound
> > to instead.
> > 
> > Fixes: 632b2d1deeed ("eal: provide functions to access PCI config")
> > 
> > v2:
> >   - Use #ifdef for VFIO functions
> > 
> > Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
> > ---
> >   drivers/bus/pci/linux/pci.c | 32 ++++++++++++++------------------
> >   1 file changed, 14 insertions(+), 18 deletions(-)
> > 
> > diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c
> > index 5cf78d7..59a2086 100644
> > --- a/drivers/bus/pci/linux/pci.c
> > +++ b/drivers/bus/pci/linux/pci.c
> > @@ -673,23 +673,21 @@ enum rte_iova_mode
> >   int rte_pci_read_config(const struct rte_pci_device *device,
> >   		void *buf, size_t len, off_t offset)
> >   {
> > +	char devname[RTE_DEV_NAME_MAX_LEN] = {0};
> 
> Probably "" instead of {0} is better. Same in other case.
> 
> Otherwise, LGTM
> 
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

Applied with above change, thanks.

Title fixed: bus/pci: compare kernel driver instead of interrupt handler