From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id D35068E85 for ; Fri, 4 Dec 2015 16:28:25 +0100 (CET) Received: by wmww144 with SMTP id w144so69351130wmw.0 for ; Fri, 04 Dec 2015 07:28:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=Amq8IvLZ+FTgvpQ9rtD5Amisghuf19obLkIqUyfuRnY=; b=rgouf/cufsgNcED2xgOIQ89mv/g57skpyXJ3v/NGZzt1ExxGr5UXMUy7P+/3VBJOjR LMUxmTNnimug6oodT9YgO+vfKmxowwUo8oXE/me3AxPS5QQO8VBdQxfIU8B2FcZ/xk8i 6NKkglsVkmLQolm1Ll+VEfZc+xWZGmdJAUkHo5S3Lc/c7wPfKqbq/Ht+RaYya9D7t7DL JYbWLK7/BuM3OB8t/D/MTo5sh0DAMqXR1VChvkH+qlPid0GLVZTOyrnHeJ/4gCsWuOjt RGCGqlQmbhBqxiN2Tm3I2FFiVWk5F63EuxhywewVNsgi/xlsFyYkUm98UktYhIWZE1ji ibYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Amq8IvLZ+FTgvpQ9rtD5Amisghuf19obLkIqUyfuRnY=; b=Wumc9K0fbBkgOzFujgYEpovf1RhB62Pnqgo5F4kTHdxMeOteOZGy7aCf4K6bHlfa5l 7WpMldaCtkg88P/1sNd4KIguWddRW8wvrLdrccVcxWJALg9c7N1r7VkuX5xjt8dGhdAF HEAHV+kVQiYz3gSCqxx89R79MypwcFqc3EZ+AfovrGvW/eqIPolx6I5RCt95NxfBIcub a8ZXdFTzidmt8vrWvQyT6JBkZn5lM6euO6HINIbGHPsrtbLAiXOXCgOxCE01oQFnbNYY vwbrNet8P+HITeQ+7x0KZZ9PKrn2n1hS0gzgTARd7L9RyIGCpdOpuuOedHIpl+tNeE6e ExAA== X-Gm-Message-State: ALoCoQngB7pPIwd/mu7J/+HujrtTSvyxSqHLveTNQrHTFPLDSH2uCmmvi7O7J76kS0vYc2AdR1TcES0w/pKDx8fSGlp0SqtRKQ== X-Received: by 10.28.18.9 with SMTP id 9mr5559861wms.96.1449242905566; Fri, 04 Dec 2015 07:28:25 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id w6sm12596407wjy.31.2015.12.04.07.28.24 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 04 Dec 2015 07:28:24 -0800 (PST) From: Thomas Monjalon To: "Iremonger, Bernard" Date: Fri, 04 Dec 2015 16:27:15 +0100 Message-ID: <3243475.ZBIR4zOS0o@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <8CEF83825BEC744B83065625E567D7C219F8D635@IRSMSX108.ger.corp.intel.com> References: <1449194904-9626-1-git-send-email-stephen@networkplumber.org> <20151204032953.GC29571@yliu-dev.sh.intel.com> <8CEF83825BEC744B83065625E567D7C219F8D635@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] virtio: fix link state regression X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Dec 2015 15:28:26 -0000 2015-12-04 15:25, Iremonger, Bernard: > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > > On Thu, Dec 03, 2015 at 06:08:24PM -0800, Stephen Hemminger wrote: > > > Support for link state interrupt was broken on virtio by > > > > > > commit bda66c418c85 ("ethdev: add device fields from PCI layer") > > > > > > This is caused because the actual value of drv_flags is not set until > > > after the resource_init has figured out whether it is using UIO or > > > direct I/O instructions. > > > > > > Signed-off-by: Stephen Hemminger > > > --- > > > There maybe other drivers with the same problem. It would have been > > > better to move the structure elements (and break ABI) rather than > > > assume it safe to copy them. Better to fail compiling. > > > > I see no patch content. > > > > --yliu > > I have submitted a patch for this issue. > > http://dpdk.org/dev/patchwork/patch/9345/ > > I have checked the other drivers, I found an issue with the bonding PMD. > I have submitted a patch for this. > > http://dpdk.org/dev/patchwork/patch/9342/ > > The remaining drivers look fine to me. Thank you Bernard for the quick response.