* [dpdk-dev] [PATCH] virtio: fix link state regression
@ 2015-12-04 2:08 Stephen Hemminger
2015-12-04 3:29 ` Yuanhan Liu
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Hemminger @ 2015-12-04 2:08 UTC (permalink / raw)
To: huawei.xie, yuanhan.liu, bernard.iremonger; +Cc: dev
Support for link state interrupt was broken on virtio by
commit bda66c418c85 ("ethdev: add device fields from PCI layer")
This is caused because the actual value of drv_flags is not set
until after the resource_init has figured out whether it is using
UIO or direct I/O instructions.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
There maybe other drivers with the same problem. It would have
been better to move the structure elements (and break ABI) rather
than assume it safe to copy them. Better to fail compiling.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] virtio: fix link state regression
2015-12-04 2:08 [dpdk-dev] [PATCH] virtio: fix link state regression Stephen Hemminger
@ 2015-12-04 3:29 ` Yuanhan Liu
2015-12-04 15:25 ` Iremonger, Bernard
0 siblings, 1 reply; 4+ messages in thread
From: Yuanhan Liu @ 2015-12-04 3:29 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev
On Thu, Dec 03, 2015 at 06:08:24PM -0800, Stephen Hemminger wrote:
> Support for link state interrupt was broken on virtio by
>
> commit bda66c418c85 ("ethdev: add device fields from PCI layer")
>
> This is caused because the actual value of drv_flags is not set
> until after the resource_init has figured out whether it is using
> UIO or direct I/O instructions.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> There maybe other drivers with the same problem. It would have
> been better to move the structure elements (and break ABI) rather
> than assume it safe to copy them. Better to fail compiling.
I see no patch content.
--yliu
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] virtio: fix link state regression
2015-12-04 3:29 ` Yuanhan Liu
@ 2015-12-04 15:25 ` Iremonger, Bernard
2015-12-04 15:27 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: Iremonger, Bernard @ 2015-12-04 15:25 UTC (permalink / raw)
To: Yuanhan Liu, Stephen Hemminger; +Cc: dev
Hi Stephen, Yuanhan,
> -----Original Message-----
> From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]
> Sent: Friday, December 4, 2015 3:30 AM
> To: Stephen Hemminger <stephen@networkplumber.org>
> Cc: Xie, Huawei <huawei.xie@intel.com>; Iremonger, Bernard
> <bernard.iremonger@intel.com>; dev@dpdk.org
> Subject: Re: [PATCH] virtio: fix link state regression
>
> On Thu, Dec 03, 2015 at 06:08:24PM -0800, Stephen Hemminger wrote:
> > Support for link state interrupt was broken on virtio by
> >
> > commit bda66c418c85 ("ethdev: add device fields from PCI layer")
> >
> > This is caused because the actual value of drv_flags is not set until
> > after the resource_init has figured out whether it is using UIO or
> > direct I/O instructions.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> > There maybe other drivers with the same problem. It would have been
> > better to move the structure elements (and break ABI) rather than
> > assume it safe to copy them. Better to fail compiling.
>
> I see no patch content.
>
> --yliu
I have submitted a patch for this issue.
http://dpdk.org/dev/patchwork/patch/9345/
I have checked the other drivers, I found an issue with the bonding PMD.
I have submitted a patch for this.
http://dpdk.org/dev/patchwork/patch/9342/
The remaining drivers look fine to me.
Regards,
Bernard.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] virtio: fix link state regression
2015-12-04 15:25 ` Iremonger, Bernard
@ 2015-12-04 15:27 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2015-12-04 15:27 UTC (permalink / raw)
To: Iremonger, Bernard; +Cc: dev
2015-12-04 15:25, Iremonger, Bernard:
> From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]
> > On Thu, Dec 03, 2015 at 06:08:24PM -0800, Stephen Hemminger wrote:
> > > Support for link state interrupt was broken on virtio by
> > >
> > > commit bda66c418c85 ("ethdev: add device fields from PCI layer")
> > >
> > > This is caused because the actual value of drv_flags is not set until
> > > after the resource_init has figured out whether it is using UIO or
> > > direct I/O instructions.
> > >
> > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > > ---
> > > There maybe other drivers with the same problem. It would have been
> > > better to move the structure elements (and break ABI) rather than
> > > assume it safe to copy them. Better to fail compiling.
> >
> > I see no patch content.
> >
> > --yliu
>
> I have submitted a patch for this issue.
>
> http://dpdk.org/dev/patchwork/patch/9345/
>
> I have checked the other drivers, I found an issue with the bonding PMD.
> I have submitted a patch for this.
>
> http://dpdk.org/dev/patchwork/patch/9342/
>
> The remaining drivers look fine to me.
Thank you Bernard for the quick response.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-12-04 15:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-04 2:08 [dpdk-dev] [PATCH] virtio: fix link state regression Stephen Hemminger
2015-12-04 3:29 ` Yuanhan Liu
2015-12-04 15:25 ` Iremonger, Bernard
2015-12-04 15:27 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).