From: Thomas Monjalon <thomas@monjalon.net> To: Ferruh Yigit <ferruh.yigit@intel.com> Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>, david.marchand@redhat.com Subject: Re: [dpdk-dev] [PATCH] devtools: fix 32-bits build Date: Mon, 09 Nov 2020 14:19:29 +0100 Message-ID: <3243789.yRO6XYygMt@thomas> (raw) In-Reply-To: <20201109130035.3948462-1-ferruh.yigit@intel.com> 09/11/2020 14:00, Ferruh Yigit: > 32 bit still uses the pkgconfig file for 64-bits libraries, from the > build log: > > " > Using DPDK_TARGET i386-pc-linux-gnu > meson -Dexamples=l3fwd --buildtype=debugoptimized --werror > -Dc_args=-m32 -Dc_link_args=-m32 > /tmp/dpdk_maintain/self/dpdk/devtools/.. ./build-32b > ... > Using 'PKG_CONFIG_PATH' from environment with value: > '/usr/local/lib64/pkgconfig/ > " > > This causes build error when linking with the found libraries. > > Reproduced with 'librte_bpf' which only has 64 bit installed but still > enables building 'af_xdp' and link fails. I think it is a problem in your configuration. PKG_CONFIG_PATH is not empty before starting the script, right? > To fix updating 'PKG_CONFIG_PATH' and preventing 'load_env' overwrite > it. [...] > 'build-32b' check inside the 'load_env' looks ugly but not sure how to > be sure 'PKG_CONFIG_PATH' set correct. [...] > - export PKG_CONFIG_PATH=$default_pkgpath > + if [ "$targetdir" != "build-32b" ] ; then > + export PKG_CONFIG_PATH=$default_pkgpath > + fi You can reset PKG_CONFIG_PATH in your config file. Something like this: if echo $DPDK_TARGET | grep -q '^i[3-6]86' ; then export PKG_CONFIG_PATH=my32bitlibs/pkgconfig fi We can also discuss why inheriting some default values on script start instead of just resetting them.
next prev parent reply other threads:[~2020-11-09 13:19 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-09 13:00 Ferruh Yigit 2020-11-09 13:19 ` Thomas Monjalon [this message] 2020-11-09 13:24 ` Ferruh Yigit 2020-11-09 13:35 ` Bruce Richardson 2020-11-09 13:51 ` Thomas Monjalon 2020-11-09 14:55 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit 2020-11-09 15:28 ` Thomas Monjalon 2020-11-09 15:44 ` Bruce Richardson 2020-11-09 16:14 ` Thomas Monjalon 2020-11-09 16:19 ` Bruce Richardson 2020-11-09 16:48 ` Ferruh Yigit 2020-11-09 17:01 ` Thomas Monjalon 2020-11-09 17:15 ` Ferruh Yigit 2020-11-09 17:20 ` Thomas Monjalon 2020-11-09 17:44 ` Thomas Monjalon 2020-11-09 21:02 ` Thomas Monjalon 2020-11-11 12:34 ` Ferruh Yigit
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3243789.yRO6XYygMt@thomas \ --to=thomas@monjalon.net \ --cc=bruce.richardson@intel.com \ --cc=david.marchand@redhat.com \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git