From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Balazs Nemeth <balazs.nemeth@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ixgbe: Add missing rx_mbuf_alloc_failed statistics for vector PMD
Date: Fri, 28 Nov 2014 16:24:06 +0100 [thread overview]
Message-ID: <3243944.24MUMOEcxq@xps13> (raw)
In-Reply-To: <20141128131831.GB10024@bricha3-MOBL3>
> > The statistics that is reported through the rx_nombuf fields in struct
> > rte_eth_stats was not set when the vector PMD was used. The statistics
> > should report the number of mbufs that could _not_ be allocated during
> > rearm of the RX queue. The non-vector PMD reports it correctly. The
> > use of either vector PMD or non-vector PMD depends on runtime
> > configuration. Hence it is possible that a change in configuration
> > would disable this statistics. To prevent this from happening, the
> > statistics should be reported by both implementations.
> >
> > Signed-off-by: Balazs Nemeth <balazs.nemeth@intel.com>
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied
Thanks
--
Thomas
prev parent reply other threads:[~2014-11-28 15:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-28 9:21 Balazs Nemeth
2014-11-28 13:18 ` Bruce Richardson
2014-11-28 15:24 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3243944.24MUMOEcxq@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=balazs.nemeth@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).