From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f48.google.com (mail-wg0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id EF4EC1518 for ; Fri, 28 Nov 2014 16:24:29 +0100 (CET) Received: by mail-wg0-f48.google.com with SMTP id y19so9078302wgg.35 for ; Fri, 28 Nov 2014 07:24:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=2PZKlTozxNdxcvWUm1Bq8kMNO90pWNPrrw7IhBpbcy8=; b=LsQEXRtdAIfcL1j0z+TTSocpTbBDzuP546+PcG/PZtbC7xIIQC7AYydM5RlqprfP36 D3GkjSCfPxh9SkxmUacZ3w1XexqzPpXgL/u3oIX9FNOuHQ0NbZOFv4JY2rwUKYuDMGuJ ezBKKw8GSkqfxhiwMod0XH2e/aF5cHiIVKZFHzpvNv3VXkgGfuxJgpRlOqFJ9lt28Mzr wZO5jRzr28clso+RYihVyZMRRpUNMfNebHkMAClAIpLEizJJxP30Umj3k1wKOY4nreKl Xoq8cNzok54nIuhn52mMnUHca/yLLNKWXPIm3zlufcnzVOx4T6Z7RX+P0PieN9CL2pSs v01A== X-Gm-Message-State: ALoCoQmUZ4xWgT9j9jiPKzJ08l2aSkdmBxbxqGG16WoA6yq6Er0EKpYP00kM44PVhOLzWLA91ve/ X-Received: by 10.180.198.52 with SMTP id iz20mr34933825wic.60.1417188269850; Fri, 28 Nov 2014 07:24:29 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id u5sm16313791wiz.9.2014.11.28.07.24.28 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Nov 2014 07:24:29 -0800 (PST) From: Thomas Monjalon To: Balazs Nemeth Date: Fri, 28 Nov 2014 16:24:06 +0100 Message-ID: <3243944.24MUMOEcxq@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <20141128131831.GB10024@bricha3-MOBL3> References: <1417166505-486-1-git-send-email-balazs.nemeth@intel.com> <20141128131831.GB10024@bricha3-MOBL3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] ixgbe: Add missing rx_mbuf_alloc_failed statistics for vector PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Nov 2014 15:24:30 -0000 > > The statistics that is reported through the rx_nombuf fields in struct > > rte_eth_stats was not set when the vector PMD was used. The statistics > > should report the number of mbufs that could _not_ be allocated during > > rearm of the RX queue. The non-vector PMD reports it correctly. The > > use of either vector PMD or non-vector PMD depends on runtime > > configuration. Hence it is possible that a change in configuration > > would disable this statistics. To prevent this from happening, the > > statistics should be reported by both implementations. > > > > Signed-off-by: Balazs Nemeth > > Acked-by: Bruce Richardson Applied Thanks -- Thomas