From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 8EFD71BAC0 for <dev@dpdk.org>; Thu, 26 Oct 2017 16:00:46 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 10BC120D2F; Thu, 26 Oct 2017 10:00:46 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Thu, 26 Oct 2017 10:00:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=cWu2HDR/4gMvYNwpi/kBsgQZMq mwupD242P+1aKRDMs=; b=QJ0BA/YPBuav2hcSCEwny3sY4PqHdW8hEIVWAa2B5m gpKGn+zBfwc4/UOemo/zLK9805Opd6OYU7AxrnSZpLl0zSx7QDrLXDoXFT6qTuGo imRY0WA83m3fbVUo/B2pWTeWgrdiADF8jQTp1u8tIoCN6jJswk+f7+uHa2Y0pY1o o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=cWu2HD R/4gMvYNwpi/kBsgQZMqmwupD242P+1aKRDMs=; b=pYMGcmT1IVnjYlDlo+p2e5 VtGttCiDHxEyAMhLZpeBB7aZjPZpC2gpxdGPtvLbwmbLzCjLV6ivIbbCHxIstmmj VWI0v7LJwQ+u9qJEv8+cTOPfLvCvE5rw2r0VcbaJnVEDo+2PO8Ze8jflj5UKXrSF kTrUThomcEhbLTSotLqF+m6ZmiqfAMAh3cvT6paYkrNScEonPbJmYgS5a9eWW8YP mdMjzGmMR8Ozd4pmhfzM6Mr80Bi+WGWMF8zlXlXJ+izfeVYMNKJfJ+oyT+7O47Vp cSF+Tjfi8nLilxOFKexWdJz65u+m/AlqG3+OLuki7GnQb/ObVgjrsY7jujPPKfnQ == X-ME-Sender: <xms:jerxWbAUUJ20w-2iT3xpEhe6fPvLhBEY470jiKwkP4ekQn4ZkFK5JQ> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9559124C96; Thu, 26 Oct 2017 10:00:45 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Akhil Goyal <akhil.goyal@nxp.com> Cc: Radu Nicolau <radu.nicolau@intel.com>, David Marchand <david.marchand@6wind.com>, dev@dpdk.org, Declan Doherty <declan.doherty@intel.com>, Pablo de Lara <pablo.de.lara.guarch@intel.com>, Hemant Agrawal <hemant.agrawal@nxp.com>, borisp@mellanox.com, aviadye@mellanox.com, sandeep.malik@nxp.com, Jerin Jacob <jerin.jacob@caviumnetworks.com>, "Mcnamara, John" <john.mcnamara@intel.com>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, shahafs@mellanox.com, Olivier Matz <olivier.matz@6wind.com> Date: Thu, 26 Oct 2017 16:00:44 +0200 Message-ID: <3244622.aFqJiogYnx@xps> In-Reply-To: <2b57aec6-fc52-5d78-37cc-3eb3b19ac90c@nxp.com> References: <1509013365-13819-1-git-send-email-radu.nicolau@intel.com> <1548422.ftI5jb3vlP@xps> <2b57aec6-fc52-5d78-37cc-3eb3b19ac90c@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/3] net/ixgbe: fix build issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 26 Oct 2017 14:00:46 -0000 26/10/2017 15:16, Akhil Goyal: > On 10/26/2017 6:37 PM, Thomas Monjalon wrote: > > 26/10/2017 14:59, Akhil Goyal: > >> Hi Thomas, > >> > >> On 10/26/2017 6:03 PM, Thomas Monjalon wrote: > >>> 26/10/2017 14:28, Radu Nicolau: > >>>> > >>>> On 10/26/2017 12:39 PM, Thomas Monjalon wrote: > >>>>> 26/10/2017 13:27, David Marchand: > >>>>>> On Thu, Oct 26, 2017 at 1:01 PM, Radu Nicolau <radu.nicolau@intel.com> wrote: > >>>>>>> On 10/26/2017 11:36 AM, David Marchand wrote: > >>>>>>>> On Thu, Oct 26, 2017 at 12:22 PM, Radu Nicolau <radu.nicolau@intel.com> > >>>>>>>> wrote: > >>>>>>>>> --- a/drivers/net/ixgbe/Makefile > >>>>>>>>> +++ b/drivers/net/ixgbe/Makefile > >>>>>>>>> +ifneq ($(MAKECMDGOALS),clean) > >>>>>>>>> +ifneq ($(CONFIG_RTE_LIBRTE_SECURITY),y) > >>>>>>>>> +$(error "RTE_LIBRTE_SECURITY is required to build RTE_LIBRTE_IXGBE_PMD") > >>>>>>>>> +endif > >>>>>>>>> +endif > >>>>>>>> This is a no go for me unless you explain how it is impossible to > >>>>>>>> disable it in the code. > >>>>>>>> > >>>>>>>> > >>>>>>> It can be disabled in the code, but as far as I know there is a general push > >>>>>>> back against having conditionally compiled code. I originally had the > >>>>>>> security sections in ixgbe PMD isolated, but the feedback was to have them > >>>>>>> always on. > >>>>>> In my mind, this was to stop having features enabled per pmd (and stop > >>>>>> the nightmare with 10 options in a pmd). > >>>>>> Having features globally enabled for all or nothing is still > >>>>>> acceptable, is it not ? > >>>>> Yes there is a config option for rte_security, > >>>>> and it is acceptable. > >>>>> The code depending on it must be ifdef'ed. > >>>> > >>>> Given that both ixgbe and dpaa2_sec are now security enabled PMDs, I > >>>> would go with Konstantin's proposal, have rte_security listed as a > >>>> dependency (instead of the explicit check). > >>> > >>> Please consider my request instead. > >>> Until now we are ifdef'ing code to allow disabling any lib. > >>> We are not going to change our mind during the last days of a release. > >>> Please just fix it for now. > >> > >> For dpaa2_sec we do not want to make the driver run without > >> rte_security. We do not see people using it without rte_security. > > > > Why not? > We see a lot of performance difference in the two cases. People may not > like to see a lower performance for the same protocol processing. > > > > >> Will take the Makefile changes that Radu has done in 1st patch of this > >> series. > > > > Is it really a lot to ifdef? > As I see it would be around 12-13 checks in 2 files. > > > > It is going to break compilation of DPDK for those who disable rte_security. > > > > Well I would say, if people do not need rte_security then they can > disable dpaa2_sec_pmd also. OK