From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B05684410E; Thu, 30 May 2024 10:02:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 44CDD402F1; Thu, 30 May 2024 10:02:50 +0200 (CEST) Received: from fout3-smtp.messagingengine.com (fout3-smtp.messagingengine.com [103.168.172.146]) by mails.dpdk.org (Postfix) with ESMTP id 688CB40041 for ; Thu, 30 May 2024 10:02:49 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfout.nyi.internal (Postfix) with ESMTP id 04EA0138012D; Thu, 30 May 2024 04:02:49 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 30 May 2024 04:02:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1717056168; x=1717142568; bh=h3fQ2BfcebSkx3Lea+0lejgZYbn1vboPlv6E/FZmX5E=; b= odJTNvCH0gIeyWuQIQs2MbzqaRcIZ6VTSVkmOWH5yj6IG4U+xXhEdscNHM8gI00n C6HqiN70JPXoE2C3tQBM4p+XwTpRiVn5z712o6ugrBiU5omJfxrGdEMNRjkpVpbq 4sAmOrn8AxHhDS1WWqTfeIvJKXCiMDKmvM1pB21UaMUpVSh9fGn679PTNUUupCx9 kMf9xoCQ8RgfglORhCJAXzuzgfgVLKPoWiStjyiqnsEWJobn7aXT2Iui9B1LjpHt fVexIJrOt6ovq47Oo/uT9mTbJLz1TR1dV1ga/wFi0Cm3s5DO8IscOfD5UuGsXVjg hftQW9ovABr2L5a+nxs/Pg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1717056168; x= 1717142568; bh=h3fQ2BfcebSkx3Lea+0lejgZYbn1vboPlv6E/FZmX5E=; b=R YtGagSDsYUtgLsG1xiHXMi+H6MhdcsOvboY0pt8quQ8awUlVz2amaaHc768wqCBK 908ooeXiSOEsRuFrrDIUiHaAHuSBNg5hmz0C6jdC6qXKHVJyGRdWNXBYURqetI8e cMMz/ovyZhR/b4OmY2hfI9KJUDhPaiFAeTsUw8bI1KkEI3FOTiTI91dVcl+xOhvS 4rMYrAtROGTVWjvUlitG6ewCT0orqo6VjheWQSHznyXUZnBHPssBGLOaoSAUUffb vHkWditQQlyeoRO8KDgdBn2y+dYa2vglQLgPtZR8v/37hCSRYNo+Lp/7csABDh7Y B1ziKvNWsQmf2K3BgMjIA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdekfedgjedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkfgjfhgggfgtsehtuf ertddttdejnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghs sehmohhnjhgrlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnhepjeduveehieevuddutd evfffgtdegkeeuveejffejgedtgeegkefgvdeugfefkeejnecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonh drnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 30 May 2024 04:02:47 -0400 (EDT) From: Thomas Monjalon To: Tyler Retzlaff Cc: dev@dpdk.org, Dmitry Kozlyuk Subject: Re: [PATCH v5 2/2] eal: initialize shared plugins on Windows Date: Thu, 30 May 2024 10:02:46 +0200 Message-ID: <3248363.l52yBJDM9G@thomas> In-Reply-To: <20240529175639.GA22530@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1701976851-17275-1-git-send-email-roretzla@linux.microsoft.com> <9541360.2WqB4rESCP@thomas> <20240529175639.GA22530@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 29/05/2024 19:56, Tyler Retzlaff: > On Wed, May 29, 2024 at 04:29:29PM +0200, Thomas Monjalon wrote: > > 12/03/2024 17:52, Tyler Retzlaff: > > > When EAL is built with MSVC it is possible to dynamically load plugins > > > on Windows. Hook eal_plugins_init into rte_eal_init if built with MSVC > > > and provide code to load plugins on Windows. > > > > > > Signed-off-by: Tyler Retzlaff > > > Acked-by: Dmitry Kozlyuk > > > --- > > > +#ifdef RTE_EXEC_ENV_WINDOWS > > > +static void* > > > +eal_dlopen(const char *pathname) > > > +{ > > > > I'm not sure about having a Windows-specific implementation in lib/eal/common/ > > are you asking for the unix and windows implementations to be moved out > to eal/{windows,unix} respectively rather than the current conditional > compiled in eal/common? Yes I feel it would be better. Please tell me if I missed something. > > Also, the CI is failing with this patchset. > > > > i'll take a look when i get a chance, you can leave it unmerged for now.