Re: [dpdk-dev] [PATCH v2] net/e1000: build on Windows

["Kadam, Pallavi" <pallavi.kadam@intel.com>]

On 10/8/2021 9:08 AM, Wang, Haiyue wrote:
>> -----Original Message-----
>> From: William Tu <u9012063@gmail.com>
>> Sent: Friday, October 8, 2021 21:54
>> To: dev@dpdk.org
>> Cc: Kadam, Pallavi <pallavi.kadam@intel.com>; david.marchand@redhat.com; Wang, Haiyue
>> <haiyue.wang@intel.com>
>> Subject: [PATCH v2] net/e1000: build on Windows
>>
>> This patch enables building the e1000 driver for Windows.
>> I tested using two Windows VM on top of VMware Fusion,
>> creating two e1000 devices with device ID 0x10D3,
>> verifying rx/tx works correctly using dpdk-testpmd.exe
>> rxonly and txonly mode.
>>
>> Signed-off-by: William Tu <u9012063@gmail.com>
>> Cc: Haiyue Wang <haiyue.wang@intel.com>
>> ---
>> A short demo:
>> https://youtu.be/UZ9hm2jQa2Y
>>
>> Example when running:
>> PS C:\dpdk> .\build\app\dpdk-testpmd.exe
>> EAL: Detected CPU lcores: 4
>> EAL: Detected NUMA nodes: 1
>> EAL: Multi-process support is requested, but not available.
>> EAL: WARNING: TSC frequency estimated roughly - clock timings may be less accurate.
>> EAL: Probe PCI driver: net_e1000_em (8086:10d3) device: 0000:03:00.0 (socket 0)
>> EAL: Requested device 0000:1b:00.0 cannot be used
>> testpmd: create a new mbuf pool <mb_pool_0>: n=171456, size=2176, socket=0
>> testpmd: preferred mempool ops selected: ring_mp_mc
>>
>> Warning! port-topology=paired and odd forward ports number, the last port will p
>> air with itself.
>> Configuring Port 0 (socket 0)
>> Port 0: 00:50:56:3A:4D:A6
>> Checking link statuses...
>> Done
>> No commandline core given, start packet forwarding
>> allocation mode: native
>> Logical Core 1 (socket 0) forwards packets on 1 streams:
>>    RX P=0/Q=0 (socket 0) -> TX P=0/Q=0 (socket 0) peer=02:00:00:00:00:00
>>
>>    io packet forwarding packets/burst=32
>>    nb forwarding cores=1 - nb forwarding ports=1
>>    port 0: RX queue number: 1 Tx queue number: 1
>>      Rx offloads=0x0 Tx offloads=0x0
>>      RX queue: 0
>>        RX desc=256 - RX free threshold=0
>>        TX desc=256 - TX free threshold=32
>>        TX offloads=0x0 - TX RS bit threshold=32
>> Press enter to exit
>>
>> Telling cores to stop...
>> Waiting for lcores to finish...
>>
>>    ---------------------- Forward statistics for port 0  ------------------
>>    RX-packets: 40361          RX-dropped: 0             RX-total: 40361
>>    TX-packets: 40616          TX-dropped: 0             TX-total: 40616
>>    ------------------------------------------------------------------------
>>
>>    +++++++++++++++ Accumulated forward statistics for all ports+++++++++++
>>    RX-packets: 40361          RX-dropped: 0             RX-total: 40361
>>    TX-packets: 40616          TX-dropped: 0             TX-total: 40616
>>    ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>
>> ---
>>   doc/guides/nics/e1000em.rst            | 13 +++++++++++++
>>   doc/guides/nics/features/e1000.ini     |  1 +
>>   doc/guides/rel_notes/release_21_11.rst |  4 ++++
>>   drivers/net/e1000/base/e1000_osdep.h   |  2 ++
>>   drivers/net/e1000/e1000_ethdev.h       |  1 +
>>   drivers/net/e1000/meson.build          |  6 ------
>>   6 files changed, 21 insertions(+), 6 deletions(-)
>>
> LGTM, thanks!
>
> Acked-by: Haiyue Wang <haiyue.wang@intel.com>
>
> Hi @ Pallavi, What do you think about the patch ?
> Your one more ACK will be nice. ;-)

Yes, code looks good to me. I actually don't have the exact same 1GbE 
device William is using.

We are trying to figure out some issues with the current 1GbE device 
that is installed.

So, will acknowledge as soon as we test it on Windows. Thanks,

>
>> --
>> 2.33.0.windows.2