From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: David Binderman <dcb314@hotmail.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] dpdk-1.7.0 bug report
Date: Fri, 01 Aug 2014 17:58:45 +0200 [thread overview]
Message-ID: <3249789.VYVRXgYKyP@xps13> (raw)
In-Reply-To: <DUB128-W1850C167912A9F863C41D69CFE0@phx.gbl>
2014-07-23 14:24, David Binderman:
> dpdk-1.7.0/lib/librte_ether/rte_ether.h:208]: (style) Expression '(X & 0x2) == 0x1' is always false.
>
> Source code is
>
> return ((ea->addr_bytes[0] & ETHER_LOCAL_ADMIN_ADDR) == 1);
>
> but
>
> #define ETHER_LOCAL_ADMIN_ADDR 0x02 /**< Locally assigned Eth. address. */
It's now fixed:
http://dpdk.org/browse/dpdk/commit/?id=030df0102ce762360
Thanks
--
Thomas
prev parent reply other threads:[~2014-08-01 15:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 14:24 David Binderman
2014-07-23 14:31 ` Thomas Monjalon
2014-07-23 14:35 ` David Binderman
2014-08-01 15:58 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3249789.VYVRXgYKyP@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dcb314@hotmail.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).