From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com
 [209.85.212.170]) by dpdk.org (Postfix) with ESMTP id 63DA95926
 for <dev@dpdk.org>; Fri,  1 Aug 2014 17:56:52 +0200 (CEST)
Received: by mail-wi0-f170.google.com with SMTP id f8so3073219wiw.1
 for <dev@dpdk.org>; Fri, 01 Aug 2014 08:58:57 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=ZtACuXfXKuieIJxCpfWKbvmQGxurqVncb2VgXBOUixk=;
 b=f1craMz4r0PAqTYGpp97+nageasaX87OE0YqZjJ+JoB7H5sfxpTgDwoyCT6x3Y6JaQ
 rtFCg74T0sbMBXKOf5wg34fV/GiyD/NF0bhJDpaHEChMVtQ1vb+cICK20DFw6TzZ05Ce
 ZoYTRlFZ+Zzmnfh0EAqJWQz9CpR2Xv3bq/kRq037rPQ2MRPK/yrLyTO1ik96WvXHJs+M
 StZfD/3SuJ2Bwfwwi/4fwSS0tTssdRXmGV/tr4Vvb+z4JY865HHyFtREssuh3MVyK36B
 xLxDzQYNQz/B3ip8/674lsLs09TgxbtuPgSC8p+Pe/omqzT+rErPLhvQ8Ym6gmsTdCTU
 6DIQ==
X-Gm-Message-State: ALoCoQm1M0ZQBlZxOlo7REytX/P5zbr9b0D/cPfE1DyY3iETg8zwLlpe1InYayhxJGgfnqXZZhVb
X-Received: by 10.180.104.163 with SMTP id gf3mr8252870wib.24.1406908737066;
 Fri, 01 Aug 2014 08:58:57 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id h13sm21829987wjs.2.2014.08.01.08.58.55
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 01 Aug 2014 08:58:56 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: David Binderman <dcb314@hotmail.com>
Date: Fri, 01 Aug 2014 17:58:45 +0200
Message-ID: <3249789.VYVRXgYKyP@xps13>
Organization: 6WIND
User-Agent: KMail/4.13.3 (Linux/3.15.7-1-ARCH; KDE/4.13.3; x86_64; ; )
In-Reply-To: <DUB128-W1850C167912A9F863C41D69CFE0@phx.gbl>
References: <DUB128-W1850C167912A9F863C41D69CFE0@phx.gbl>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] dpdk-1.7.0 bug report
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Aug 2014 15:56:52 -0000

2014-07-23 14:24, David Binderman:
> dpdk-1.7.0/lib/librte_ether/rte_ether.h:208]: (style) Expression '(X & 0x2) == 0x1' is always false.
> 
> Source code is
> 
>     return ((ea->addr_bytes[0] & ETHER_LOCAL_ADMIN_ADDR) == 1);
> 
> but
> 
> #define ETHER_LOCAL_ADMIN_ADDR 0x02 /**< Locally assigned Eth. address. */

It's now fixed:
	http://dpdk.org/browse/dpdk/commit/?id=030df0102ce762360

Thanks
-- 
Thomas