From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C325A0519; Mon, 22 Jun 2020 17:26:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2536F1D8DD; Mon, 22 Jun 2020 17:26:18 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id EEB8C1D8DC for ; Mon, 22 Jun 2020 17:26:16 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 983EC5C24F1; Mon, 22 Jun 2020 11:26:16 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Mon, 22 Jun 2020 11:26:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= A5yXHmnPpnTK1TJ/0qWG5g5OaSSZL0SfR0vyRqm4GbE=; b=PgS/hYWUSb9XTT3g ZPaGhbtyzFXZoybiJvVuNIlxYEdpJZZR9Nfp2Y6Y75rGZ8iRs6FJtK8kISli1Gfb 6W4so2eLWcqaEjD04B7iCP1CwaT1o2tXAnh6sEXLDKgGuhAWBVF6Gw/lM9k3kZjs 5B//XI8k3AHLpAREnazfKtVlmd3AURuo2YCW1M3iU2CDHo7T8SzbakDC8EinGQZx Kd00Q+sRedNxIDkOhImWS7VP1LXzLfmGqlUA896/gORH4NqKP2ArNj+XXOjOnIXy jzCcfJ/csIP73NCvUORCwtxhVmMZB1fjdm4Txs5qQjfHJQWp402xixngDbQqtkdx BxAFuQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=A5yXHmnPpnTK1TJ/0qWG5g5OaSSZL0SfR0vyRqm4G bE=; b=NSNvXDcP99KFza6UfXRprqP3c3jl8hjkadKrTotVRzakk1+qZMVMZCAgs bAueLNQInt0mMdoqOOnEzOJzoDy3fEhygtT1ARl2lQWkO3FmqUXqtxSLMeNsjviu QFJ5e25VSAdZ4VZF9NKMOdAoaQUhgwhk/O06EGzwGW+QNjnJ6NJB8EWv4mqxiQFq 5AMHpSsI0j75WI7Rchjw31Z9v5VqT3V5BxaAISX1/VuDKfGdk5pgFcGZOvlPoAtf Kv50JHORK/wITpLd7uV0csT6b4gAZm+y7o6HidcbN+guIRBaxO1jRQ+tKeHJca9/ DakhsNC1svw9h/5FQNjnU0xRW0VEA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudekvddgledtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepkeethedtieevhfeigeejleegudefjeehkeekteeuveeiuedvveeu tdejveehveetnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 390AB328006B; Mon, 22 Jun 2020 11:26:15 -0400 (EDT) From: Thomas Monjalon To: Dharmik Thakkar Cc: Ferruh Yigit , Wenzhuo Lu , Beilei Xing , Bernard Iremonger , John McNamara , Marko Kovacevic , dpdk-dev , nd , "Richardson, Bruce" Date: Mon, 22 Jun 2020 17:26:14 +0200 Message-ID: <3250606.VOZiOTzYMc@thomas> In-Reply-To: References: <20200508223829.3228-3-dharmik.thakkar@arm.com> <34965300.jtcX6sOceb@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 2/2] doc: include config options in testpmd user guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 19/06/2020 18:13, Dharmik Thakkar: > > On Jun 19, 2020, at 10:43 AM, Thomas Monjalon wro= te: > > 19/06/2020 17:38, Dharmik Thakkar: > >>> On Jun 17, 2020, at 2:48 PM, Thomas Monjalon wr= ote: > >>> 17/06/2020 20:21, Ferruh Yigit: > >>>> On 5/20/2020 4:20 AM, Dharmik Thakkar wrote: > >>>>> Update testpmd documentation to include RECORD configuration option= s, > >>>>> CONFIG_RTE_TEST_PMD_RECORD_CORE_CYCLES and > >>>>> CONFIG_RTE_TEST_PMD_RECORD_BURST_STATS. > >>>>>=20 > >>>>> Signed-off-by: Dharmik Thakkar > >>>>> Reviewed-by: Honnappa Nagarahalli > >>>>> Reviewed-by: Phil Yang > >>>>> --- > >>>>> v3: > >>>>> - Replace config/common_base with build/.config (Thomas) > >>>>>=20 > >>>>> v2: > >>>>> - Remove extra '#'. > >>>>> --- > >>>>> doc/guides/testpmd_app_ug/build_app.rst | 12 ++++++++++++ > >>>>> 1 file changed, 12 insertions(+) > >>>>>=20 > >>>>> diff --git a/doc/guides/testpmd_app_ug/build_app.rst b/doc/guides/t= estpmd_app_ug/build_app.rst > >>>>> index d1ca9f3d19a9..8c9aaa83187f 100644 > >>>>> --- a/doc/guides/testpmd_app_ug/build_app.rst > >>>>> +++ b/doc/guides/testpmd_app_ug/build_app.rst > >>>>> @@ -21,6 +21,18 @@ The basic compilation steps are: > >>>>>=20 > >>>>> export RTE_TARGET=3Dx86_64-native-linux-gcc > >>>>>=20 > >>>>> +#. If required, enable configuration options. For example: > >>>>> + > >>>>> + .. code-block:: console > >>>>> + > >>>>> + cd to the top-level DPDK directory > >>>>> + sed -i 's,\(CONFIG_RTE_TEST_PMD_RECORD_CORE_CYCLES\)=3Dn,\= 1=3Dy,' build/.config > >>>>> + sed -i 's,\(CONFIG_RTE_TEST_PMD_RECORD_BURST_STATS\)=3Dn,\= 1=3Dy,' build/.config > >>>>> + > >>>>> + Enabling CONFIG_RTE_TEST_PMD_RECORD_CORE_CYCLES enables measur= ement of CPU cycles. > >>>>> + > >>>>> + Enabling CONFIG_RTE_TEST_PMD_RECORD_BURST_STATS enables displa= y of RX and TX bursts. > >>>>> + > >>>>> #. Build the application: > >>>>>=20 > >>>>> .. code-block:: console > >>>>>=20 > >>>>=20 > >>>> Hi Dharmik, > >>>>=20 > >>>> This patch waiting to address the Thomas comment on document how to = enable those > >>>> config options in meson. @Thomas, can you please correct if I got it= wrong? > >>>=20 > >>> If the doc is only about make, it will be removed in 2 months. > >>> So yes, I think it doesn't make sense to be merged as is. > >>>=20 > >>=20 > >> Make sense. > >>=20 > >> With meson, I see multiple ways to enable configuration options: > >>=20 > >> 1] macro in $(RTE_SDK)/config/rte_config.h > >> 2] using dpdk_conf.set() in $(RTE_SDK)/config/meson.build > >>=20 > >> I=E2=80=99d appreciate some suggestions on the best way to enable thes= e options. > >=20 > > Neither 1 nor 2 because both are source files. > > Configuration must be done in the build directory. > >=20 > > We use "meson -D" to configure options listed in meson_options.txt > > The real question is which option we accept to be added. > >=20 > >=20 >=20 > Yes, correct. There are suggestions for making these as runtime configura= tion functions which can be enabled(or disabled) using =E2=80=99set=E2=80= =99 from within the application. I don't understand this proposal. Is there a patch? > Do you think, till this change is implemented, these options can be inclu= ded in meson_options.txt? In general, if you think there is a better alternative, please propose a patch. I have no opinion what is best to manage such option.