[dpdk-dev] [PATCH] i40e: compile fix on ICC 13.0.0

[dpdk-dev] [PATCH] i40e: compile fix on ICC 13.0.0

[Helin Zhang]

Below compile error can be found on ICC 13.0.0, which is a warning
treated as error. Forcedly disabling the warning can fix it.

Error log:
lib/librte_pmd_i40e/i40e/i40e_nvm.c(1022): error #188: enumerated
type mixed with another type
hw->aq.asq_last_status = old_asq_status;
                       ^

Signed-off-by: Helin Zhang <helin.zhang@intel.com>
---
 lib/librte_pmd_i40e/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_pmd_i40e/Makefile b/lib/librte_pmd_i40e/Makefile
index 22f0716..911e4f5 100644
--- a/lib/librte_pmd_i40e/Makefile
+++ b/lib/librte_pmd_i40e/Makefile
@@ -48,7 +48,7 @@ LIBABIVER := 1
 # to disable warnings
 #
 ifeq ($(CC), icc)
-CFLAGS_BASE_DRIVER = -wd593
+CFLAGS_BASE_DRIVER = -wd593 -wd188
 else ifeq ($(CC), clang)
 CFLAGS_BASE_DRIVER += -Wno-sign-compare
 CFLAGS_BASE_DRIVER += -Wno-unused-value
-- 
1.8.1.4

[dpdk-dev] [PATCH v2 0/2] compile fixes on ICC and clang

[Helin Zhang]

Compile warnings on ICC and clang can be found, and treated as errors.
Disabling those warnings forcedly can fix them.

v2 changes:
Added the fix for the compile error on clang.

Helin Zhang (2):
  i40e: compile fix on ICC 13.0.0
  i40e: compile fix on clang 3.3

 lib/librte_pmd_i40e/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
1.8.1.4

[dpdk-dev] [PATCH v2 1/2] i40e/base: compile fix on ICC 13.0.0

[Helin Zhang]

Below compile error can be found on ICC 13.0.0, which is a warning
treated as error. Forcedly disabling the warning can fix it.

Error log:
lib/librte_pmd_i40e/i40e/i40e_nvm.c(1022): error #188: enumerated
type mixed with another type
hw->aq.asq_last_status = old_asq_status;
                       ^

Signed-off-by: Helin Zhang <helin.zhang@intel.com>
---
 lib/librte_pmd_i40e/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_pmd_i40e/Makefile b/lib/librte_pmd_i40e/Makefile
index 22f0716..911e4f5 100644
--- a/lib/librte_pmd_i40e/Makefile
+++ b/lib/librte_pmd_i40e/Makefile
@@ -48,7 +48,7 @@ LIBABIVER := 1
 # to disable warnings
 #
 ifeq ($(CC), icc)
-CFLAGS_BASE_DRIVER = -wd593
+CFLAGS_BASE_DRIVER = -wd593 -wd188
 else ifeq ($(CC), clang)
 CFLAGS_BASE_DRIVER += -Wno-sign-compare
 CFLAGS_BASE_DRIVER += -Wno-unused-value
-- 
1.8.1.4

[dpdk-dev] [PATCH v2 2/2] i40e/base: compile fix on clang 3.3

[Helin Zhang]

Below compile error can be found on clang 3.3, which is a warning
treated as error. Forcedly disabling the warning can fix it.

Error log:
lib/librte_pmd_i40e/i40e/i40e_nvm.c:708:20: error: unused variable
'i40e_nvm_update_state_str' [-Werror,-Wunused-variable]
STATIC const char *i40e_nvm_update_state_str[] = {
                   ^

Signed-off-by: Helin Zhang <helin.zhang@intel.com>
---
 lib/librte_pmd_i40e/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/librte_pmd_i40e/Makefile b/lib/librte_pmd_i40e/Makefile
index 911e4f5..4a5635b 100644
--- a/lib/librte_pmd_i40e/Makefile
+++ b/lib/librte_pmd_i40e/Makefile
@@ -58,6 +58,7 @@ CFLAGS_BASE_DRIVER += -Wno-format
 CFLAGS_BASE_DRIVER += -Wno-missing-field-initializers
 CFLAGS_BASE_DRIVER += -Wno-pointer-to-int-cast
 CFLAGS_BASE_DRIVER += -Wno-format-nonliteral
+CFLAGS_BASE_DRIVER += -Wno-unused-variable
 else
 CFLAGS_BASE_DRIVER  = -Wno-sign-compare
 CFLAGS_BASE_DRIVER += -Wno-unused-value
-- 
1.8.1.4

Re: [dpdk-dev] [PATCH v2 1/2] i40e/base: compile fix on ICC 13.0.0

[Bruce Richardson]

On Mon, May 18, 2015 at 11:03:28PM +0800, Helin Zhang wrote:
> Below compile error can be found on ICC 13.0.0, which is a warning
> treated as error. Forcedly disabling the warning can fix it.
> 
> Error log:
> lib/librte_pmd_i40e/i40e/i40e_nvm.c(1022): error #188: enumerated
> type mixed with another type
> hw->aq.asq_last_status = old_asq_status;
>                        ^
> 
> Signed-off-by: Helin Zhang <helin.zhang@intel.com>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

> ---
>  lib/librte_pmd_i40e/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_pmd_i40e/Makefile b/lib/librte_pmd_i40e/Makefile
> index 22f0716..911e4f5 100644
> --- a/lib/librte_pmd_i40e/Makefile
> +++ b/lib/librte_pmd_i40e/Makefile
> @@ -48,7 +48,7 @@ LIBABIVER := 1
>  # to disable warnings
>  #
>  ifeq ($(CC), icc)
> -CFLAGS_BASE_DRIVER = -wd593
> +CFLAGS_BASE_DRIVER = -wd593 -wd188
>  else ifeq ($(CC), clang)
>  CFLAGS_BASE_DRIVER += -Wno-sign-compare
>  CFLAGS_BASE_DRIVER += -Wno-unused-value
> -- 
> 1.8.1.4
> 

Re: [dpdk-dev] [PATCH v2 2/2] i40e/base: compile fix on clang 3.3

[Bruce Richardson]

On Mon, May 18, 2015 at 11:03:29PM +0800, Helin Zhang wrote:
> Below compile error can be found on clang 3.3, which is a warning
> treated as error. Forcedly disabling the warning can fix it.
> 
> Error log:
> lib/librte_pmd_i40e/i40e/i40e_nvm.c:708:20: error: unused variable
> 'i40e_nvm_update_state_str' [-Werror,-Wunused-variable]
> STATIC const char *i40e_nvm_update_state_str[] = {
>                    ^
> 
> Signed-off-by: Helin Zhang <helin.zhang@intel.com>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

> ---
>  lib/librte_pmd_i40e/Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/librte_pmd_i40e/Makefile b/lib/librte_pmd_i40e/Makefile
> index 911e4f5..4a5635b 100644
> --- a/lib/librte_pmd_i40e/Makefile
> +++ b/lib/librte_pmd_i40e/Makefile
> @@ -58,6 +58,7 @@ CFLAGS_BASE_DRIVER += -Wno-format
>  CFLAGS_BASE_DRIVER += -Wno-missing-field-initializers
>  CFLAGS_BASE_DRIVER += -Wno-pointer-to-int-cast
>  CFLAGS_BASE_DRIVER += -Wno-format-nonliteral
> +CFLAGS_BASE_DRIVER += -Wno-unused-variable
>  else
>  CFLAGS_BASE_DRIVER  = -Wno-sign-compare
>  CFLAGS_BASE_DRIVER += -Wno-unused-value
> -- 
> 1.8.1.4
> 

Re: [dpdk-dev] [PATCH v2 1/2] i40e/base: compile fix on ICC 13.0.0

[Bruce Richardson]

On Mon, May 18, 2015 at 04:11:06PM +0100, Bruce Richardson wrote:
> On Mon, May 18, 2015 at 11:03:28PM +0800, Helin Zhang wrote:
> > Below compile error can be found on ICC 13.0.0, which is a warning
> > treated as error. Forcedly disabling the warning can fix it.
> > 
> > Error log:
> > lib/librte_pmd_i40e/i40e/i40e_nvm.c(1022): error #188: enumerated
> > type mixed with another type
> > hw->aq.asq_last_status = old_asq_status;
> >                        ^
> > 
> > Signed-off-by: Helin Zhang <helin.zhang@intel.com>
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 

Fix works, but you probably should reword the title to start with "fix".

For future reference, it would also be nice to reference the commit that broke things.


> > ---
> >  lib/librte_pmd_i40e/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/lib/librte_pmd_i40e/Makefile b/lib/librte_pmd_i40e/Makefile
> > index 22f0716..911e4f5 100644
> > --- a/lib/librte_pmd_i40e/Makefile
> > +++ b/lib/librte_pmd_i40e/Makefile
> > @@ -48,7 +48,7 @@ LIBABIVER := 1
> >  # to disable warnings
> >  #
> >  ifeq ($(CC), icc)
> > -CFLAGS_BASE_DRIVER = -wd593
> > +CFLAGS_BASE_DRIVER = -wd593 -wd188
> >  else ifeq ($(CC), clang)
> >  CFLAGS_BASE_DRIVER += -Wno-sign-compare
> >  CFLAGS_BASE_DRIVER += -Wno-unused-value
> > -- 
> > 1.8.1.4
> > 

[dpdk-dev] [PATCH v3 0/2] fix compile with ICC and clang

[Helin Zhang]

Compile warnings on ICC and clang can be found, and treated as errors.
Disabling those warnings forcedly can fix them.

v2 changes:
Added the fix for the compile error on clang.

v3 changes:
Reworded the commit titles.

Helin Zhang (2):
  i40e: compile fix on ICC 13.0.0
  i40e: compile fix on clang 3.3

 lib/librte_pmd_i40e/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
1.8.1.4

[dpdk-dev] [PATCH v3 1/2] i40e/base: fix compile with ICC 13.0.0

[Helin Zhang]

Below compile error can be found on ICC 13.0.0, which is a warning
treated as error. Forcedly disabling the warning can fix it.

Error log:
lib/librte_pmd_i40e/i40e/i40e_nvm.c(1022): error #188: enumerated
type mixed with another type
hw->aq.asq_last_status = old_asq_status;
                       ^

Signed-off-by: Helin Zhang <helin.zhang@intel.com>
---
 lib/librte_pmd_i40e/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

v3 changes:
Reworded the commit title.

diff --git a/lib/librte_pmd_i40e/Makefile b/lib/librte_pmd_i40e/Makefile
index 22f0716..911e4f5 100644
--- a/lib/librte_pmd_i40e/Makefile
+++ b/lib/librte_pmd_i40e/Makefile
@@ -48,7 +48,7 @@ LIBABIVER := 1
 # to disable warnings
 #
 ifeq ($(CC), icc)
-CFLAGS_BASE_DRIVER = -wd593
+CFLAGS_BASE_DRIVER = -wd593 -wd188
 else ifeq ($(CC), clang)
 CFLAGS_BASE_DRIVER += -Wno-sign-compare
 CFLAGS_BASE_DRIVER += -Wno-unused-value
-- 
1.8.1.4

[dpdk-dev] [PATCH v3 2/2] i40e/base: fix compile with clang 3.3

[Helin Zhang]

Below compile error can be found on clang 3.3, which is a warning
treated as error. Forcedly disabling the warning can fix it.

Error log:
lib/librte_pmd_i40e/i40e/i40e_nvm.c:708:20: error: unused variable
'i40e_nvm_update_state_str' [-Werror,-Wunused-variable]
STATIC const char *i40e_nvm_update_state_str[] = {
                   ^

Signed-off-by: Helin Zhang <helin.zhang@intel.com>
---
 lib/librte_pmd_i40e/Makefile | 1 +
 1 file changed, 1 insertion(+)

v3 changes:
Reworded the commit title.

diff --git a/lib/librte_pmd_i40e/Makefile b/lib/librte_pmd_i40e/Makefile
index 911e4f5..4a5635b 100644
--- a/lib/librte_pmd_i40e/Makefile
+++ b/lib/librte_pmd_i40e/Makefile
@@ -58,6 +58,7 @@ CFLAGS_BASE_DRIVER += -Wno-format
 CFLAGS_BASE_DRIVER += -Wno-missing-field-initializers
 CFLAGS_BASE_DRIVER += -Wno-pointer-to-int-cast
 CFLAGS_BASE_DRIVER += -Wno-format-nonliteral
+CFLAGS_BASE_DRIVER += -Wno-unused-variable
 else
 CFLAGS_BASE_DRIVER  = -Wno-sign-compare
 CFLAGS_BASE_DRIVER += -Wno-unused-value
-- 
1.8.1.4

Re: [dpdk-dev] [PATCH v3 0/2] fix compile with ICC and clang

[Bruce Richardson]

On Mon, May 18, 2015 at 11:40:54PM +0800, Helin Zhang wrote:
> Compile warnings on ICC and clang can be found, and treated as errors.
> Disabling those warnings forcedly can fix them.
> 
> v2 changes:
> Added the fix for the compile error on clang.
> 
> v3 changes:
> Reworded the commit titles.
> 
> Helin Zhang (2):
>   i40e: compile fix on ICC 13.0.0
>   i40e: compile fix on clang 3.3
> 
>  lib/librte_pmd_i40e/Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> -- 
> 1.8.1.4
> 
Series Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Re: [dpdk-dev] [PATCH v2 0/2] compile fixes on ICC and clang

[Tetsuya Mukawa]

On 2015/05/19 0:03, Helin Zhang wrote:
> Compile warnings on ICC and clang can be found, and treated as errors.
> Disabling those warnings forcedly can fix them.
>
> v2 changes:
> Added the fix for the compile error on clang.
>
> Helin Zhang (2):
>   i40e: compile fix on ICC 13.0.0
>   i40e: compile fix on clang 3.3
>
>  lib/librte_pmd_i40e/Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
Acked-by: Tetsuya Mukawa <mukawa@igel.co.jp>

Re: [dpdk-dev] [PATCH v3 0/2] fix compile with ICC and clang

[Thomas Monjalon]

2015-05-18 16:43, Bruce Richardson:
> On Mon, May 18, 2015 at 11:40:54PM +0800, Helin Zhang wrote:
> > Compile warnings on ICC and clang can be found, and treated as errors.
> > Disabling those warnings forcedly can fix them.
> > 
> > v2 changes:
> > Added the fix for the compile error on clang.
> > 
> > v3 changes:
> > Reworded the commit titles.
> 
> Series Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks
I reworded the commit message and added reference to the breaking commit:
	http://dpdk.org/browse/dpdk/commit/?id=ff5c3960017cf
Please consider giving this kind of explanation when fixing things,
especially for special handling of base drivers.

Re: [dpdk-dev] [PATCH v3 0/2] fix compile with ICC and clang

[Zhang, Helin]

Thomas, thank you!

- Helin

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Tuesday, May 19, 2015 6:33 PM
> To: Zhang, Helin
> Cc: dev@dpdk.org; Richardson, Bruce
> Subject: Re: [dpdk-dev] [PATCH v3 0/2] fix compile with ICC and clang
> 
> 2015-05-18 16:43, Bruce Richardson:
> > On Mon, May 18, 2015 at 11:40:54PM +0800, Helin Zhang wrote:
> > > Compile warnings on ICC and clang can be found, and treated as
> errors.
> > > Disabling those warnings forcedly can fix them.
> > >
> > > v2 changes:
> > > Added the fix for the compile error on clang.
> > >
> > > v3 changes:
> > > Reworded the commit titles.
> >
> > Series Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> Applied, thanks
> I reworded the commit message and added reference to the breaking
> commit:
> 	http://dpdk.org/browse/dpdk/commit/?id=ff5c3960017cf
> Please consider giving this kind of explanation when fixing things,
> especially for special handling of base drivers.