From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f54.google.com (mail-wg0-f54.google.com [74.125.82.54])
 by dpdk.org (Postfix) with ESMTP id 72B45C320
 for <dev@dpdk.org>; Tue, 19 May 2015 12:33:35 +0200 (CEST)
Received: by wgjc11 with SMTP id c11so12493599wgj.0
 for <dev@dpdk.org>; Tue, 19 May 2015 03:33:35 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=+IskcOeF3PoehsdtcB1C+UyuCk7rh5WzbHtFoQskPPo=;
 b=A96MhhODMAxm8vIgpb5RCiAiN8b20lh629L6ZHZyafVRdwS2ECrq4yRdb/1Ds9OqZM
 oTe/7f9ZglrE4u8ObEis6dSO6qB+WsaK4YuFqukrPgX4oHmxNctg/zqOLv0mai1aZI8b
 kqGm6Jrb9EJv/CUr54cQ2wR5q3/XRCLWNsTC4wewE3sOzHLM1/rzAzzWYK17G8ja6XEc
 oDkTjXfWUF6MwUxRYE1q8/uFBLec70MhH/w3sNtIt1Q/Z4VMcyEKDRXZA8llPdQAXpxL
 OzqaO7LMOnPlOknnZa3zPCESfL7sI0t1DdTvofR4w5SodhxQhA1Oq8mrB44GAG7gMxq1
 l/cQ==
X-Gm-Message-State: ALoCoQkdIHdXf0mRykfo7Lb6wkEotQFKWY+RagEflx1sClk0bekz5ArdNsZ6uSQmzXoHhUiJ2zDc
X-Received: by 10.194.109.167 with SMTP id ht7mr2497365wjb.60.1432031615329;
 Tue, 19 May 2015 03:33:35 -0700 (PDT)
Received: from xps13.localnet ([62.159.77.186])
 by mx.google.com with ESMTPSA id yz3sm21135328wjc.19.2015.05.19.03.33.33
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 19 May 2015 03:33:34 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Helin Zhang <helin.zhang@intel.com>
Date: Tue, 19 May 2015 12:32:50 +0200
Message-ID: <3255170.m2Jvvj9c1g@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.7 (Linux/4.0.1-1-ARCH; KDE/4.14.7; x86_64; ; )
In-Reply-To: <20150518154325.GA8740@bricha3-MOBL3>
References: <1431961409-22252-1-git-send-email-helin.zhang@intel.com>
 <1431963656-22836-1-git-send-email-helin.zhang@intel.com>
 <20150518154325.GA8740@bricha3-MOBL3>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 0/2] fix compile with ICC and clang
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 19 May 2015 10:33:35 -0000

2015-05-18 16:43, Bruce Richardson:
> On Mon, May 18, 2015 at 11:40:54PM +0800, Helin Zhang wrote:
> > Compile warnings on ICC and clang can be found, and treated as errors.
> > Disabling those warnings forcedly can fix them.
> > 
> > v2 changes:
> > Added the fix for the compile error on clang.
> > 
> > v3 changes:
> > Reworded the commit titles.
> 
> Series Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks
I reworded the commit message and added reference to the breaking commit:
	http://dpdk.org/browse/dpdk/commit/?id=ff5c3960017cf
Please consider giving this kind of explanation when fixing things,
especially for special handling of base drivers.