From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6FC0BA0588; Mon, 13 Apr 2020 14:23:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D027B1BEA5; Mon, 13 Apr 2020 14:23:06 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 727EC1BE9B for ; Mon, 13 Apr 2020 14:23:05 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 4D9698F0; Mon, 13 Apr 2020 08:23:04 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Mon, 13 Apr 2020 08:23:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=DvoYphYeQ1Lwao4eSgFWABECAozvOAs8VYeenJo+j+g=; b=BvveGsG0tYws LjXu/1gLX8iwV28Jr+65MLJHjT/ZWWx5ag/y0afVZJk9GLhe27bL1LfDvrvfOKF+ Fha+dHvHFPpNf9VUj+L4GLtvIxKFCHr0Qn6sMZg2XaQD707nxpFYeC0522l5hDdi tp0gtEXrM2/v11ZSRowblF7sMxLzz8k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=DvoYphYeQ1Lwao4eSgFWABECAozvOAs8VYeenJo+j +g=; b=zY9oFGT1q53UJucOLzIF5463cHR6HvP2qUtOds6nQCT/GPiNWnDtuthkH +yblcdiESHTXkG6ZzUxmwVcNYZtUHXczgO8P3X63d6UFVQvnI7fqlq/gZl7NJGDs niWjl0Yn+EWiGLrESXuAnIkII36RTCN6PdYsYVcbxvkcc3zJw4b0Uz5rewroKo0P u1CUNPuliWMJIjA749bJdCRGka0kjvr2cOJPpMGT9LqiXanLip+kc3H8Js9jMKMe WsI2Oyc7305bksKR5WncK5mwFp/54O0cTy5mHorOUyERI+D8I3bwXjf0WiNNeOev 6J+GZXTy8sL9x7HuoGX1VyDEnqeug== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrvdelgdehgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4659C328006E; Mon, 13 Apr 2020 08:23:03 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit , Slava Ovsiienko Cc: "dev@dpdk.org" , "bernard.iremonger@intel.com" Date: Mon, 13 Apr 2020 14:23:02 +0200 Message-ID: <3258848.yKVeVyVuyW@thomas> In-Reply-To: References: <1561553317-16777-1-git-send-email-viacheslavo@mellanox.com> <9f95eb9a-c7c3-17c6-afc6-0a0d20847e08@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 1/3] app/testpmd: add profiling flags set command X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 13/04/2020 09:56, Slava Ovsiienko: > From: Ferruh Yigit > > > +set fwdprof > > > +~~~~~~~~~~~ > > > + > > > +Set the flags controlling the datapath profiling statistics:: > > > + > > > + testpmd> set fwdprof (flags) > >=20 > > What do you think a little longer command 'fwdprofile", which is more c= lear I > > think. > Yes, it is clearer, but longer to type =F0=9F=98=8A > If you insist on - I will extend, please, let me know your final opinion. I agree with Ferruh in general and especially about "fwdprof" not nice to r= ead. What about fwd-profiling? I would be also OK with fwd-prof. Is it common to use hyphen sign in testpmd commands?