From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 25CD9A0524; Mon, 19 Apr 2021 20:15:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C8E34144B; Mon, 19 Apr 2021 20:15:48 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 7C0294013F; Mon, 19 Apr 2021 20:15:46 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 2F96C5C0295; Mon, 19 Apr 2021 14:15:46 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 19 Apr 2021 14:15:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= XI07c8Xsfxak8jy/2SiZFGR23i9kQkV+h1bmJf+AHeA=; b=yTVJthLcHNfVtdPw PXBsnPAmpbVChcaxs4xAQ01GmX9b0K3TKpWBuFmvfzbQcwhFNz40uCyQRhzTThpf Y0H4dgbVLnB2r9/FIIYXGAb9G2hIJLMg5e7Xj+CRowWV3cEu/2oqvJ/YQP081wET 7+DJtVjTs7YMTxJRQvbr9uY9R5OV6QVE0XosZY+XEr2ePOrWUaJfhC6De5mdLMVW AkKC0rvKLNHslagW3R39DJDumhYzFpDjEpciOZ8Dn2oqY66kw+DTDhKXXkZbpeNs JPMo37hzcQ1pk1iDqvkhBTuW6EsA3+PeurZsC7ujHX7239dWYPtW+qc3hUkHDX9l rXoqtg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=XI07c8Xsfxak8jy/2SiZFGR23i9kQkV+h1bmJf+AH eA=; b=CM/L81Sjk4KM3WYbmrQ/9t6iehllt+5/0zzxfGoFw7RvnB6ij4MeWzEID IPrG710fdYrmOHi+PwK6cXJ8oVRs1uoFF82rtHnB6rSftaCDeLcwsBM2s1yw26mr hjBp7yRR3LHDtLZLwV1f69vXus0ndtuCrVLfYIvK+4Eyu//H9k0w9PL+aF1b3kpd 7cN4oEKUUdNXj57/SsyEIPecP+HRKyFr3GrYLpMjyaunZcPBuy5XwLJAV9gJxmzk NddOULqlN1JCyEAb5rSxqcJGtrN7CG932llfHMudPjVoX7//qzOETxBJXiSjITix DG4i7CrLK6UrU3r5eM6VPakksmJYQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddtgedguddvgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeeltdefudegueehuefgheduveevkeehuedujeefkeeigeffvefg kefhudefkeefvdenucffohhmrghinhepohgsjhdrihhnnecukfhppeejjedrudefgedrvd dtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr ohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D7D451080057; Mon, 19 Apr 2021 14:15:44 -0400 (EDT) From: Thomas Monjalon To: Tal Shnaiderman Cc: Dmitry Kozlyuk , "dev@dpdk.org" , "pallavi.kadam@intel.com" , "navasile@linux.microsoft.com" , "dmitrym@microsoft.com" , ci@dpdk.org Date: Mon, 19 Apr 2021 20:15:43 +0200 Message-ID: <3259972.HMeeyuY8TW@thomas> In-Reply-To: References: <20210418170803.15684-1-talshn@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal/windows: fix build warnings in MinGW X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 19/04/2021 20:06, Tal Shnaiderman: > > > 2021-04-18 19:04 (UTC+0000), Tal Shnaiderman: > > > > > 18/04/2021 19:08, Tal Shnaiderman: > > > > > > the strncasecmp marco defined in rte_os_shim.h is already > > > > > > defined in MinGW-w64, as a result the compiler prints out the > > > > > > warning below on function redefinition whenever compiling a file > > > > > > including the > > > header. > > > > > > > > > > > > ..\lib/librte_eal/windows/include/rte_os_shim.h:21: > > > > > > warning: "strncasecmp" redefined #define strncasecmp(s1, s2, > > > > > > count) _strnicmp(s1, s2, count) > > > > > > > > > > Why the tests are passing? Are we allowing warnings in build test? > > > > > > > > It's a good question, I see CI is passing without warnings, Dmitry > > > > can you > > > reproduce it? > > > > > > > > On my side the collision is with the following file: > > > > > > > > C:/mingw-w64/x86_64/mingw64/x86_64-w64- > > > mingw32/include/string.h:119: > > > > note: this is the location of the previous definition #define > > > > strncasecmp _strnicmp > > > > > > > > I'm using: > > > > -gcc (x86_64-win32-seh-rev0, Built by MinGW-W64 project) 8.1.0 > > > > -meson > > > > 0.53.2 > > > > > > I can't reproduce it using the same versions. > > > Do you invoke meson with other options than "-Dexamples=..."? > > > > This is the meson line I'm using: > > > > meson "-Dexamples=helloworld" build --wipe --default-library=static -- > > buildtype debug > > > > The problem however is that MinGW's string.h defines the macro in line 119, > > for some reason my build includes it and the rest doesn't. > > Hi Dmitry, > > I also noticed warnings in clang on my setup that are related to rte_os_shim.h: > > [185/314] Compiling C object drivers/a715181@@tmp_rte_common_mlx5@sta/common_mlx5_mlx5_common_mp.c.obj. > In file included from ../drivers/common/mlx5/mlx5_common_mp.c:13: > In file included from ..\drivers\common/mlx5/mlx5_common_utils.h:8: > In file included from ..\drivers\common/mlx5/mlx5_common.h:17: > ..\lib/librte_eal/windows/include\rte_os_shim.h:22:51: warning: token pasting of ',' and __VA_ARGS__ is a GNU extension [-Wgnu-zero-variadic-macro-arguments] > #define open(path, flags, ...) _open(path, flags, ##__VA_ARGS__) > ^ > However don't see it in CI, I'm using clang version 9.0.1 It seems we should improve our CI. Please open suggestions in the CI bugzilla.