From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5B01A00C5; Sun, 5 Jul 2020 23:18:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4D0361D693; Sun, 5 Jul 2020 23:18:46 +0200 (CEST) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id 542691D68E for ; Sun, 5 Jul 2020 23:18:44 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id E0E9258044D; Sun, 5 Jul 2020 17:18:43 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Sun, 05 Jul 2020 17:18:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= Wg/TJpi/F4Ks1dYkqhEOaGcje5SM8ourJq9SvHSCKas=; b=Yj+eUpoMpNY4kB4B UDVoaHMsiXyzgGv5b/XSZdwf/x4TbEtCEdyRi2q248aDOVRpl5cK6v5Bw44EvvXq o8nLh1l8K6tdoAQfrgx3v8Ck0s4/lP+WFzHTuFWonRbt0M6gvfUKI/NpBhCDp9jA jFy4V94PtpnaV1DK5Be2lWoyKQiYxy8vp09iDvgaLD7AbrWAZOwew51EQgkHW25o V7F4giwSXc7wI3r2qgkkVnne643Hinagp6L9JF4+gc+fPB3my1oW0sXoQ7bqMRe6 +hn6UI6JAHMs4Ckna2BjVA+qEzDq6J1cfYJRV5Heb3mEanDbgSVnEcqP4BwPxAxw gwzv8w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=Wg/TJpi/F4Ks1dYkqhEOaGcje5SM8ourJq9SvHSCK as=; b=ZLR1Fz5mZOP8uDweQfknwsN//UEeu+QO26p+gMF03KM9CguADBAYIE32A SY7P9REj4b+dJVCGKnbbR6HoXnFIuFgwJm+5ByEfDVb18I3y49j7azBp/JIltd2l blLPfiYLeZkKyOKYAImSC1kI/Gg/kXiSj8OT+XdexlPHy3oldlzk+TxIPbds5sFg ui2WMmEYGPnWlbEgRtwiBJsHV/VN0n6yg2Cr4gc7M45pASNrulBR9oIhJE/GQphO lsD1Ia9EdZ2vKZ9wW5j/ji7zmTCcDbVO4tYwVZ+yVVt1UIlUiaFH6fruxe/PTloX OFUAgP0t8kpyFAnJWcnbWZdXi25dg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedruddugdduiedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepvedvledtffevheelvdefieehkedvkeefueffieduudeliedvjeeg geejffffffeknecuffhomhgrihhnpegtohhnfhdrihhnnecukfhppeejjedrudefgedrvd dtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr ohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 65091306AAA6; Sun, 5 Jul 2020 17:18:38 -0400 (EDT) From: Thomas Monjalon To: jerinj@marvell.com, Ori Kam Cc: xiang.w.wang@intel.com, dev@dpdk.org, guyk@marvell.com, pbhagavatula@marvell.com, shahafs@mellanox.com, hemant.agrawal@nxp.com, opher@mellanox.com, alexr@mellanox.com, dovrat@marvell.com, pkapoor@marvell.com, nipun.gupta@nxp.com, bruce.richardson@intel.com, yang.a.hong@intel.com, harry.chang@intel.com, gu.jian1@zte.com.cn, shanjiangh@chinatelecom.cn, zhangy.yun@chinatelecom.cn, lixingfu@huachentel.com, wushuai@inspur.com, yuyingxia@yxlink.com, fanchenggang@sunyainfo.com, davidfgao@tencent.com, liuzhong1@chinaunicom.cn, zhaoyong11@huawei.com, oc@yunify.com, jim@netgate.com, hongjun.ni@intel.com, deri@ntop.org, fc@napatech.com, arthur.su@lionic.com Date: Sun, 05 Jul 2020 23:18:37 +0200 Message-ID: <3275376.WQDlNZRKe8@thomas> In-Reply-To: <1593675963-13317-2-git-send-email-orika@mellanox.com> References: <1585464438-111285-1-git-send-email-orika@mellanox.com> <1593675963-13317-1-git-send-email-orika@mellanox.com> <1593675963-13317-2-git-send-email-orika@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 1/4] regexdev: introduce regexdev subsystem X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 02/07/2020 09:46, Ori Kam: > From: Jerin Jacob > --- a/config/common_base > +++ b/config/common_base > # > +# Compile regex device support > +# > +CONFIG_RTE_LIBRTE_REGEXDEV=y > + > +# > # Compile librte_ring > # > CONFIG_RTE_LIBRTE_RING=y > @@ -1141,3 +1146,4 @@ CONFIG_RTE_APP_CRYPTO_PERF=y > # Compile the eventdev application > # > CONFIG_RTE_APP_EVENTDEV=y > + Why this empty line? > --- a/doc/api/doxy-api-index.md > +++ b/doc/api/doxy-api-index.md > @@ -26,6 +26,7 @@ The public API headers are grouped by topics: > [event_timer_adapter] (@ref rte_event_timer_adapter.h), > [event_crypto_adapter] (@ref rte_event_crypto_adapter.h), > [rawdev] (@ref rte_rawdev.h), > + [regexdev] (@ref rte_regexdev.h), > [metrics] (@ref rte_metrics.h), Please move regexdev after [compress]. > --- a/doc/api/doxy-api.conf.in > +++ b/doc/api/doxy-api.conf.in > @@ -61,6 +61,7 @@ INPUT = @TOPDIR@/doc/api/doxy-api-index.md \ > @TOPDIR@/lib/librte_rcu \ > @TOPDIR@/lib/librte_reorder \ > @TOPDIR@/lib/librte_rib \ > + @TOPDIR@/lib/librte_regexdev \ > @TOPDIR@/lib/librte_ring \ What is the ordering here? > --- a/doc/guides/prog_guide/index.rst > +++ b/doc/guides/prog_guide/index.rst > @@ -72,3 +72,4 @@ Programmer's Guide > lto > profile_app > glossary > + regexdev_lib Why adding it at the end? I would suggest adding regexdev after compressdev. > --- /dev/null > +++ b/doc/guides/prog_guide/regexdev_lib.rst Please remove the _lib suffix in this filename. [...] > +The dequeue API uses the same format as the enqueue API of processed but > +the ``nb_ops`` and ``ops`` parameters are now used to specify the max processed > +operations the user wishes to retrieve and the location in which to store them. > +The API call returns the actual number of processed operations returned, this > +can never be larger than ``nb_ops``. > + Please avoid empty line at end of files. > --- /dev/null > +++ b/lib/librte_regexdev/Makefile > @@ -0,0 +1,31 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright(C) 2019 Marvell International Ltd. > +# Copyright(C) 2020 Mellanox International Ltd. Mellanox copyright is wrong. It should be: Copyright 2020 Mellanox Technologies, Ltd > --- /dev/null > +++ b/lib/librte_regexdev/meson.build > @@ -0,0 +1,7 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright(c) 2020 Mellanox Corporation Wrong copyright. Please check them all. > + > +allow_experimental_apis = true Internal libraries do not need such flag anymore. > +sources = files('rte_regexdev.c') > +headers = files('rte_regexdev.h') > +deps += ['mbuf'] [...] > --- a/lib/meson.build > +++ b/lib/meson.build > @@ -25,7 +25,7 @@ libraries = [ > 'gro', 'gso', 'ip_frag', 'jobstats', > 'kni', 'latencystats', 'lpm', 'member', > 'power', 'pdump', 'rawdev', > - 'rib', 'reorder', 'sched', 'security', 'stack', 'vhost', > + 'regexdev', 'rib', 'reorder', 'sched', 'security', 'stack', 'vhost', strange choice :) I would have added regex at the end of the previous line which is shorter.