From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 2620A5F2B for ; Tue, 27 Jan 2015 11:01:14 +0100 (CET) Received: by mail-wg0-f44.google.com with SMTP id z12so13795428wgg.3 for ; Tue, 27 Jan 2015 02:01:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Oku2aJXYG3oUJcqTJIrMwArT7yPsryPtJwmgQio0aUA=; b=MIKzz3Wlua7/VHXHp873mrYbCjVFqjAR4BMrzJMSCMlKA0hh9RLslabVg5L/vHy+fC 558lEnfw9tVKr8FXz6+BJw4g6fb9VRjf8KTxkvd0O7xCjPAZP9EFxh8xsbiETrI1rWOk 4QikvW/8WaNfPMDx3tAm1VT0pC9TnBVyXKen46RQHAHvBdGSE625gdZaFS8ws2iBtCgC goA3/Vd8w6UcOJjKMn0aljPAIzCMwP+vfIDVK2lKBQYgP1UflTjwlnSmvGnCNz/HL2YP FK5er2s7TAJoLzdD075rTGmlKc/BKXMURwtflVCQF5xFTyjAA+7tUw5vj1kqtN9auoCW m/jQ== X-Gm-Message-State: ALoCoQl8R6qfyD/XlOOrbMtTmXKJYaYgEYBuMeStdjZlAdzQZGbG9hLBsCGX2dxc9NdaeHv3bprp X-Received: by 10.194.205.138 with SMTP id lg10mr938021wjc.130.1422352873967; Tue, 27 Jan 2015 02:01:13 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id q4sm1115126wiz.4.2015.01.27.02.01.12 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Jan 2015 02:01:13 -0800 (PST) From: Thomas Monjalon To: Michael Qiu Date: Tue, 27 Jan 2015 11:00:46 +0100 Message-ID: <3276396.omH03JUPtz@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.18.2-2-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <1421333111-22136-1-git-send-email-michael.qiu@intel.com> References: <1421333111-22136-1-git-send-email-michael.qiu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] librte_pmd_ixgbe: Add queue start failure check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jan 2015 10:01:14 -0000 Hi Michael, I'm clearly not the maintainer of ixgbe, so I'd prefer someone else reviewing this patch. However I have few comments. 2015-01-15 22:45, Michael Qiu: > - ixgbe_dev_rxtx_start(dev); > + err = ixgbe_dev_rxtx_start(dev); > + if (err < 0) { > + PMD_INIT_LOG(ERR, "Unable to start rxtx queues\n"); \n is not needed in PMD_INIT_LOG. Is this useful to print a log here, given that there already has some logs in ixgbe_dev_rxtx_start? > + PMD_INIT_LOG(ERR, "Start tx queue failed\n"); [...] > + PMD_INIT_LOG(ERR, "Start rx queue failed\n"); Please remove \n. Except these minor comments, it looks good. Thanks -- Thomas