From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id CA12E1B1BC for ; Sat, 7 Oct 2017 00:31:25 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 588DD20E46; Fri, 6 Oct 2017 18:31:25 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Fri, 06 Oct 2017 18:31:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=6VM8/zC4DeYATi0 ABN6QWKHNjb6AYdwCEECrOPs7sFA=; b=g8NrgNMHWaDdskMJRParqu2s1+JOH+3 u35YN8cUI+HWULECaUo4T1VgWFL62PDdBMYJclI4qEdpnr6SwRFYn6PPcpB08iH8 JU42Diq4pgwIC046DNEVUIuZnMsfuNzPqd2LidMN0atYQ/Ki/+LQZY+paZex3ZLF Jns04P+OLD+s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=6VM8/zC4DeYATi0ABN6QWKHNjb6AYdwCEECrOPs7sFA=; b=mgpaUo/S YyG3Dq1NifHJyLLosWlvEVwmuIa5HkFEXs0Kp9Ev03qyPvL3U1cCI13ir+rXtRSG Hui8ZhbF4jlAdOytzjGzHsBeQO/8GATLteEaxN5KLxL5APVisbwOZhuCQ/XZJwIc jKr97/zbnbHBLAlCJPAJ1sQglOyejN0kBopsiuGRrA1f7qBPMewnumAB4CK9iaQS Ij0NwqxvrzCLSZmhJeNwYwjSlMCndKX0qqZFE5m9vIXTN8r77RsQBjz1lLnkz3SL 4+cK8ILAXlx72a62ryMKXxe+zb9dntM8rZsa9DuNzJ3M/LBVxTJzBl5tn+sCsFqz u2gQAcAIGM5Oew== X-ME-Sender: X-Sasl-enc: HnmH23+S3ACXoqhWRr2AVcmlMofK6GY5dCEYQIMm+lx8 1507329085 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 049CF7E8E6; Fri, 6 Oct 2017 18:31:25 -0400 (EDT) From: Thomas Monjalon To: Yangchao Zhou Cc: dev@dpdk.org, "De Lara Guarch, Pablo" , Vladimir Medvedkin Date: Sat, 07 Oct 2017 00:31:24 +0200 Message-ID: <32775928.OAvXbfsJxg@xps> In-Reply-To: References: <1503403355-4917-1-git-send-email-zhouyates@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] hash: optimize the softrss computation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Oct 2017 22:31:26 -0000 22/09/2017 17:33, De Lara Guarch, Pablo: > From: Vladimir Medvedkin > > 2017-08-22 15:02 GMT+03:00 Yangchao Zhou : > > > > > Use rte_bsf32 and fast bit unset operation to optimize the softrss > > > computation. > > > The following measurements shows improvement over the default softrss > > > computation function. > > > > > > tuple lens old(cycles) new(cycles) > > > 3 1225 337 > > > 9 3743 992 > > > > > > Signed-off-by: Yangchao Zhou > > Commit message is a bit long. Could you wrap it to have less than 75 characters per line? > Although, the patch itself has lines with more than 90 characters, which should be avoided: > > http://dpdk.org/ml/archives/test-report/2017-August/027283.html > > Last thing, the "Reviewed-by" has an extra space, before the name. Applied, thanks