From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B854DA0561; Sun, 19 Apr 2020 15:10:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8691F1D63C; Sun, 19 Apr 2020 15:10:35 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 32E0D1D60D for ; Sun, 19 Apr 2020 15:10:34 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 865D05C00AF; Sun, 19 Apr 2020 09:10:33 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sun, 19 Apr 2020 09:10:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= FKmz+nq19Sho/CuzwfUMqm27DlyYRDZSs7pc4GNSSAQ=; b=f3yKwr+KDrwHu74w RpiBR2bp4bWQSzMJQMf2wTTA8awnNqaE8p3rT/paoWlePU/58Gdgaw7b5GQP0FoI QIR54fN9ksCVA625Tirl5KnPTtOkK7NLFNXXQs2GF0GOuz5x2YTiD0UDSXi9gsWl m1LbMaQMSdTb1ixQeWVjnHFaD2BZxKfN3lQvgNy7eAdVRyD5jC+lV5sahNrE5r8+ KdJIR8fLmxlrh7F/OlNeQEuQz3cJ9wjFflfTmtcYzeBhBPI1183TxkGD091OVK5+ m3/5W6q97J359NLNRI6COM8k2ivQK7rsJTs25lJ3anMEg2H0gLnmjZGShPLZVqan cQuKsg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=FKmz+nq19Sho/CuzwfUMqm27DlyYRDZSs7pc4GNSS AQ=; b=Q3tLrZlASR+yPBhTiLYAowWTVQgxgFiON4iAfmT4YD7w3k5ud2dI2fqMB YwlVRKw+bNz38tJWNKxzHb6iF/nbDU2gvnZKa4jNbf0l9efa/rvp9AznJOodu3bN 1NIGMrRmqPqa16eCAO+dHBrYRFUsC4DyDy8CR6tfMr++DLOGq1zxXsRtjbPyf+rg aeFABoJhm+CY98orzmhlKW0x3OHVjq2ow7QPjny12y9N3at5odDB9+R3BGWpA8P+ IgfuhtRYPnUWyr1Dz2sYmuCRIp4dtt+a+ofDCerzDNN4lOoHsV88xLPl1Y+FWGFv Go7TUiZ3mxcR2U+UieItdfb4zK1DQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrgedugdeivdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgepudenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 94A1B3280059; Sun, 19 Apr 2020 09:10:32 -0400 (EDT) From: Thomas Monjalon To: "Burakov, Anatoly" Cc: dev@dpdk.org, Tal Shnaiderman , bruce.richardson@intel.com, david.marchand@redhat.com Date: Sun, 19 Apr 2020 15:10:31 +0200 Message-ID: <3278563.U75o6juQT5@thomas> In-Reply-To: <4193388.A7TYtsqqnE@thomas> References: <651f25bd-29e2-2058-70e8-59829e0b53bb@intel.com> <4193388.A7TYtsqqnE@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] rte_vfio_container_dma_map/unmap functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 19/04/2020 15:09, Thomas Monjalon: > 17/04/2020 16:09, Burakov, Anatoly: > > On 17-Apr-20 3:05 PM, Burakov, Anatoly wrote: > > > On 22-Mar-20 5:20 PM, Tal Shnaiderman wrote: > > >> Hi Anatoly, > > >> > > >> I=E2=80=99m working on the implementation of bus/pci driver for Wind= ows,=20 > > >> pci_common.c uses the titled functions however they are relevant onl= y=20 > > >> for Linux OS. > > >> > > >> I=E2=80=99m wondering if the implementation of those functions shoul= d be moved=20 > > >> to a Linux specific area since FreeBSD (and now Windows) are forced = to=20 > > >> implemented those in the current state. > >=20 > > Unfortunately, we don't have a generic API for these, but since we=20 > > export a single API on all platforms, either all platforms have to=20 > > implement these functions, or none of them do. There's simply no way to= =20 > > avoid implementing stubs for these functions, short of coming up with a= =20 > > generic API that would replace these. Given that this API is heavily=20 > > Linux specific, i don't see that happening. >=20 > Because it is Linux specific, we should not force FreeBSD and Windows > having stubs. Can we move VFIO calls in Linux-specific files? >=20 > I think rte_vfio.h should be moved in lib/librte_eal/linux/include. +Cc Bruce and David