From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id 664AE569A for ; Thu, 9 Jul 2015 03:40:41 +0200 (CEST) Received: by wiclp1 with SMTP id lp1so95942816wic.0 for ; Wed, 08 Jul 2015 18:40:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=bgA0O2Bp2zujgUrHrQQiuCk+Nc6jwJfTAFNTzRW4ruI=; b=WkqPU35h67UXzaF9fI+F5d+Gq+f+Zw2zKAHLkLmi1Cxc/c8vD2V9x9b5xskX8TK5oV QqxDQj2uvcpSQhFCN8B56J2iaUomyqIU6xM7rIrRHCLK9cXoNT6PiPInUv1ax6Eud0H5 gGiRrqE9uVnnmvug+pCQw/bsyV0KaDLZQx03bRgVwiBgSg0g8CpxQEJtWzar6TO5YkKy it2hLGxfeDfjE6fuWSDSZ/Cl4rjC73CJc8YKicUTsGygDX5pm8MgM+VRyEmoaz3sU5WJ bu7F5zlgEKX1/MFnfdWuEslC1pyUPp5qOYQXitWuZfNd5WXAqYJ/N4QqX/CxksN2tJzq diLg== X-Gm-Message-State: ALoCoQnqfztmsPCHdMIIFSAAnL88Kg8P//rA5qWijpJmSPF4S7K1cC9Al72FghLplGOXWTOdhQSr X-Received: by 10.194.175.65 with SMTP id by1mr27137549wjc.152.1436406041291; Wed, 08 Jul 2015 18:40:41 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id js3sm6135078wjc.5.2015.07.08.18.40.39 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Jul 2015 18:40:40 -0700 (PDT) From: Thomas Monjalon To: Maryam Tahhan Date: Thu, 09 Jul 2015 03:39:35 +0200 Message-ID: <3280448.8fAfYn9D23@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1436118000-132275-9-git-send-email-maryam.tahhan@intel.com> References: <1436118000-132275-1-git-send-email-maryam.tahhan@intel.com> <1436118000-132275-9-git-send-email-maryam.tahhan@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 8/8] app: add a new app proc_info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jul 2015 01:40:41 -0000 2015-07-05 18:40, Maryam Tahhan: > proc_info displays statistics information including extened stats for typo: extended > given DPDK ports and dumps the memory information for DPDK. > > Signed-off-by: Maryam Tahhan > --- > MAINTAINERS | 4 + > app/Makefile | 1 + > app/proc_info/Makefile | 45 +++++ > app/proc_info/main.c | 512 +++++++++++++++++++++++++++++++++++++++++++++++++ > mk/rte.sdktest.mk | 4 +- > 5 files changed, 564 insertions(+), 2 deletions(-) A doc would be useful. > +DIRS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += proc_info Why only Linux? > +# Copyright(c) 2010-2014 Intel Corporation. All rights reserved. Too old :) > + if ((!port->rx_queue_stats_mapping_enabled) && (!port->tx_queue_stats_mapping_enabled)) { > + printf(" RX-packets: %-10"PRIu64" RX-missed: %-10"PRIu64" RX-bytes: " > + "%-"PRIu64"\n", > + stats.ipackets, stats.imissed, stats.ibytes); > + printf(" RX-badcrc: %-10"PRIu64" RX-badlen: %-10"PRIu64" RX-errors: " > + "%-"PRIu64"\n", > + stats.ibadcrc, stats.ibadlen, stats.ierrors); > + printf(" RX-nombuf: %-10"PRIu64"\n", > + stats.rx_nombuf); > + printf(" TX-packets: %-10"PRIu64" TX-errors: %-10"PRIu64" TX-bytes: " > + "%-"PRIu64"\n", > + stats.opackets, stats.oerrors, stats.obytes); > + } else { > + printf(" RX-packets: %10"PRIu64" RX-errors: %10"PRIu64 > + " RX-bytes: %10"PRIu64"\n", > + stats.ipackets, stats.ierrors, stats.ibytes); > + printf(" RX-badcrc: %10"PRIu64" RX-badlen: %10"PRIu64 > + " RX-errors: %10"PRIu64"\n", > + stats.ibadcrc, stats.ibadlen, stats.ierrors); > + printf(" RX-nombuf: %10"PRIu64"\n", > + stats.rx_nombuf); > + printf(" TX-packets: %10"PRIu64" TX-errors: %10"PRIu64 > + " TX-bytes: %10"PRIu64"\n", > + stats.opackets, stats.oerrors, stats.obytes); > + } Why the formatting is different depending of device-specific stats mapping? > + if (port->rx_queue_stats_mapping_enabled) { > + printf("\n"); > + for (i = 0; i < RTE_ETHDEV_QUEUE_STAT_CNTRS; i++) { > + printf(" Stats reg %2d RX-packets: %10"PRIu64 > + " RX-errors: %10"PRIu64 > + " RX-bytes: %10"PRIu64"\n", > + i, stats.q_ipackets[i], stats.q_errors[i], stats.q_ibytes[i]); > + } > + } Why restricting stats per queue to devices requiring a mapping? > - $(RTE_OUTPUT)/app/dump_cfg --file-prefix=ring_perf ; \ This should have been removed in previous patch.