From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 1C49BA0546;
Tue, 6 Apr 2021 17:24:44 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id BAD121411EB;
Tue, 6 Apr 2021 17:24:43 +0200 (CEST)
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
[66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 3A2C91411D5
for <dev@dpdk.org>; Tue, 6 Apr 2021 17:24:42 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
by mailout.nyi.internal (Postfix) with ESMTP id BB8755C0203;
Tue, 6 Apr 2021 11:24:41 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute2.internal (MEProxy); Tue, 06 Apr 2021 11:24:41 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=fm3; bh=
fEOdeb9DH7bdJVXqqY9AHUKTQLTI02YESeOf2jJ0XSc=; b=XuMUQtqQ/h9Ueb7K
KE3O9qzsvhdHvzeDr5F7XzesHzg0fYQX9/qvardZrCD3T8h8a2rpXITkjyE8qUM/
rXSTb0D5bompqXwq4ezwnnKnHFWGRMeRg9zVg6E7MxWs2g/R9wTUDoR38hYo/iFW
rizQHRKN2KXwYELxamwl62Q6mfmS9hssQDVJJjh3PnW5KAD1NjxQ0k4kjtHyvfK+
t8eZ7FqaireLmH+g0cKpCO26a5xijAUOnTONsRJXit2CFQiyImPIKQFeVCw+Kp7Z
0Cpj8mc1ZfGH3szTogJYYA4NY3kAsSV74fdTgyGM3M+xxsp2WYG60nc8hdK803b5
DkT8NA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm2; bh=fEOdeb9DH7bdJVXqqY9AHUKTQLTI02YESeOf2jJ0X
Sc=; b=vaEfnLH6jhM9LA+8bKGigsoUHqnfFBsBKakDikw0VQDiXVkC3c9uc6Npc
HXYTNLfJVJnq4I/Yg4PkFQyVSvyTOEa6/4gE+FcYvgyKd4J99Jh9Z9clqkge3DSO
luM+IWu4vwAU8Z6/cb5y+bW0Y8j5qYRyL1pVvfLiLWARTCoFQEVjnVNyW1/vVBNr
OlwwAB4vW6MRb3smB21sFbH0Zl4dH5OIm+u8L1iNkUpF1U5cKKSW44KFx1aGl+Np
WWAdxRAt8CviVRnQ7vXDGsdLd2afoIRFMpk+wqHjtn9Fiq160JQXeyq+UwszGQ3e
7Gsik26/QF6iddXFUFGcyTFkHTV1A==
X-ME-Sender: <xms:OH1sYGzYz3EJIIwbwwAr3ih0QYiTnO57APM7Z13T-TYkn9FFYSgomw>
<xme:OH1sYCRKdqV0QcOiBIJdZ0TB1Goq5v1u0hj9YGfAMq0APBgicAwNTV1IcrC-EGCLr
Yrli7J60D4Syz3Y2Q>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudejhedgfeegucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu
ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf
hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl
ohhnrdhnvght
X-ME-Proxy: <xmx:OH1sYIVBikL_yQd1DhUBMI-Uw87n7x6SNitecpGqHncL-lt_pBdvQA>
<xmx:OH1sYMjPOo1JTONYt8pPs-yXYIKQ7XJo1QULkup81rzmt56uKPUsEw>
<xmx:OH1sYIDsWzHG58CxtMiRU2yS63lH8ldgoamB8h0Gzc417jGaJPwu9w>
<xmx:OX1sYB4M4Ra3UaJExDW0oj61SPoNKi5_qTMlQfuLjBMldYbwcP27Aw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 80BC61080057;
Tue, 6 Apr 2021 11:24:40 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Stanislaw Kardach <kda@semihalf.com>
Cc: dev@dpdk.org, Michal Krawczyk <mk@semihalf.com>, erik.g.carrillo@intel.com
Date: Tue, 06 Apr 2021 17:24:39 +0200
Message-ID: <3282663.DU2RlWCeFW@thomas>
In-Reply-To: <20210326104759.280175-3-mk@semihalf.com>
References: <20210326104759.280175-1-mk@semihalf.com>
<20210326104759.280175-3-mk@semihalf.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH 2/2] test: proceed if timer subsystem was
initialized
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
26/03/2021 11:47, Michal Krawczyk:
> From: Stanislaw Kardach <kda@semihalf.com>
>
> rte_timer_subsystem_init() may return -EALREADY if the timer subsystem
> was already initialized. This can happen i.e. in PMD code (see
> eth_ena_dev_init). This is not an error, rather a notification as the
> initialization function simply returns without any action taken.
Missing these lines:
Fixes: 50247fe03fe0 ("test/timer: exercise new APIs in secondary process")
Cc: stable@dpdk.org
> Signed-off-by: Stanislaw Kardach <kda@semihalf.com>
> Reviewed-by: Michal Krawczyk <mk@semihalf.com>
> ---
> app/test/test.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/app/test/test.c b/app/test/test.c
> index 624dd48042..864523ed61 100644
> --- a/app/test/test.c
> +++ b/app/test/test.c
> @@ -134,8 +134,13 @@ main(int argc, char **argv)
> goto out;
> }
>
> + argv += ret;
> +
> + prgname = argv[0];
> +
> #ifdef RTE_LIB_TIMER
> - if (rte_timer_subsystem_init() < 0) {
> + ret = rte_timer_subsystem_init();
> + if (ret < 0 && ret != -EALREADY) {
> ret = -1;
> goto out;
> }
> @@ -146,10 +151,6 @@ main(int argc, char **argv)
> goto out;
> }
>
> - argv += ret;
> -
> - prgname = argv[0];
> -
How this change for argv/prgname is related to the fix?