From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: walimisdev@gmail.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] doc: fix wrong hugepages setting path
Date: Thu, 11 Feb 2021 19:19:01 +0100 [thread overview]
Message-ID: <3286416.bNJGnR0ycZ@thomas> (raw)
In-Reply-To: <20201206094337.37cf321b@hermes.local>
06/12/2020 18:43, Stephen Hemminger:
> On Mon, 7 Dec 2020 01:31:14 +0800
> walimisdev@gmail.com wrote:
>
> > From: Wang Liming <walimisdev@gmail.com>
> >
> > Remove redundant "nr_hugepages" words from mlx4 and mlx5 doc.
> >
> > Signed-off-by: Wang Liming <walimisdev@gmail.com>
> > ---
> > doc/guides/nics/mlx4.rst | 2 +-
> > doc/guides/nics/mlx5.rst | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
[...]
> > --- a/doc/guides/nics/mlx5.rst
> > +++ b/doc/guides/nics/mlx5.rst
> > #. Request huge pages::
> >
> > - echo 1024 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages/nr_hugepages
> > + echo 1024 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages
>
> Could we change the drivers to refer to the existing hugepages script
> rather than doing "roll your own"
I agree. I've sent a patch to use the new script wherever needed:
https://patches.dpdk.org/patch/87877/
prev parent reply other threads:[~2021-02-11 18:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-06 17:31 walimisdev
2020-12-06 17:43 ` Stephen Hemminger
2021-02-11 18:19 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3286416.bNJGnR0ycZ@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=walimisdev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).