DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] doc: fix wrong hugepages setting path
@ 2020-12-06 17:31 walimisdev
  2020-12-06 17:43 ` Stephen Hemminger
  0 siblings, 1 reply; 3+ messages in thread
From: walimisdev @ 2020-12-06 17:31 UTC (permalink / raw)
  To: dpdk-dev; +Cc: Wang Liming

From: Wang Liming <walimisdev@gmail.com>

Remove redundant "nr_hugepages" words from mlx4 and mlx5 doc.

Signed-off-by: Wang Liming <walimisdev@gmail.com>
---
 doc/guides/nics/mlx4.rst | 2 +-
 doc/guides/nics/mlx5.rst | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/doc/guides/nics/mlx4.rst b/doc/guides/nics/mlx4.rst
index 354c2bb82..b40954e88 100644
--- a/doc/guides/nics/mlx4.rst
+++ b/doc/guides/nics/mlx4.rst
@@ -405,7 +405,7 @@ devices managed by librte_net_mlx4.
 
 #. Request huge pages::
 
-      echo 1024 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages/nr_hugepages
+      echo 1024 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages
 
 #. Start testpmd with basic parameters::
 
diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index 3bda0f841..afefe6a3a 100644
--- a/doc/guides/nics/mlx5.rst
+++ b/doc/guides/nics/mlx5.rst
@@ -1594,7 +1594,7 @@ ConnectX-4/ConnectX-5/ConnectX-6/BlueField devices managed by librte_net_mlx5.
 
 #. Request huge pages::
 
-      echo 1024 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages/nr_hugepages
+      echo 1024 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages
 
 #. Start testpmd with basic parameters::
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: fix wrong hugepages setting path
  2020-12-06 17:31 [dpdk-dev] [PATCH] doc: fix wrong hugepages setting path walimisdev
@ 2020-12-06 17:43 ` Stephen Hemminger
  2021-02-11 18:19   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2020-12-06 17:43 UTC (permalink / raw)
  To: walimisdev; +Cc: dpdk-dev

On Mon,  7 Dec 2020 01:31:14 +0800
walimisdev@gmail.com wrote:

> From: Wang Liming <walimisdev@gmail.com>
> 
> Remove redundant "nr_hugepages" words from mlx4 and mlx5 doc.
> 
> Signed-off-by: Wang Liming <walimisdev@gmail.com>
> ---
>  doc/guides/nics/mlx4.rst | 2 +-
>  doc/guides/nics/mlx5.rst | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/doc/guides/nics/mlx4.rst b/doc/guides/nics/mlx4.rst
> index 354c2bb82..b40954e88 100644
> --- a/doc/guides/nics/mlx4.rst
> +++ b/doc/guides/nics/mlx4.rst
> @@ -405,7 +405,7 @@ devices managed by librte_net_mlx4.
>  
>  #. Request huge pages::
>  
> -      echo 1024 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages/nr_hugepages
> +      echo 1024 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages
>  
>  #. Start testpmd with basic parameters::
>  
> diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
> index 3bda0f841..afefe6a3a 100644
> --- a/doc/guides/nics/mlx5.rst
> +++ b/doc/guides/nics/mlx5.rst
> @@ -1594,7 +1594,7 @@ ConnectX-4/ConnectX-5/ConnectX-6/BlueField devices managed by librte_net_mlx5.
>  
>  #. Request huge pages::
>  
> -      echo 1024 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages/nr_hugepages
> +      echo 1024 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages
>  
>  #. Start testpmd with basic parameters::
>  

Could we change the drivers to refer to the existing hugepages script
rather than doing "roll your own"

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: fix wrong hugepages setting path
  2020-12-06 17:43 ` Stephen Hemminger
@ 2021-02-11 18:19   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2021-02-11 18:19 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: walimisdev, dev

06/12/2020 18:43, Stephen Hemminger:
> On Mon,  7 Dec 2020 01:31:14 +0800
> walimisdev@gmail.com wrote:
> 
> > From: Wang Liming <walimisdev@gmail.com>
> > 
> > Remove redundant "nr_hugepages" words from mlx4 and mlx5 doc.
> > 
> > Signed-off-by: Wang Liming <walimisdev@gmail.com>
> > ---
> >  doc/guides/nics/mlx4.rst | 2 +-
> >  doc/guides/nics/mlx5.rst | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
[...]
> > --- a/doc/guides/nics/mlx5.rst
> > +++ b/doc/guides/nics/mlx5.rst
> >  #. Request huge pages::
> >  
> > -      echo 1024 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages/nr_hugepages
> > +      echo 1024 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages
> 
> Could we change the drivers to refer to the existing hugepages script
> rather than doing "roll your own"

I agree. I've sent a patch to use the new script wherever needed:
	https://patches.dpdk.org/patch/87877/



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-02-11 18:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-06 17:31 [dpdk-dev] [PATCH] doc: fix wrong hugepages setting path walimisdev
2020-12-06 17:43 ` Stephen Hemminger
2021-02-11 18:19   ` Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git