DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] pipeline: fix code generation for the recirculation ID instruction
@ 2022-07-18 12:59 Cristian Dumitrescu
  2022-08-29 10:17 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Cristian Dumitrescu @ 2022-07-18 12:59 UTC (permalink / raw)
  To: dev; +Cc: stable

The "offset" and "n_bits" fields were generated incorrectly, hence the
output C file was producing compilation errors when the "recircid"
instruction was used.

Fixes: 5ec76d29dc6 ("pipeline: support packet recirculation")
Cc: stable@dpdk.org

Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
 lib/pipeline/rte_swx_pipeline.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/lib/pipeline/rte_swx_pipeline.c b/lib/pipeline/rte_swx_pipeline.c
index 732a064a60..3e1c6e9edb 100644
--- a/lib/pipeline/rte_swx_pipeline.c
+++ b/lib/pipeline/rte_swx_pipeline.c
@@ -11095,8 +11095,10 @@ instr_recircid_export(struct instruction *instr, FILE *f)
 		"\t{\n"
 		"\t\t.type = %s,\n"
 		"\t\t.io = {\n"
-		"\t\t\t.offset = %u,\n"
-		"\t\t\t.n_bits = %u,\n"
+		"\t\t\t.io = {\n"
+		"\t\t\t\t.offset = %u,\n"
+		"\t\t\t\t.n_bits = %u,\n"
+		"\t\t\t},\n"
 		"\t\t},\n"
 		"\t},\n",
 		instr_type_to_name(instr),
-- 
2.34.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] pipeline: fix code generation for the recirculation ID instruction
  2022-07-18 12:59 [PATCH] pipeline: fix code generation for the recirculation ID instruction Cristian Dumitrescu
@ 2022-08-29 10:17 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2022-08-29 10:17 UTC (permalink / raw)
  To: Cristian Dumitrescu; +Cc: dev, stable

18/07/2022 14:59, Cristian Dumitrescu:
> The "offset" and "n_bits" fields were generated incorrectly, hence the
> output C file was producing compilation errors when the "recircid"
> instruction was used.
> 
> Fixes: 5ec76d29dc6 ("pipeline: support packet recirculation")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Applied, thanks.




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-08-29 10:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-18 12:59 [PATCH] pipeline: fix code generation for the recirculation ID instruction Cristian Dumitrescu
2022-08-29 10:17 ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).