From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 6EA9C1B024 for ; Fri, 15 Dec 2017 12:00:04 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 96FF8208E8; Fri, 15 Dec 2017 06:00:03 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Fri, 15 Dec 2017 06:00:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=o31Hm+o66Um9iPisbZZdzyN36u UzYQtOoSstMaA7vq4=; b=S8gKeJtDjMefVvgS8q7+fqq6J8nUuKxGrZL3oSUKZY OR1DUCre0BrnsrZPzqwPl1rZRdqPgzvwNDBJan8G69mMl/8IP2B9+ANq5T3Wkd5j t1FfvrFx1hczyQpSERj12oprfFP0/80uGGbp/5qBJi2+QFmdILS9T1ibziS7uns5 8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=o31Hm+ o66Um9iPisbZZdzyN36uUzYQtOoSstMaA7vq4=; b=OqGvjCywI38kLghNyS+Q87 vfBCJQE4XFr6i3NyFmLUANyv/qLR3ImNh5ZrU+oeieJAmzW229Fw2ixJKZqgAuc8 lS9IMFeG+V9UJzrdFuy3mQGbNNVvmBGPbFf6ay3V82ZJrB3i5e9yViWvndxAcgGN CrJGO4pJ0FZN74y0T2+/cLYpZOXPRCl2EpcYA27V8YoT5zih20mTa6MznWgqwCws Tb9ai1HSMyWGke/+4Br+55U+2ZQMT04oXUBatjjhHNezwNhQoazP/J0rnklsAyu9 4LIedR7+rGdJT6KGdfUzJSN3Z/VPcHqg0DuZwvp570/ZWihowt1pFmmODZM4Ta0A == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 16CAC7E17D; Fri, 15 Dec 2017 06:00:03 -0500 (EST) From: Thomas Monjalon To: Olivier MATZ Cc: dev@dpdk.org, Samuel Gauthier Date: Fri, 15 Dec 2017 12:00:01 +0100 Message-ID: <3286914.MMPEBl9nmj@xps> In-Reply-To: <20171215104558.47nnc2nzmhbqndc6@platinum> References: <20171214142411.25375-1-olivier.matz@6wind.com> <5295568.lEBEY0ou7Q@xps> <20171215104558.47nnc2nzmhbqndc6@platinum> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] mk: fix libs installation when installing sdk X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Dec 2017 11:00:04 -0000 15/12/2017 11:45, Olivier MATZ: > On Fri, Dec 15, 2017 at 11:32:12AM +0100, Thomas Monjalon wrote: > > 15/12/2017 11:25, Olivier MATZ: > > > On Fri, Dec 15, 2017 at 11:19:57AM +0100, Thomas Monjalon wrote: > > > > 14/12/2017 15:24, Olivier Matz: > > > > > @@ -157,6 +157,8 @@ install-sdk: > > > > > $(Q)cp -a $O/.config $(DESTDIR)$(targetdir) > > > > > $(Q)cp -a $O/app/dpdk-pmdinfogen $(DESTDIR)$(targetdir)/app > > > > > $(Q)$(call rte_symlink, $(DESTDIR)$(includedir), $(DESTDIR)$(targetdir)/include) > > > > > + $(Q)$(call rte_mkdir, $(DESTDIR)$(libdir)) > > > > > + $(Q)cp -a $O/lib/* $(DESTDIR)$(libdir) > > > > > $(Q)$(call rte_symlink, $(DESTDIR)$(libdir), $(DESTDIR)$(targetdir)/lib) > > > > > > > > The libs are already installed with "make install-runtime". > > > > Either we add a dependency between install-sdk and install-runtime, > > > > or we clearly document it. > > > > > > To me, libs are needed when installing the sdk (to compile against them) > > > and when installing the runtime (to use them). > > > > > > Is it a problem to have it in both targets? > > > > Yes it is a problem because the general use is to call every targets, > > so the libs will be installed twice. Look at the global "install" target. > > > > Do you want to be able to install the SDK without the runtime? > > Hmm, you're right, installing the runtime instead of the sdk may be a > solution in our case. We don't need the bin, man, ... but it's probably > not an issue to have them anyway. > > So, to summarize: > install-runtime is the equivalent of the binary package > install-sdk is the equivalent of the -devel package Yes > And install-sdk depends on install-runtime, right? Depends logically, yes. But no dependence in the Makefile.