From: Thomas Monjalon <thomas@monjalon.net>
To: Tal Shnaiderman <talshn@nvidia.com>
Cc: dev@dpdk.org, pallavi.kadam@intel.com,
navasile@linux.microsoft.com, dmitrym@microsoft.com,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Subject: Re: [dpdk-dev] [PATCH v2] eal/windows: fix build warnings in MinGW
Date: Tue, 04 May 2021 19:17:01 +0200 [thread overview]
Message-ID: <3287565.MObxxFLoxm@thomas> (raw)
In-Reply-To: <20210426185853.092e098e@sovereign>
26/04/2021 17:58, Dmitry Kozlyuk:
> 2021-04-21 19:09 (UTC+0300), Tal Shnaiderman:
> > the strncasecmp macro defined in rte_os_shim.h is already
> > defined in MinGW-w64, as a result the compiler prints out
> > the warning below on function redefinition whenever compiling
> > a file including the header in debug mode.
> >
> > ..\lib/librte_eal/windows/include/rte_os_shim.h:21:
> > warning: "strncasecmp" redefined
> > #define strncasecmp(s1, s2, count) _strnicmp(s1, s2, count)
> >
> > Fixed by defining the macro only to the clang compiler.
> >
> > Fixes: 45d62067c237 ("eal: make OS shims internal")
> >
> > Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
>
> With librte_eal -> eal fixup,
> Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Applied, thanks.
prev parent reply other threads:[~2021-05-04 17:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-18 17:08 [dpdk-dev] [PATCH] " Tal Shnaiderman
2021-04-18 18:13 ` Thomas Monjalon
2021-04-18 19:04 ` Tal Shnaiderman
2021-04-18 20:23 ` Dmitry Kozlyuk
2021-04-19 6:57 ` Tal Shnaiderman
2021-04-19 18:06 ` Tal Shnaiderman
2021-04-19 18:15 ` Thomas Monjalon
2021-04-19 19:29 ` [dpdk-dev] [dpdk-ci] " Aaron Conole
2021-04-19 20:09 ` Dmitry Kozlyuk
2021-04-19 20:33 ` Lincoln Lavoie
2021-04-20 11:01 ` Tal Shnaiderman
2021-04-19 19:45 ` [dpdk-dev] " Dmitry Kozlyuk
2021-04-19 18:55 ` Dmitry Kozlyuk
2021-04-21 16:09 ` [dpdk-dev] [PATCH v2] " Tal Shnaiderman
2021-04-26 15:58 ` Dmitry Kozlyuk
2021-05-04 17:17 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3287565.MObxxFLoxm@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=talshn@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).