From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 30C9E1C4A for ; Fri, 12 May 2017 15:51:34 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 May 2017 06:51:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,330,1491289200"; d="scan'208";a="86785272" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.81]) ([10.237.220.81]) by orsmga004.jf.intel.com with ESMTP; 12 May 2017 06:51:33 -0700 To: Hemant Agrawal Cc: "dev@dpdk.org" , "shreyansh.jain@nxp.com" References: <1492607395-5922-1-git-send-email-hemant.agrawal@nxp.com> <1492607395-5922-2-git-send-email-hemant.agrawal@nxp.com> From: Ferruh Yigit Message-ID: <328e8ba9-25ec-00a6-b9d6-3d86b91e52a8@intel.com> Date: Fri, 12 May 2017 14:51:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <1492607395-5922-2-git-send-email-hemant.agrawal@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/4] net/dpaa2: improve the error handling in dev init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 May 2017 13:51:35 -0000 On 4/19/2017 2:09 PM, Hemant Agrawal wrote: > Signed-off-by: Hemant Agrawal <...> > - /*Close the device at underlying layer*/ > - ret = dpni_close(dpni, CMD_PRI_LOW, priv->token); > - if (ret) { > - PMD_INIT_LOG(ERR, "Failure closing dpni device with" > - " error code %d\n", ret); > - } > - > - /*Free the allocated memory for ethernet private data and dpni*/ > - priv->hw = NULL; > - free(dpni); Where this free operation done when it is removed from dpaa2_dev_uninit() ? > - > eth_dev->dev_ops = NULL; > eth_dev->rx_pkt_burst = NULL; > eth_dev->tx_pkt_burst = NULL; >