From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id 1AC877EB0 for ; Fri, 5 Dec 2014 17:07:53 +0100 (CET) Received: by mail-wi0-f177.google.com with SMTP id l15so1887458wiw.4 for ; Fri, 05 Dec 2014 08:07:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=NVq/gEpZ6lFlmhqznHQy3gldWdMWyM7bh9XcXoxC0pE=; b=WjPEKEAOBNe/nCcTv+LcI59W83ghs9tnzcxkqNBuAEYovdBA4QZAlhqnvx7p3xee4E s0S9WtkjiJnqn9Q+SmTI8MMPjnrEJeBhMf8iHn/Hdqy1uVFmRkABgpG0qURZqDtVxRK/ HgGmwUuM688NS/cjOXESX3OLTBO2HspF6w6/m+JUY5B7xCQk9+9j2rgiwBpPhsmAUwq5 APu+WNw7hPJroaUqGeEZal1jQWMQRP5sWPUsVOx2Qx0EiPCzySHKSJ6aizl6c0ibhgxj mYcp2P7MT+VrCajkT9eHB+nYHEQetEMGgmqI2DANVEnJCSOvFT8XOLGpWdKMQjaaehkz Lo7Q== X-Gm-Message-State: ALoCoQnvBF5LAeA66Sk1vxMKxne0CWMeD34SjZwiurEQKl3GGI4ZJEDZcSbF2Tb2OGIEu7wUUrzE X-Received: by 10.180.20.6 with SMTP id j6mr5072242wie.59.1417795672715; Fri, 05 Dec 2014 08:07:52 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id jr4sm5265358wjc.20.2014.12.05.08.07.51 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Dec 2014 08:07:52 -0800 (PST) From: Thomas Monjalon To: "Liu, Jijiang" Date: Fri, 05 Dec 2014 17:07:27 +0100 Message-ID: <3291312.KsF87lF78O@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <2601191342CEEE43887BDE71AB977258213BC0A5@IRSMSX105.ger.corp.intel.com> References: <1417532767-1309-1-git-send-email-jijiang.liu@intel.com> <2601191342CEEE43887BDE71AB977258213BC0A5@IRSMSX105.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v5 0/3] i40e VXLAN TX checksum rework X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Dec 2014 16:07:53 -0000 > > We have got some feedback about backward compatibility of VXLAN TX checksum offload API with 1G/10G NIC after the i40e VXLAN > > TX checksum codes were applied, so we have to rework the APIs on i40e, including the changes of mbuf, i40e PMD and csum forward > > engine. > > > > The main changes in mbuf are as follows, in place of removing PKT_TX_VXLAN_CKSUM, we introduce 4 new flags: > > PKT_TX_OUTER_IP_CKSUM, PKT_TX_OUTER_IPV4, PKT_TX_OUTER_IPV6 and PKT_TX_UDP_TUNNEL_PKT. Replace the inner_l2_len > > and the inner_l3_len field with the outer_l2_len and outer_l3_len field. > > > > Let's use a few examples to demonstrate how to use these new flags and existing flags in rte_mbuf.h > > Let say we have a tunnel packet: eth_hdr_out/ipv4_hdr_out/udp_hdr_out/vxlan_hdr/ehtr_hdr_in/ipv4_hdr_in/tcp_hdr_in. There > > could be several scenarios: > > > > A) User requests HW offload for ipv4_hdr_out checksum. > > He doesn't care is it a tunnelled packet or not. So he sets: > > > > mb->l2_len = eth_hdr_out; > > mb->l3_len = ipv4_hdr_out; > > mb->ol_flags |= PKT_TX_IPV4_CSUM; > > > > B) User is aware that it is a tunnelled packet and requests HW offload for ipv4_hdr_in and tcp_hdr_in *only*. > > He doesn't care about outer IP checksum offload. In that case, for FVL he has 2 choices: > > 1. Treat that packet as a 'proper' tunnelled packet, and fill all the fields: > > mb->l2_len = udp_hdr_out + vxlan_hdr +eth_hdr_in; > > mb->l3_len = ipv4_hdr_in; > > mb->outer_l2_len = eth_hdr_out; > > mb->outer_l3_len = ipv4_hdr_out; > > mb->ol_flags |= PKT_TX_UDP_TUNNEL_PKT | PKT_TX_IP_CKSUM | PKT_TX_TCP_CKSUM; > > > > 2. As user doesn't care about outer IP hdr checksum, he can treat everything before ipv4_hdr_in as L2 header. > > So he knows, that it is a tunnelled packet, but makes HW to treat it as ordinary (non-tunnelled) packet: > > mb->l2_len = eth_hdr_out + ipv4_hdr_out + udp_hdr_out + vxlan_hdr + ehtr_hdr_in; > > mb->l3_len = ipv4_hdr_in; > > mb->ol_flags |= PKT_TX_IP_CKSUM | PKT_TX_TCP_CKSUM; > > > > i40e PMD will support both B.1 and B.2, but ixgbe/igb/em PMD supports only B.2. > > if HW supports both - it will be up to user app which method to choose. > > tespmd will support both methods, and it should be configurable by user which approach to use (cmdline parameter). > > So the user can try/test both methods and select an appropriate for him. > > > > C) User knows that is a tunnelled packet, and wants HW offload for all 3 checksums: outer IP hdr checksum, inner IP checksum, inner > > TCP checksum. > > Then he has to setup all TX checksum fields: > > mb->l2_len = udp_hdr_out + vxlan_hdr +eth_hdr_in;; > > mb->l3_len = ipv4_hdr_in; > > mb->outer_l2_len = eth_hdr_out; > > mb->outer_l3_len = ipv4_hdr_out; > > mb->ol_flags |= PKT_TX_OUT_IP_CKSUM | PKT_TX_UDP_TUNNEL_PKT | PKT_TX_IP_CKSUM | PKT_TX_TCP_CKSUM; > > > > Change notes: > > v2 changes: > > remove PKT_TX_IP_CKSUM alias. > > add PKT_TX_OUT_IP_CKSUM and PKT_TX_OUTER_IPV6 in rte_get_tx_ol_flag_name. > > spliting mbuf changes into two patches. > > fix MACLEN caculation issue in i40e driver > > fix some issues in csumonly.c > > change cover letter. > > v3 changes: > > fix MACLEN caculation issue in i40e driver when non-tunneling packet > > v4 changes: > > reorganize patches to avoid compilation to be broken between patches. > > remove l4_tun_len from mbuf structure. > > add PKT_TX_OUTER_IPV4 to indicate no IP checksum offload requirement for tunneling packet. > > change i40e PMD and csum engine due to above changes. > > > > v5 changes: > > according to Konstantin's comments, optimize process_outer_cksums() in order to avoid setting PKT_TX_OUTER_IPV4 flags for the > > case when user didn't enable TESTPMD_TX_OFFLOAD_VXLAN_CKSUM > > > > Jijiang Liu (3): > > Redefine PKT_TX_IPV4, PKT_TX_IPV6 and PKT_TX_VLAN_PKT; > > Replace PKT_TX_VXLAN_CKSUM with PKT_TX_UDP_TUNNEL_PKT, and add 3 TX flags, which are PKT_TX_OUTER_IP_CKSUM, > > PKT_TX_OUTER_IPV4 and PKT_TX_OUTER_IPV6,and rework csum forward engine and i40e pmd due to these changes; > > Replace the inner_l2_len and the inner_l3_len field with the outer_l2_len and outer_l3_len field, and rework csum forward engine > > and i40e pmd due to these changes; > > Acked-by: Konstantin Ananyev Applied with small comments changes suggested by Olivier. Thanks everyone for finding a consensus. It's not easy to accept different of views but we finally did it! Lesson learned: every details of an API must be explicited with clear and short sentences. Thanks -- Thomas