From: Thomas Monjalon <thomas@monjalon.net>
To: Kevin Laatz <kevin.laatz@intel.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com
Subject: Re: [dpdk-dev] [PATCH] raw/ioat: fix kvlist free
Date: Mon, 19 Oct 2020 10:45:45 +0200 [thread overview]
Message-ID: <3292966.k0Lp3giagg@thomas> (raw)
In-Reply-To: <20201014100948.1210209-1-kevin.laatz@intel.com>
14/10/2020 12:09, Kevin Laatz:
> There is a null pointer check in 'idxd_vdev_parse_params()' which is
> causing a coverity issue. This check is redundant as the same check is
> being done in 'rte_kvargs_free()', so it is simply removed in this patch.
>
> In addition, kvlist was only being free'd on one path in this function.
> This is fixed by always free'ing kvlist before returning.
>
> Coverity issue: 363049
> Fixes: 777edf43ae4f ("raw/ioat: introduce vdev probe for DSA/idxd device")
>
> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
Applied, thanks
prev parent reply other threads:[~2020-10-19 8:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 10:09 Kevin Laatz
2020-10-19 8:45 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3292966.k0Lp3giagg@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=kevin.laatz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).