From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4DD44A04DC; Mon, 19 Oct 2020 10:45:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3DBEFBE48; Mon, 19 Oct 2020 10:45:51 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id E2233BE45 for ; Mon, 19 Oct 2020 10:45:48 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 92D895C00A9; Mon, 19 Oct 2020 04:45:47 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 19 Oct 2020 04:45:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= MlXJdx3EffzddB7NpduHG/JinxuRErSJLb6bvfNoELM=; b=Ksn5rGv3VA2Y1fki tE4ZfWWtDUo91On6Q4JObr2G4tqmCwZix0J3Uc7B+FIffQ+F+7DT8Wg8yxK8rruw KsPb/tzR3DCZhHsqgzna/z1XGh6nfYIQ91Z7Tz1uLMTf2SNEA23a3WGtYossv3yn wVTjmw7kBXuCrSQicW2RgLzxlNQJEYA7XmY4BQpblGVBTmkacKvAR1A8q52PcP4X NF0gHXlzFbHXyAzbbGKlcurT3qWsfrEZCcAwqiez0ikxHxP155sxDd7gGOPTNjPO +IPNJwVmsT+929k/u2aNhlPl5BjgcS5dQHQbX4A9/DfaWtN03au/zF/lfyJekAnD FUNNbA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=MlXJdx3EffzddB7NpduHG/JinxuRErSJLb6bvfNoE LM=; b=lm68xGXuBuyT7h4sMCkZme0Xgur6e1aIdZpJ84EEoHENU51CFsJ9XKxZm I6RWtkMky9ce6lhp+7Tb9b+f+547zxNK1q64MNzR4lzxtt9MOBkityqRXsm0Hf67 RBzn33zxHIcu80frufKKdQ8Vfzog+v+SHvvKNykYsPhuYOGf6Gn8MYfX6m1BhmtZ t4yUf+45VcM8x38bNdAk3aSxpBpnB7f2oS5usoVGtoR1GnVzAefOHmCWvjraqbTv yihlGQRqo2HWnoAYzhexleK0Fr8+/s1YBjbD7C7PzBCjt9ags9WdDtnOkSN1whfR 2XkkXQview29Prb+QeCQXZ2LiK3SA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrjedugddtkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 91A773280059; Mon, 19 Oct 2020 04:45:46 -0400 (EDT) From: Thomas Monjalon To: Kevin Laatz Cc: dev@dpdk.org, bruce.richardson@intel.com Date: Mon, 19 Oct 2020 10:45:45 +0200 Message-ID: <3292966.k0Lp3giagg@thomas> In-Reply-To: <20201014100948.1210209-1-kevin.laatz@intel.com> References: <20201014100948.1210209-1-kevin.laatz@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] raw/ioat: fix kvlist free X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/10/2020 12:09, Kevin Laatz: > There is a null pointer check in 'idxd_vdev_parse_params()' which is > causing a coverity issue. This check is redundant as the same check is > being done in 'rte_kvargs_free()', so it is simply removed in this patch. > > In addition, kvlist was only being free'd on one path in this function. > This is fixed by always free'ing kvlist before returning. > > Coverity issue: 363049 > Fixes: 777edf43ae4f ("raw/ioat: introduce vdev probe for DSA/idxd device") > > Signed-off-by: Kevin Laatz Applied, thanks