From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 353051AD79 for ; Fri, 8 Sep 2017 19:02:57 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Sep 2017 10:02:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,362,1500966000"; d="scan'208";a="1216404657" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by fmsmga002.fm.intel.com with ESMTP; 08 Sep 2017 10:01:33 -0700 To: Kirill Rybalchenko , dev@dpdk.org Cc: andrey.chilikin@intel.com, beilei.xing@intel.com, jingjing.wu@intel.com References: <1503569908-104074-1-git-send-email-kirill.rybalchenko@intel.com> <1504278166-32769-1-git-send-email-kirill.rybalchenko@intel.com> <1504278166-32769-5-git-send-email-kirill.rybalchenko@intel.com> From: Ferruh Yigit Message-ID: <3294fdd0-086f-208c-b027-8f115ceae6e3@intel.com> Date: Fri, 8 Sep 2017 18:01:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1504278166-32769-5-git-send-email-kirill.rybalchenko@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 4/4] ethdev: remove unnecessary check for new flow type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Sep 2017 17:02:58 -0000 On 9/1/2017 4:02 PM, Kirill Rybalchenko wrote: > Remove unnecessary check for new flow type for rss hash > filter update. > > Signed-off-by: Kirill Rybalchenko > --- > lib/librte_ether/rte_ethdev.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c > index 0597641..c470997 100644 > --- a/lib/librte_ether/rte_ethdev.c > +++ b/lib/librte_ether/rte_ethdev.c > @@ -2263,16 +2263,8 @@ int > rte_eth_dev_rss_hash_update(uint8_t port_id, struct rte_eth_rss_conf *rss_conf) > { > struct rte_eth_dev *dev; > - uint16_t rss_hash_protos; > > RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); > - rss_hash_protos = rss_conf->rss_hf; > - if ((rss_hash_protos != 0) && > - ((rss_hash_protos & ETH_RSS_PROTO_MASK) == 0)) { Can intention here be: ((rss_hash_protos & ~(ETH_RSS_PROTO_MASK)) != 0) > - RTE_PMD_DEBUG_TRACE("Invalid rss_hash_protos=0x%x\n", > - rss_hash_protos); > - return -EINVAL; > - } > dev = &rte_eth_devices[port_id]; > RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rss_hash_update, -ENOTSUP); > return (*dev->dev_ops->rss_hash_update)(dev, rss_conf); >