From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 3A01A2BF4 for ; Wed, 9 Mar 2016 01:35:15 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id p65so171606000wmp.1 for ; Tue, 08 Mar 2016 16:35:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=Of1I8Njbw96clru4MPENJ6DdtvPdpDFqkkS5UPlniBQ=; b=gOJJZDKz+3YW0TnuCT0uNaeHD0xeCL5pJmA0c0JO9w/Bz1ZyOxUzpZdhQDmcbQD5mY 2PUU13Z86HqQUGkQmFHrkecEGkkZ/RcqFAYVfPk5Ys0FKdg5Hn8+JXwqWAA+0z4janjT QuSJPWne1Lyp+PfT9xC6qZvhX50+VKXeZ3QXEiiFIDtk74I6d1PDfLnUOxrhqWgiaFMW v4pQcEOoIuA46wYk2WxCngcKFG1EMLKTlPBwPMPCxidwE2rb0dyqohmfQux3kCg0P/F+ G+xkWczltBJg3Be0egqzchgrbPu4qwYwaM1Vbn4+8oCzFN2RUH7HHh3LCcY2pCHhAUCm S+Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=Of1I8Njbw96clru4MPENJ6DdtvPdpDFqkkS5UPlniBQ=; b=l2iWfAy1IH6cuZ3W1n0yu3gZKPX7jxb2PD3ugOQlVrEn8ZFLp6hl6FxayEv/ii++L1 LQA3MJHlpmztYPWG4MjdAM0Edh1eFLicJvsWIodTuEsNT7sXvdR3xC6V6JUiNz4ir0BL fO91KdHZRMp07vVPTxDS+u401KjFajSoNgDomWw4ac5C2lxigaPjNSJorFCpFhITRNd7 K8hIv0SOEt2ZtJSO8ZP1v2aw9i+7ciUlgMYCwxfkiVeAB9ATPlVex8NvBelsdIiSxjjK +KiuwR23Lco4Fi2bpff8ctDeLRTz2oFaqHR2VtzWvDdxGax8qrQ7Wq3C1CHWAxXEpPzS 0gMg== X-Gm-Message-State: AD7BkJIksI4EMGVrROfEgSASCRIxYGR60Wmub0wDEsrka9R2FBYTnqh6FYU0fTrsiKaAJHYZ X-Received: by 10.28.30.208 with SMTP id e199mr1050448wme.74.1457483715112; Tue, 08 Mar 2016 16:35:15 -0800 (PST) Received: from xps13.localnet (171.36.101.84.rev.sfr.net. [84.101.36.171]) by smtp.gmail.com with ESMTPSA id v188sm17507904wmv.3.2016.03.08.16.35.14 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 08 Mar 2016 16:35:14 -0800 (PST) From: Thomas Monjalon To: Reshma Pattan Date: Wed, 09 Mar 2016 01:33:36 +0100 Message-ID: <3298735.LFDh5RH4eW@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1456920970-2047-1-git-send-email-reshma.pattan@intel.com> References: <1455289045-25915-1-git-send-email-reshma.pattan@intel.com> <1456920970-2047-1-git-send-email-reshma.pattan@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 0/5] add dpdk packet capture support for tcpdump X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Mar 2016 00:35:15 -0000 Hi, This series has not been reviewed enough to be ready for 16.04. So it would be good to restart the discussion about the tcpdump requirements. > packet capture flow for tcpdump: > ================================ > Part of the design is implemented in secondary process (proc_info.c) and other part > in primary process (eal_interrupt.c). Why proc_info is used? Why not a dedicated tool? > *User should request packet capture via proc_info application command line by passing newly > added tcpdump command line options i.e. [--tcpdump (port,queue)] [ --src-ip-filter \"A.B.C.D\"] > [--single-tcpdump-file]. > > Note: As basic support, a src ip filter option is provided for filtering the packets. > This is optional. If user dont provide any src ip filter option all packets will be captured > for tcpdump. Why filtering? Why only on IP address? Why not BPF? > 2: Because of the underlying pcap writing overhead packets can only be captured at slow rates. What is the benefit of slow rate capture in DPDK? Shouldn't we target a high rate mechanism?