From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30073.outbound.protection.outlook.com [40.107.3.73]) by dpdk.org (Postfix) with ESMTP id 0D34E3DC; Thu, 23 Aug 2018 03:23:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0CrwgGoNyAAEB/wi6Xa4+FxjtC5kxC6tmS/yEtiYqXY=; b=S7jycjhozjU1De0fQ4xL0XZwfLCKbjakXRRaYXIwj/ouEV5CbaqezUrg3Tu2TyNocf3i14OzL6cdEs9JF2lXkJnpsY1wKX1sM7ySFrszOX0kG5pdVOXbZ5pkqTRrTYLIsNg/7eAdxPkCSnHV8xNPfO5OS76rpyKqGXdH132CRE4= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB4075.eurprd05.prod.outlook.com (52.134.72.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1059.24; Thu, 23 Aug 2018 01:23:08 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::d45:8e84:6d63:c57c]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::d45:8e84:6d63:c57c%2]) with mapi id 15.20.1059.023; Thu, 23 Aug 2018 01:23:08 +0000 From: Yongseok Koh To: Alejandro Lucero CC: dpdk stable , dev , Thomas Monjalon Thread-Topic: [dpdk-dev] 17.11.4 patches review and test Thread-Index: AQHUNY2SOKtSvwXKMk+v7+wMKBsJwqTKAoWAgAIK4ICAAIcvAA== Date: Thu, 23 Aug 2018 01:23:08 +0000 Message-ID: <32EFE071-1F58-4C13-BCB2-0E8BD681B448@mellanox.com> References: <20180816181821.37143-1-yskoh@mellanox.com> <20180823001915.GA27470@yongseok-MBP.local> In-Reply-To: <20180823001915.GA27470@yongseok-MBP.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB3PR0502MB4075; 6:kkMVslE2zX3dOwLubgZlsqGfryIjYcxhkJEhrWQ2IZDTeZLDWmt9l/zwtPehpZTVgFb6QxO2I6OewHYQ17kI+nJbFGi1//xkmQPERZmae3xQ19PWNQc6IL0HlyiuPCauAzs7vosSnZUIcBWM7A5OsV7HvJ+XxZUN8vynHhXB4phCSFcD5Y9xIF6Qja6RJD+A/PsJ/jw6C9T1LzRzbmBE0S5kKxBYTAdcPa1g3Mw/zkgxjMWhzrJcX8SwXLK2GQqU+G0E6KI7ERL2OZ6Hc66/erG/+ixHKgcTmKbfYccI0nbFbcfSL4eJJjFb1a/qAXvOY7fpE+HZ9F9svxB2jtfJeAbEPoi987FHr0jgL+J+tnkIYK9z+zTpRM5wt4CFgbJW2cjcYpS3pdq4JTqEkDhHVpTv+o+MhnMhDrwimxFBFGWmggwaBO0cJiIMkP/K8impYpC3qBAoXTNhb9ulZDsNyw==; 5:lXjryuQsOrZc+cbSiOf1ggKTHZH+dsL+++3XAuSmToysJKBJc1An3g2Uh5Z+ikM2OVl2p1S2Qk9fFxxSZzaW5Yo6uXDDz1DI29RMn+wSZOzT661Jw5T6d5IRGNcE4DemObokqrHA6BDaSHO+obfTeVlz9IwEgC2txhoVmYb2XIE=; 7:Gck4UPhYr6RFMpRQRsQwING9P2p77ru2NaavpcYpbLNieQQKdvueOChORVMXPXeHrKueN3NV8vFVXeLgvIvZ2CdjtqgjKTjcyAT+2ab8IKMxZALotglhYoE7lniLmIXUG1xN8qnPcLWDJgIGkJIeRPQOv7Bw4HQZhFSIBSk+Dx4u7bjU2tRuS6WoFnD2mFrX+C7h2h5NppXmO5idzhX/3Dgz8QHa08Ogy/4eADU1ICng9rLPiWy5/s22T0vTS8K9 x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 7a310151-3189-4da8-c4e2-08d60896fbdd x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(5600074)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB4075; x-ms-traffictypediagnostic: DB3PR0502MB4075: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(189930954265078)(45079756050767)(17755550239193); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231311)(944501410)(52105095)(93006095)(93001095)(10201501046)(6055026)(149027)(150027)(6041310)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123560045)(201708071742011)(7699016); SRVR:DB3PR0502MB4075; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0502MB4075; x-forefront-prvs: 0773BB46AC x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(366004)(39860400002)(376002)(346002)(136003)(54094003)(199004)(189003)(6306002)(2616005)(54906003)(486006)(186003)(6436002)(6246003)(6916009)(229853002)(478600001)(106356001)(446003)(5660300001)(476003)(305945005)(966005)(11346002)(53546011)(7736002)(105586002)(6506007)(45080400002)(102836004)(76176011)(26005)(33656002)(6486002)(6512007)(14454004)(8936002)(8676002)(82746002)(83716003)(81156014)(14444005)(97736004)(3846002)(25786009)(36756003)(4326008)(68736007)(5250100002)(575784001)(2900100001)(66066001)(316002)(99286004)(81166006)(39060400002)(86362001)(2906002)(53936002)(6116002)(256004); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4075; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: C5EylAxwduPbPanocpcFSYzwwMkXkOTijLhOw5RxKuoRNE4TERs64I3NAHvGcAsBce6MuVW7osTQpwQ1P+fkSzZWl9LhuyFNoRCaqneI5Wx/kvoyy+StUJWA6/usZKBuKG6zJYoJVQVLIRlbNzoIuCaCzHJjlb848w9z6q1TVS2A1NlQOyXpMaRw8Y+SxsNepCSzoWR/4lRXn4V6R5waEFjOiQTdO3tSFhgprBkGpqQOw7LizpRCCOLxdS2U47wowdSTRKCTOpU2D/WArISJBhRWCPxvtmdHIqwOqxttzMSWPgR28kR0O/Fgw54QXy3i72syG6MXzCPjQjPhW9JooSWZNrIre8CAcv/RSiBEgak= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <10C798D212A15E489D68C55AD08C5D44@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a310151-3189-4da8-c4e2-08d60896fbdd X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Aug 2018 01:23:08.2141 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4075 Subject: Re: [dpdk-dev] 17.11.4 patches review and test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2018 01:23:10 -0000 > On Aug 22, 2018, at 5:19 PM, Yongseok Koh wrote: >=20 > On Tue, Aug 21, 2018 at 12:07:49PM +0200, Alejandro Lucero wrote: >> Hi Yonngseok, >>=20 >> There is a patchset aimed at 17.11.x: >>=20 >> https://emea01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fpat= ches.dpdk.org%2Fcover%2F42741%2F&data=3D02%7C01%7Cyskoh%40mellanox.com%= 7Cb1b0e3eff71c499ff3fb08d6088e1ede%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7= C0%7C636705803846548967&sdata=3D8f12c1IuUe4mw2EaTZ18vVTuLTjXOD2cSe%2B%2= B7f6OFfk%3D&reserved=3D0 >>=20 >> It was not accepted for master because the memory code has changed a lot >> since 17.11, and I'm working on another patchset for adjusting to the th= ose >> changes. >>=20 >> I wonder if there is any issue with adding this patchset to stable 17.11= .4. >> Note that this makes unlikely a known limitation with emulated IOMMU ins= ide >> VMs. >=20 > This patchset seems quite large for stable release and need to be well ve= rified > before GA. In -rc1 stage, we don't usually take such a large patchset as = people > have already started verification. And we don't usually release -rc2. If = you're > trying to solve a very critical issue with this patchset, I have to relea= se -rc2 > and ask people to verify again. How critical is your issue? Looks like you have sent a mail to stable@dpdk.org in July. http://mails.dpdk.org/archives/stable/2018-July/008589.html I don't know why some of emails to stable@dpdk.org haven't arrived at my ma= ilbox. I'm still trying to figure out the reason with IT depart in my company and re-subscribed to the mailing list as well. My apologies for that. Yongseok > For the patchset, > - "mem: add function for checking memsegs IOVAs addresses" > This is adding a new API, so I don't expect any API/ABI breakage, but wa= nt to > double-confirm with Thomas. Thomas? >=20 > - "bus/pci: use IOVAs check when setting IOVA mode" > All the patches got ack except for this one but from looking at the thre= ads in > dev mailing list, it looks okay. I have a question though. >=20 >> @@ -640,13 +643,17 @@ >> { >> struct rte_pci_device *dev =3D NULL; >> struct rte_pci_driver *drv =3D NULL; >> + int iommu_dma_mask_check_done =3D 0; >>=20 >> FOREACH_DRIVER_ON_PCIBUS(drv) { >> FOREACH_DEVICE_ON_PCIBUS(dev) { >> if (!rte_pci_match(drv, dev)) >> continue; >> - if (!pci_one_device_iommu_support_va(dev)) >> - return false; >> + if (!iommu_dma_mask_check_done) { >> + if (pci_one_device_iommu_support_va(dev)= < 0) >=20 > pci_one_device_iommu_support_va() returns true/false(1/0), then why do yo= u > expect to see a negative return value in case of failure? >=20 >> + return false; >> + iommu_dma_mask_check_done =3D 1; >> + } >> } >> } >> return true;