From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8712FA0C48; Wed, 7 Jul 2021 05:16:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 063D64069E; Wed, 7 Jul 2021 05:16:51 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 117FE4003C for <dev@dpdk.org>; Wed, 7 Jul 2021 05:16:48 +0200 (CEST) Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4GKPdS72v8zZrWQ; Wed, 7 Jul 2021 11:13:32 +0800 (CST) Received: from dggpeml500024.china.huawei.com (7.185.36.10) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 7 Jul 2021 11:16:44 +0800 Received: from [127.0.0.1] (10.40.190.165) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 7 Jul 2021 11:16:44 +0800 To: Bruce Richardson <bruce.richardson@intel.com>, <dev@dpdk.org> CC: Jerin Jacob <jerinjacobk@gmail.com>, Jerin Jacob <jerinj@marvell.com>, =?UTF-8?Q?Morten_Br=c3=b8rup?= <mb@smartsharesystems.com> References: <1625231891-2963-1-git-send-email-fengchengwen@huawei.com> <20210706202841.661302-1-bruce.richardson@intel.com> From: fengchengwen <fengchengwen@huawei.com> Message-ID: <32b9fa47-918b-cb16-d4c1-729ee92ba6f4@huawei.com> Date: Wed, 7 Jul 2021 11:16:44 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20210706202841.661302-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.40.190.165] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [RFC UPDATE PATCH 0/9] dmadev rfc suggested updates X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> LGTM, thanks And I'am prepare dmadev V2, include: a) Fix code review comments (e.g. multiple-process support, doxygen, comments, typo) b) Flatten device abstraction to two layer: dmadev <> vchan c) Public API use dev_id and vchan_id to locate one vchan d) Using the flags parameter instead of the fence API e) Rename rte_dmadev_perform to rte_dmadev_submit so it corresponds to the stats variable. PS: Some code (lib/dmadev) will rebase this patchset On 2021/7/7 4:28, Bruce Richardson wrote: > This patchset contains a series of changes to dmadev based on work being done to > port over our drivers to test this new infrastructure. Some of these are bug > fixes to enable compilation e.g. missing exports or meson.build files, while > others are suggested changes to enhance the API. All these patches are to be > applied on top of [1] as they are mostly suggested changes to that RFC i.e. > patches to the patch! > > The final patch includes some basic sanity tests for copy operations that we > have ported over from the ioat self-tests to use the dmadev APIs. The basic > dataplane part of those tests is probably ok for now, but the initialization of > queues in that test code may need some enhancement. Feedback welcome. > > A tree with all these patches applied can be got at [2] if anyone wants to use > that as a basis for working on drivers, or for other discussion. > > [1] http://patches.dpdk.org/project/dpdk/patch/1625231891-2963-1-git-send-email-fengchengwen@huawei.com/ > [2] https://github.com/bruce-richardson/dpdk/tree/dmadev-rfcs > > Bruce Richardson (9): > dmadev: add missing exports > dmadev: change virtual addresses to IOVA > dmadev: add dump function > dmadev: remove xstats functions > dmadev: drop cookie typedef > dmadev: allow NULL parameters to completed ops call > dmadev: stats structure updates > drivers: add dma driver category > app/test: add basic dmadev unit test > > app/test/meson.build | 2 + > app/test/test_dmadev.c | 320 +++++++++++++++++++++++++++++++++++ > drivers/dma/meson.build | 11 ++ > drivers/meson.build | 1 + > lib/dmadev/rte_dmadev.c | 66 ++------ > lib/dmadev/rte_dmadev.h | 204 +++++++--------------- > lib/dmadev/rte_dmadev_core.h | 16 +- > lib/dmadev/rte_dmadev_pmd.h | 24 +-- > lib/dmadev/version.map | 7 +- > 9 files changed, 425 insertions(+), 226 deletions(-) > create mode 100644 app/test/test_dmadev.c > create mode 100644 drivers/dma/meson.build > > -- > 2.30.2 > > > . >