DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Su, Simei" <simei.su@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Guo, Junfeng" <junfeng.guo@intel.com>,
	"Guo, Jia" <jia.guo@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4] net/iavf: fix invalid RSS type
Date: Mon, 2 Nov 2020 12:18:43 +0000
Message-ID: <32c3197e4b2f4a1996a553eb5b6b9ff2@intel.com> (raw)
In-Reply-To: <20201102115547.262237-1-simei.su@intel.com>



> -----Original Message-----
> From: Su, Simei <simei.su@intel.com>
> Sent: Monday, November 2, 2020 7:56 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Guo, Junfeng <junfeng.guo@intel.com>; Guo, Jia
> <jia.guo@intel.com>; Su, Simei <simei.su@intel.com>
> Subject: [PATCH v4] net/iavf: fix invalid RSS type
> 
> When a RSS rule with symmetric hash function, the RSS type shouldn't carry
> with SRC/DST_ONLY. This patch adds invalid RSS type check for the case.

Need to specify l3/l4 SRC/DST_ONLY 

> 
> Fixes: 91f27b2e39ab ("net/iavf: refactor RSS")
> 
> Signed-off-by: Simei Su <simei.su@intel.com>
> 
> v4:
> * Simplify code to be more readable.
> 
> v3:
> * Correct invalid case.
> 
> v2:
> * Move invalid check into "iavf_any_invalid_rss_type".

Version tracking should not be part of the commit log.

> ---
>  drivers/net/iavf/iavf_hash.c | 15 +++++++++++++--
>  1 file changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c index
> be821b6..915b7c5 100644
> --- a/drivers/net/iavf/iavf_hash.c
> +++ b/drivers/net/iavf/iavf_hash.c
> @@ -834,10 +834,21 @@ static struct rss_attr_type rss_attr_to_valid_type[] =
> {  };
> 
>  static bool
> -iavf_any_invalid_rss_type(uint64_t rss_type, uint64_t allow_rss_type)
> +iavf_any_invalid_rss_type(enum rte_eth_hash_function rss_func,
> +			  uint64_t rss_type, uint64_t allow_rss_type)
>  {
>  	uint32_t i;
> 
> +	/**
> +	 * Check if SRC/DST_ONLY is set for SYMMETRIC_TOEPLITZ
> +	 * hash function.

Need to specifyl3/l4 SRC/DST_ONLY

> +	 */
> +	if (rss_func == RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ) {
> +		if (rss_type & (ETH_RSS_L3_SRC_ONLY | ETH_RSS_L3_DST_ONLY |
> +		    ETH_RSS_L4_SRC_ONLY | ETH_RSS_L4_DST_ONLY))
> +			return true;
> +	}
> +
>  	/* check invalid combination */
>  	for (i = 0; i < RTE_DIM(invalid_rss_comb); i++) {
>  		if (__builtin_popcountll(rss_type & invalid_rss_comb[i]) > 1) @@
> -917,7 +928,7 @@ iavf_hash_parse_action(struct iavf_pattern_match_item
> *match_item,
>  			 */
>  			rss_type = rte_eth_rss_hf_refine(rss_type);
> 
> -			if (iavf_any_invalid_rss_type(rss_type,
> +			if (iavf_any_invalid_rss_type(rss->func, rss_type,
>  					match_item->input_set_mask))
>  				return rte_flow_error_set(error, ENOTSUP,
>  						RTE_FLOW_ERROR_TYPE_ACTION,
> --
> 2.9.5

Besides above minor captures
Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel after fix those captures.

Thanks
Qi

      reply	other threads:[~2020-11-02 12:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-30  3:16 [dpdk-dev] [PATCH] " Simei Su
2020-10-30  9:41 ` Zhang, Qi Z
2020-11-02  2:11   ` Su, Simei
2020-11-02  2:04 ` [dpdk-dev] [PATCH v2] " Simei Su
2020-11-02 11:39   ` [dpdk-dev] [PATCH v3] " Simei Su
2020-11-02 11:55     ` [dpdk-dev] [PATCH v4] " Simei Su
2020-11-02 12:18       ` Zhang, Qi Z [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32c3197e4b2f4a1996a553eb5b6b9ff2@intel.com \
    --to=qi.z.zhang@intel.com \
    --cc=dev@dpdk.org \
    --cc=jia.guo@intel.com \
    --cc=junfeng.guo@intel.com \
    --cc=simei.su@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git