DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Yuanhan Liu <yliu@fridaylinux.org>,
	Thomas Monjalon <thomas@monjalon.net>
Cc: olivier.matz@6wind.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [git pull] virtio changes for 17.11-rc1
Date: Mon, 9 Oct 2017 09:13:46 +0200	[thread overview]
Message-ID: <32c86cdd-91ad-b84d-2495-165a2c949751@redhat.com> (raw)
In-Reply-To: <20171009025502.GJ1545@yliu-home>



On 10/09/2017 04:55 AM, Yuanhan Liu wrote:
> On Sat, Oct 07, 2017 at 04:37:53PM +0200, Thomas Monjalon wrote:
>> 06/10/2017 08:45, Yuanhan Liu:
>>> Hi Thomas,
>>>
>>> Please consider pulling following virtio changes for 17.11-rc1 at
>>>      git://dpdk.org/next/dpdk-next-virtio    master
>>
>> There is a compilation error on ARM with
>> "net/virtio: rationalize setting of Rx/Tx handlers"
>> An include of rte_cpuflags.h is missing.
>>
>> There is also an error seen by clang in
>> "vhost-user: add support to IOTLB miss slave requests"
>> 	implicit conversion from enumeration type 'enum VhostUserSlaveRequest'
>> 	to different enumeration type 'VhostUserRequest'
>>
>> This last error may be a real issue because VHOST_USER_SLAVE_IOTLB_MSG in
>> VhostUserSlaveRequest can be understood as VHOST_USER_GET_FEATURES in
>> VhostUserRequest.
> 
> It won't be an issue, as the vhost-user frontend can distinguish it:
> the two different kind of messages are sent over by two different fd.

I agree this is not an issue.

Thanks,
Maxime

      reply	other threads:[~2017-10-09  7:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-06  6:45 Yuanhan Liu
2017-10-06  9:47 ` Thomas Monjalon
2017-10-06 10:50   ` Bruce Richardson
2017-10-06 12:04     ` Thomas Monjalon
2017-10-06 11:05   ` Yuanhan Liu
2017-10-07 14:37 ` Thomas Monjalon
2017-10-07 14:57   ` Thomas Monjalon
2017-10-09  8:20     ` Maxime Coquelin
2017-10-08 20:10   ` Olivier MATZ
2017-10-08 20:16     ` Thomas Monjalon
2017-10-09  2:43       ` Yuanhan Liu
2017-10-09  7:13         ` Maxime Coquelin
2017-10-09  2:55   ` Yuanhan Liu
2017-10-09  7:13     ` Maxime Coquelin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32c86cdd-91ad-b84d-2495-165a2c949751@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=dev@dpdk.org \
    --cc=olivier.matz@6wind.com \
    --cc=thomas@monjalon.net \
    --cc=yliu@fridaylinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).