Re: [EXTERNAL] [PATCH] eventdev: make flag types consistent with API

["Mattias Rönnblom" <hofors@lysator.liu.se>]

On 2025-06-26 16:12, Jerin Jacob wrote:
>> -----Original Message-----
>> From: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
>> Sent: Thursday, June 26, 2025 7:23 PM
>> To: Jerin Jacob <jerinj@marvell.com>
>> Cc: dev@dpdk.org; Mattias Rönnblom <hofors@lysator.liu.se>; Mattias
>> Rönnblom <mattias.ronnblom@ericsson.com>
>> Subject: [EXTERNAL] [PATCH] eventdev: make flag types consistent with API
>>
>> Make RTE_EVENT_DEV_CAP_* flags' type consistent with the
>> rte_event_dev_info. event_dev_cap's type. Make
>> RTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT consistent with
>> rte_event_dev_config. event_dev_cfg. Make RTE_EVENT_QUEUE_CFG_*
>> consistent with rte_event_queue_conf. event_queue_cfg.
>> ZjQcmQRYFpfptBannerStart Prioritize security for external emails:
>> Confirm sender and content safety before clicking links or opening attachments
>> <https://us-phishalarm-
>> ewt.proofpoint.com/EWT/v1/CRVmXkqW!ts3Z1f8UAnUatM-
>> c2X0aD7H4_qqzjrySG1jUvYxf1eRBZ8860NkImwsi5uDUghDl9AKXmmrCtH3GlRgf
>> gCqT-4SjRdXOG8_TYEA-KJNabA$>
>> Report Suspicious
>>
>> ZjQcmQRYFpfptBannerEnd
>> Make RTE_EVENT_DEV_CAP_* flags' type consistent with the
>> rte_event_dev_info.event_dev_cap's type.
>>
>> Make RTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT consistent with
>> rte_event_dev_config.event_dev_cfg.
>>
>> Make RTE_EVENT_QUEUE_CFG_* consistent with
>> rte_event_queue_conf.event_queue_cfg.
>>
>> Make RTE_EVENT_PORT_CFG_* consistent with
>> rte_event_port_conf.event_port_cfg.
>>
>> Make RTE_EVENT_TIMER_ADAPTER_CAP_* consistent with the caps parameter
>> in rte_event_eth_rx_adapter_caps_get().
>>
>> The flags were all unsigned long longs (64 bits), but the event_dev_cap,
>> event_dev_cfg, event_queue_cfg, and event_port_cfg fields and the caps
>> parameter are all uint32_t. This change makes the flags uint32_ts.
>>
>> Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
>> ---
>>   lib/eventdev/rte_eventdev.h | 64 ++++++++++++++++++-------------------
>>   1 file changed, 32 insertions(+), 32 deletions(-)
>>
>> diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h index
>> 3c7fcbf0be..9b44c24f0e 100644
>> --- a/lib/eventdev/rte_eventdev.h
>> +++ b/lib/eventdev/rte_eventdev.h
>> @@ -249,7 +249,7 @@ struct rte_mbuf; /* we just use mbuf pointers; no need
>> to include rte_mbuf.h */  struct rte_event;
>>
>>   /* Event device capability bitmap flags */
>> -#define RTE_EVENT_DEV_CAP_QUEUE_QOS           (1ULL << 0)
>> +#define RTE_EVENT_DEV_CAP_QUEUE_QOS           (UINT32_C(1) << 0)
> 
> Use RTE_BIT*
> 
> 

Of course. Thanks.