From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id ECCED1B10E for ; Wed, 17 Oct 2018 14:34:27 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Oct 2018 05:34:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,392,1534834800"; d="scan'208";a="82157778" Received: from dhunt5-mobl2.ger.corp.intel.com (HELO [10.237.221.115]) ([10.237.221.115]) by orsmga008.jf.intel.com with ESMTP; 17 Oct 2018 05:34:25 -0700 To: Thomas Monjalon Cc: dev@dpdk.org, john.mcnamara@intel.com, marko.kovacevic@intel.com References: <20181017112350.19811-1-david.hunt@intel.com> <19031454.2TYKyzlM3p@xps> <5b428dec-d773-7714-8642-eff5678f8dd2@intel.com> <1539779565.285794.1545097600.5D9A232A@webmail.messagingengine.com> From: "Hunt, David" Message-ID: <32e02310-aea4-7c3e-915e-34bdbb17a1ca@intel.com> Date: Wed, 17 Oct 2018 13:34:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1539779565.285794.1545097600.5D9A232A@webmail.messagingengine.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH] Update release notes for container power policies X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2018 12:34:28 -0000 On 17/10/2018 1:32 PM, Thomas Monjalon wrote: > Hunt, David: >> On 17/10/2018 12:43 PM, Thomas Monjalon wrote: >>> 17/10/2018 13:23, David Hunt: >>>> Signed-off-by: David Hunt >>>> --- >>>> doc/guides/rel_notes/release_18_11.rst | 7 +++++++ >>>> 1 file changed, 7 insertions(+) >>> Why this patch is alone? It is for a change already applied? >>> If you forgot the release notes, you should add a Fixes: line >>> so we know which code change it refers. >>> Thanks >> The related patch set is not merged yet, so I could not add a Fixes: line. >> This is in reference to one of the patch sets I mentioned in an email to >> you yesterday. >> http://patches.dpdk.org/project/dpdk/list/?series=1628 >> >> >>>> diff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11.rst >>>> index 9c00e33cc..3174a0f80 100644 >>>> --- a/doc/guides/rel_notes/release_18_11.rst >>>> +++ b/doc/guides/rel_notes/release_18_11.rst >>>> @@ -88,6 +88,13 @@ New Features >>>> the specified port. The port must be stopped before the command call in order >>>> to reconfigure queues. >>>> >>>> +* **Added JSON power policy interface for containers .** >>>> + >>>> + Extended the Power Library and vm_power_manger sample app to allow power >>>> + policies to be submitted via a FIFO using JSON formatted strings. Previously >>>> + limited to Virtual Machines, this feature extends power policy functionality >>>> + to containers and host applications that need to have their cores frequency >>>> + controlled based on the rules contained in the policy. >>>> >>>> API Changes >>>> ----------- >>> You must keep a double blank line before before next heading. >>> >>> Anyway you should move it before testpmd note, as explained in the comment: >>> Suggested order in release notes items: >>> * Core libs (EAL, mempool, ring, mbuf, buses) >>> * Device abstraction libs and PMDs >>> - ethdev (lib, PMDs) >>> - cryptodev (lib, PMDs) >>> - eventdev (lib, PMDs) >>> - etc >>> * Other libs >>> * Apps, Examples, Tools (if significative) >>> >> I can hold off uploading a v2 of this patch until the main patch set is >> merged? Then I can >> add in a Fixes: line and make your suggested changes. > In this case, it is a lot better to integrate it with one of the patches of your series, > maybe with the doc patch? Sure. Sounds like the best option. I'll upload shortly. Thanks, Dave.