From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
Joyce Kong <joyce.kong@arm.com>
Cc: "Jakub Grajciar" <jgrajcia@cisco.com>,
"Morten Brørup" <mb@smartsharesystems.com>,
"Ruifeng Wang" <ruifeng.wang@arm.com>,
dev@dpdk.org, nd@arm.com, stable@dpdk.org,
"Liangxing Wang" <liangxing.wang@arm.com>
Subject: Re: [PATCH v1] net/memif: fix segfault with Tx burst larger than 255
Date: Wed, 6 Dec 2023 19:17:27 +0000 [thread overview]
Message-ID: <3300a8c9-107f-4103-b735-a8b0c0bed906@amd.com> (raw)
In-Reply-To: <20231205103340.05563ee9@hermes.local>
On 12/5/2023 6:33 PM, Stephen Hemminger wrote:
> On Tue, 5 Dec 2023 04:05:24 +0000
> Joyce Kong <joyce.kong@arm.com> wrote:
>
>> There will be a segfault when tx burst size is larger than
>> 256. This is because eth_memif_tx uses an index i which is
>> uint8_t to count transmitted nb_pkts. Extend i to uint16_t,
>> the same size as nb_pkts.
>>
>> Fixes: b5613c8f9d0a ("net/memif: add a Tx fast path")
>> Cc: stable@dpdk.org
>>
>> Reported-by: Liangxing Wang <liangxing.wang@arm.com>
>> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
>> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
>> ---
>
> I wonder if other drivers have same bug?
>
> Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
>
Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2023-12-06 19:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 4:05 Joyce Kong
2023-12-05 18:33 ` Stephen Hemminger
2023-12-06 3:04 ` Joyce Kong
2023-12-06 19:17 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3300a8c9-107f-4103-b735-a8b0c0bed906@amd.com \
--to=ferruh.yigit@amd.com \
--cc=dev@dpdk.org \
--cc=jgrajcia@cisco.com \
--cc=joyce.kong@arm.com \
--cc=liangxing.wang@arm.com \
--cc=mb@smartsharesystems.com \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).