From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CBD554368D; Wed, 6 Dec 2023 20:17:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9D82F40298; Wed, 6 Dec 2023 20:17:37 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2078.outbound.protection.outlook.com [40.107.220.78]) by mails.dpdk.org (Postfix) with ESMTP id 00DD24021E; Wed, 6 Dec 2023 20:17:35 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gCynvRr67ohu2WipmXeNRJ3jEoXksB8GmxK0YPMSCFj3XRKXOmyqY7u50G2U1YUtNi5GVGl6zScOo3m2ev5JSjHQbJv+d4/ff2pTLc1S+nSmRf+VBWO2SezN0/2/ENKq7iOcEY7IDLuDX+lAbHEylsb2PtoC6eM3r3pq9Ge7OfwNdp+tbc7cju5B2beCUilGonsyXdI4+03ubllVU2N61SqeOjUOyi2J3sCRCrL8tB9A09A0cKbOA/fMdeVGirWckoF8nza+KvwHASJd6XLTm86vRkCYeWaH7RLdBTivZjjCQteKJ0C6DYW1IgdaKJOwepBVo6VkXuD7mDdbDbyX2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OFs2RedC3ABTwP7WlTlQYGuJECQT4M4w/tfWFLRcI98=; b=EENwX0ZaiKEFpokx3UQB01gWjqPnCPnGWp32ycwpr3lW//xjY9Jb6jxPtw1fp7E6rDk94OnqUphckLWQl2H9gyN/cLXFfN1dDHe661ABs7/7PUuRvvo+51x0XxzJt1VrKpkkJs2B1LpKaOgzIx6KTUJF735GVeuCSx2u8ulhyKBubG59ZLVJenXJX3CdVOzYVYTm44Z1Q8oA+umrIJYseianPNeXu3EhOjYF3ZUYGE685jnryzpC2tqfJUjL7zo/Id9BcARBuZ/70rkVitX0q+ytgHfeVZeWDmXdEnFLeW+QSqtxDOtesgih/P2xQNZKLNPGcxt6bnbj9KP7TA1QcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OFs2RedC3ABTwP7WlTlQYGuJECQT4M4w/tfWFLRcI98=; b=tus6CE/mUYn5Rh75QSH1YF8aG0oXiIp78m2ubjC1PMEZ9sinJA0NyVfCLS3SfDx8rXT30kawlPXpzWhJAW6OdUvH70Dl8m2XtUFoG9IJcq3N756/hejv8RRukNUX22PvUFlJnTTj6gtsn6XV4hsVXtXePiEWS+RY+8zLWR+1uno= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH7PR12MB5619.namprd12.prod.outlook.com (2603:10b6:510:136::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.34; Wed, 6 Dec 2023 19:17:33 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.7068.025; Wed, 6 Dec 2023 19:17:32 +0000 Message-ID: <3300a8c9-107f-4103-b735-a8b0c0bed906@amd.com> Date: Wed, 6 Dec 2023 19:17:27 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] net/memif: fix segfault with Tx burst larger than 255 Content-Language: en-US To: Stephen Hemminger , Joyce Kong Cc: Jakub Grajciar , =?UTF-8?Q?Morten_Br=C3=B8rup?= , Ruifeng Wang , dev@dpdk.org, nd@arm.com, stable@dpdk.org, Liangxing Wang References: <20231205040524.3525473-1-joyce.kong@arm.com> <20231205103340.05563ee9@hermes.local> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20231205103340.05563ee9@hermes.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR3P191CA0034.EURP191.PROD.OUTLOOK.COM (2603:10a6:102:55::9) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH7PR12MB5619:EE_ X-MS-Office365-Filtering-Correlation-Id: 4bd3f4d8-ed0b-4d60-35a2-08dbf68ffeb8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zfCVvO8SD53R7isZ+Ceat0N2AdKSb1YE872zZ2A9Y1PjZpDWcuB+qwohR84VyjqEMzhdb+qW9NqzJIm1S8YXo1wTdZOFavqY7mLLUybszuK88FZtLSkCgzKUN2cOOVXEhrO96f4CVKhk85QGAmv96FMZf16IbrbUhZruQ/DBJhO5UDgOHmUPeUH+tkfEqOsGJ4FL6jmAYZOGtMIQHrOiPjxlvESdoISvY70ToDrzp7zAkYs6WQpvJPJmb8zWmxLNuEI6fn2YBKCHp2He4IzALOTU/g70bbljpLkp/361XJ/gNI8jG9UAEQmcOe1LB83GieAHBc32UyktK/C1w6lyJBWVASTkO73604knqeDd2tghRHkCsK2bHUa4KCZtaauGdIyZTbkk2MRQxjg0v8LtBie6b1uB9fI9HT5YJCRtBquyO+dZXD3frbToTeIyFNglL//kC6MR3773LhNAV0nDUfeFRaA52GdfY4/f3NPs26ofJWq3cteDe4HINbZxrqFDIdrdCxT/VO39dmdBYZKKposSzscd5nY8dDnlxDPzkyt7xX6fLulvSHPT/ABAxqiV+8SXAQwzRqpXXXsvfrh/dEHsXtLSlvUYC97BDABE8NFHsVEhZTozXJjSqJd5id/0IoQslStOov3/a/E1S32/yA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(376002)(396003)(136003)(346002)(366004)(230922051799003)(1800799012)(451199024)(64100799003)(186009)(110136005)(53546011)(6666004)(478600001)(6486002)(6506007)(8936002)(4326008)(8676002)(66476007)(54906003)(316002)(66556008)(6512007)(86362001)(26005)(66946007)(31686004)(38100700002)(2616005)(31696002)(44832011)(5660300002)(4744005)(2906002)(36756003)(41300700001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R0pFWWpjeW9VaHFzN1I0TThaVWcvb2F4dU9HL3FiQkZhT1Z6UUloRUxjamRz?= =?utf-8?B?MHc3d0syZnZRYkJ1SExxUkJ0aVROL29sSGNRZHROKzM5QWZqVkh0Y1IwZFo3?= =?utf-8?B?S3ZxVE1MeGlvNlNpM0dXeUo0ai9VVkNSSStyOTJ5RXc3TStHd2doYWxYZGdI?= =?utf-8?B?cTQ1bFJ6UG5BaW1jd1A3bHFQdmg1SGNxck8wM0FxQkpvTlpyckIxQU5GbWN0?= =?utf-8?B?aG1DUUVrcDRoM1V5blUySGpvWjlSaEYzVGN2R1VDNVI0M3hSOVJ3MFVmaDZC?= =?utf-8?B?TTNNY2pMNWVSa0MrOWlFZ3d3d1EwRGdVZzJteUIwVXJvY05XZHpkcmZUU0lP?= =?utf-8?B?ZWlJWXBxdXVIcStrd1lRSDRrbkVId0dzaXl5RVFBUUYrNllRUmFFbDBmTHh3?= =?utf-8?B?REhKbG5KMWxWYWJjRlNYbStPVGNzZWtUWmNQRFJnUjBxMEJuWnVLTWc4SU9Z?= =?utf-8?B?emZ5Q0J1YWNESzQxZ0RaeGx2ck11bytmTmJZZ3hHTXRSZUhvMGtGS2k3S1hX?= =?utf-8?B?aWI2Yjd0czRQWmoycTdRbFVtWXdac2tiU1FqNG1kVy9FVTIzbGI2aDFuaFFM?= =?utf-8?B?a1l0NFl4aVBzTWZXTjFGZkxoeUgwczBWc2FjZ1BlNGsxM24rcnlPd0FOYzln?= =?utf-8?B?b2dWcXl3YmJxY3Z6Qk1pNmZmNXhqRFBlby9nTExtdzVoZ2c0d0hwSTNJWTMr?= =?utf-8?B?TTREbC9qZDJuTHVHclFORC80U2V1WG9BcU1tRTNuOVBvV3BpQzVyRFREcTUz?= =?utf-8?B?WlppOThzNjFHQ01tK1I0TmFmaWJKVlRMQjNHRlU0SnNKTkFrWkVXVkJ5M3ZI?= =?utf-8?B?b1RHZmxBY0J4Q1hEN2lIaWYyeHhtQzZPemFKZkxjU1EveG9tLzVNYmJzYnlG?= =?utf-8?B?d01mSEl2Y2VndVIrak9qUDhXS3dVa1FsYmtjcm53Zlp5U0s5UWFGQ29VNlFv?= =?utf-8?B?aHEzRG93UlJZK0xJR2FYRlVYYWdzbTZ6bmsvMW44cDUwY2pxU0VRZUE4YUJp?= =?utf-8?B?U1lNbUc2QS9XdG10d0tWV2FyeTFHbTNvQ0VoUnBqa1grci9oNS9qeVNKOHI3?= =?utf-8?B?aCs4SDFKQ1NmSlA0VytORWU5NGdpU0JTUG5RQzBTSUpYdnUweU90ZmlpWlRl?= =?utf-8?B?UFdleTlZdEQxUU0yOG9XK1RBZERzS3FiOVVWS1dGYys4MVdCZWc3ZTFxNkh0?= =?utf-8?B?b0Q3T3pSdUJXVnhVV1hvSmxyRGgydG14dUVWUERiY1NIR1Y5MWFaZGlSbkhi?= =?utf-8?B?bUxwL0x0SUpuSWgvdG9Bb3VnYVUwQXNvOUFUN2plL3JqV0QrejUxNllMWjgz?= =?utf-8?B?Z1dyQTFFTC8wOGpBaG53c244YVd1aExDd2pmRHI0cm93YkJjM3h2NTJ2MUNV?= =?utf-8?B?dklPa3JXcDYycEl1MHlzdEZWZi8ycXpNNUhyNnVBRTBKVm5SQlpRMzRtM2k4?= =?utf-8?B?RWlzdkd2VTVEWjVzRDB2VjlUM1o0MmdQelNVZ29xeHJpTHNYSGsyVVJ2QWJs?= =?utf-8?B?aWZWT1BFcnR0aVJkOEZ1RlJLdnFjbmV2aFcxTkxGL053alFMVTFBaVVBK1FV?= =?utf-8?B?TWhIMVVkak9VdHFvUmxUa00vTGNCZ0U5UEg5Wnk0M0JJV25WRUsyZzV4UzJz?= =?utf-8?B?c2dRdDA5eUZyMmlWLzI0YXpTOGJBQW56OGx5cURuencxTDN4bU0wSENtaFpQ?= =?utf-8?B?R3AvVnV6aTJaOThOSEpzb1pxNlZUcGFGL3hIbkZGbUlOelBRRVVHT1EzQUJq?= =?utf-8?B?V1AzNmRXcnhLOTM5MXFrNk85U3MzOUZCNHZtZld1QXFzUXlyQUZYdEQvRUEz?= =?utf-8?B?MFNTdm5wV0JXTU1RT3ZaMm9RRzcrNmtEandBT2ZLMlp2eFNuekRPL1pHaWc5?= =?utf-8?B?Q1htbkRwOVpVeEZXR21DSE5kb0RUUHZqU2RYTE9td0lGVERYQUIzMitLT3RI?= =?utf-8?B?M2I5enVJeW5wZmkwdjVCRVJQYTVWYXNpanRKVVR1NVRKVERBLzhRTzNwYWdN?= =?utf-8?B?dG9CaDVYV0x4Q3NwUUNHcnk2cGxORlRNT3BoaHhkbjdaZlBqaEhpdG4vejhr?= =?utf-8?B?MmNlbHRkYzhGNkdpaVlJbzFXdmRpaWJjd2VmNWM2eWNTSFI1SXpoOGtlRE1X?= =?utf-8?Q?LifI/Csiy1pYUOqaO4AXSAAu9?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4bd3f4d8-ed0b-4d60-35a2-08dbf68ffeb8 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2023 19:17:32.2730 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: n47hEx0afdC56pqwbI6oVgQ0zLPtWut5qFalpHTwzIcDkibYamCCDXftGb4SoU8P X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5619 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/5/2023 6:33 PM, Stephen Hemminger wrote: > On Tue, 5 Dec 2023 04:05:24 +0000 > Joyce Kong wrote: > >> There will be a segfault when tx burst size is larger than >> 256. This is because eth_memif_tx uses an index i which is >> uint8_t to count transmitted nb_pkts. Extend i to uint16_t, >> the same size as nb_pkts. >> >> Fixes: b5613c8f9d0a ("net/memif: add a Tx fast path") >> Cc: stable@dpdk.org >> >> Reported-by: Liangxing Wang >> Signed-off-by: Joyce Kong >> Reviewed-by: Ruifeng Wang >> --- > > I wonder if other drivers have same bug? > > Reviewed-by: Stephen Hemminger > Acked-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.