From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, david.marchand@redhat.com,
stephen@networkplumber.org,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>
Subject: Re: [dpdk-dev] [PATCH] switch default git branch name to main
Date: Wed, 12 Aug 2020 15:32:40 +0200 [thread overview]
Message-ID: <3302242.5n1W8FZEAv@thomas> (raw)
In-Reply-To: <20200812124739.GC312@bricha3-MOBL.ger.corp.intel.com>
12/08/2020 14:47, Bruce Richardson:
> On Wed, Aug 12, 2020 at 11:29:15AM +0200, Thomas Monjalon wrote:
> > The default git branch of the main DPDK repository has been renamed
> > from master to main.
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
[...]
> > -The backup maintainer for the master tree should be selected from the existing sub-tree maintainers from the project.
> > +The backup maintainer for the main tree should be selected
> > +from the existing sub-tree maintainers of the project.
>
> This does not need to be a straight master -> main replacement. I wonder if
> "release tree" would be a better name. However, "main" is probably clear
> enough, so I'm ok to keep this as suggested here.
"release tree" does not distinguish from stable releases.
I agree "main" is not ideal to identify the tree,
but I don't see any better wording.
[...]
> > Any release of DPDK can be designated as a Stable Release if a
> > maintainer volunteers to maintain it and there is a commitment from major
> > contributors to validate it before releases. If a release is to be designated
> > -as a Stable Release, it should be done by 1 month after the master release.
> > +as a Stable Release, it should be done by 1 month after the main release.
>
> Not sure if this the most readable. The term "release" might be better
> replaced with "version" to allow the use of "release" as a verb for
> readability.
>
> "Any release version of DPDK can be designated a Stable Release if ...
> If a version is to be a "Stable Release", it should be designated as such
> within one month of that version being initially released"
You wording is a lot better. I take it, thanks.
> As-is or with above suggestions, this seems fine.
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied with last suggestion, thanks
prev parent reply other threads:[~2020-08-12 13:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 9:29 Thomas Monjalon
2020-08-12 12:47 ` Bruce Richardson
2020-08-12 13:32 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3302242.5n1W8FZEAv@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).