From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C19CAA0524; Fri, 5 Feb 2021 21:34:07 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5BBC940682; Fri, 5 Feb 2021 21:34:07 +0100 (CET) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id E41C54067B for ; Fri, 5 Feb 2021 21:34:05 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id AFD2B6D4; Fri, 5 Feb 2021 15:34:04 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 05 Feb 2021 15:34:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= uKaHfWWLYIjiUxc6mrTiyjuqDktykyFlhLhVLut3yP4=; b=D75PoookNEkonfxZ aJF1LtpoOawpI7acMGlo4/eghc/gpW4VmFjgn1LaHlY2nh38pOIG3iy+2QMHnlDH GKXHi0xgE8FHNqwLzMmn63oPoYBelkx0g5Ng5uuDR7il/kcyKqYJ0aZfgP4ymU1c T7LZ0z4pklWdyCSxd/PrFA/wHi3zHY4/QJluYRE3mhCpiSEDU70tp6v/xH6UuKFx rLNSnAgbxP8+x5Int2k9jwTEVI6hgW/wxsDchF5jJqtcO0bdaZoTJ+Dfn37xxCmE BZAuqotWuAnsDAlGCHkcuCCRnmU9R8BbDxA40qwcV3nyRDCbyyx2kRm6wTcQnmM6 nPK6fw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=uKaHfWWLYIjiUxc6mrTiyjuqDktykyFlhLhVLut3y P4=; b=br556XvlcoOZqEz/4GdMMO7DSaHb1a0NjPhe/R1+63wZ5s9jTVZVEs9Kq 0Tu0RZoEtGmIEX1i7/U4BktitdZMTnwrATOYxQB1Z9P0YIgYE9VelFuK1Ow15jci 1d2vml1FcIdG+IJJfJz+kQcX8KteMVmipo7ssOTqNqAlaWRRYXPMuYT0zVaOOgl2 BoGVDUr7jBg7Uu0Fy45qp3gNHcNPUge6k8YBIFM8BVA4R50aBNDCin2EQZ0FLk3R xLIzMoNPeFW+7TdBHFwCyjmrfz0WYUU37vjMnpdrpwgRVPD2i0l9infgmXrNPF+n 5HFh6CTrL71459cp0JDOn8Mh+6FUw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrgeeigdduvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 112B9108005F; Fri, 5 Feb 2021 15:34:02 -0500 (EST) From: Thomas Monjalon To: Andrew Boyer Cc: dev , Alfredo Cardigliano , ferruh.yigit@intel.com, john.mcnamara@intel.com Date: Fri, 05 Feb 2021 21:34:02 +0100 Message-ID: <3305567.JaTTae7b9o@thomas> In-Reply-To: <45998836-B694-4B87-8EFC-C02B3AE9885F@pensando.io> References: <20210129224434.71536-1-aboyer@pensando.io> <6863089.ceCDWvJzC0@thomas> <45998836-B694-4B87-8EFC-C02B3AE9885F@pensando.io> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 6/13] net/ionic: clean up Tx queue version support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/02/2021 21:26, Andrew Boyer: > > On Feb 5, 2021, at 3:20 PM, Thomas Monjalon wrote: > > 29/01/2021 23:44, Andrew Boyer: > >> The ionic PMD only supports Tx queue version 1 or greater. > >> Version 1 introduced a new SGL format with support for more > >> fragments per descriptor. > >> > >> Add release notes and an explanation to the docs. > >> > >> Signed-off-by: Andrew Boyer > >> --- > >> +* **Updated the Pensando ionic driver.** > >> + > >> + Updated the Pensando ionic driver with new features and improvements, including: > >> + > >> + * Fixed bugs related to link autonegotiation. > >> + * Fixed bugs related to port start/stop and queue start/stop. > >> + * Added support for probing the supported queue versions. Note that > >> + extremely old (pre-1.0) firmware will no longer be usable with the PMD. > >> + * Removed unused code. > >> + * Reduced device startup time. > > > > Most of these items are unrelated to the rest of the patch. > > And in general we don't mention cleanup and fixes in "New Features". > > Actually we don't mention such minor things in the release notes. > > It describes all of the changes that went in for this release. It is recommended to add items in the release notes in the relevant patch so it allows easy finding of the code mentioned in the release notes. > Please feel free to remove any you feel are inappropriate - or send me a list and I will send a patch. It's not a big deal. I am just informing you as you are still quite new :) The most important is to avoid the release notes becoming a long list of fixes. Eventually we could remove the lines "Fixed bugs ..." and "Removed unused code" while doing the last cleanup.